Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.2.0 release proposal #38719

Merged
merged 86 commits into from May 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
db5ee23
test: update OpenSSL 3.0.0-alpha15 error messages
danbev Apr 28, 2021
b51b4fe
test: skip tests for openssl-3.0.0-alpha15
danbev Apr 28, 2021
f31a611
deps: V8: cherry-pick 530080c44af2
miladfarca Apr 30, 2021
e64ebac
test: fix flaky inspector-cli tests when breakpionts are restored
Trott Apr 27, 2021
727c2bc
test: move test-net-connect-econnrefused from pummel to sequential
Trott Apr 29, 2021
38644d6
doc: use sentence case in headers in src/crypto/README.md
Trott May 3, 2021
9e10e1a
doc: corrected workload name as per the latest VS Installer
MrJithil May 1, 2021
e0118f3
doc: remove extraneous dash from flag prefix
rhcarvalho May 4, 2021
03b4a3a
build: compile with -std=gnu++14
RaisinTen May 2, 2021
1514885
tools: make GH Actions workflows work if default branch is not master
aduh95 May 3, 2021
89e1dac
test: run message and pseudo-tty tests in parallel
richardlau May 1, 2021
e9d4c85
doc: use AIX instead of Aix in fs.md
Trott May 4, 2021
e59131d
doc: fix broken AHAFS link in fs doc
Trott May 4, 2021
c0f0c9a
typings: add JSDoc typings for readline
VoltrexKeyva Apr 15, 2021
ae9128e
doc: clarify DiffieHellmanGroup class docs
Linkgoron Apr 22, 2021
14a2a00
node-api: faster threadsafe_function
indutny May 1, 2021
6622650
test: increase coverage for Blob
Lxxyx May 3, 2021
5b44107
test: increase coverage for AbortController
Lxxyx May 3, 2021
f2f768f
test: complete coverage of querystring
pd4d10 May 3, 2021
4c70e42
doc: use `HEAD` instead of `master` for links
aduh95 May 3, 2021
1d9fd49
doc: fix code example in ecdh.setPublicKey()
JBaczuk May 4, 2021
cf4dc80
lib: make `IterableWeakMap` safe to iterate
aduh95 May 3, 2021
352a600
debugger: rename inspector-cli test module to debugger
Trott May 4, 2021
070ee4b
Revert "worker: remove `ERR_CLOSED_MESSAGE_PORT`"
juanarbol May 3, 2021
bfec80f
src: make workers messaging more resilient
juanarbol May 3, 2021
d9867b9
debugger: wrap lines longer than 80 chars
Trott May 4, 2021
e79f540
debugger: avoid non-ASCII char in code file
Trott May 4, 2021
11dd9a6
debugger: disable only the lint rules required by current file state
Trott May 4, 2021
47080bc
fs: use `assert` in `fsCall` argument checking
pd4d10 May 3, 2021
95db7d5
test: improve fs coverage
pd4d10 May 3, 2021
827ae05
deps: V8: backport c0fceaa0669b
Qard Apr 21, 2021
1a104ba
deps: V8: cherry-pick 272445f10927
Qard Apr 22, 2021
043b1aa
deps: V8: cherry-pick 5f4413194480
Qard Apr 27, 2021
a84e9b3
deps: V8: cherry-pick 4c074516397b
Qard Apr 29, 2021
ab29872
deps: V8: cherry-pick fa4cb172cde2
Qard May 3, 2021
36b9485
async_hooks: use new v8::Context PromiseHook API
Qard Dec 4, 2020
16a6c8d
debugger: refactor to use internal modules
aduh95 May 5, 2021
56bf6c1
doc: typo stats() should be stat(); clarity
700software May 4, 2021
178fe21
test: increase coverage for Histogram
Lxxyx May 5, 2021
ec2dbfb
deps: patch V8 to 9.0.257.25
targos May 5, 2021
48b557e
buffer: remove unreachable code
pd4d10 May 4, 2021
10aaf30
build: add missing torque output sources
richardlau May 6, 2021
8f78c66
test: call functions internally
VoltrexKeyva May 5, 2021
90b640e
meta: add v8 team
gengjiawen May 6, 2021
dcae032
buffer: remove TODOs in `atob` / `btoa`
XadillaX May 5, 2021
16b2fb4
test: increase coverage for repl
Lxxyx May 5, 2021
4001dd2
dgram: extract cluster lazy loading method to make it testable
pd4d10 May 6, 2021
24472d9
test,repl: fix tests when inspector is disabled
aduh95 May 6, 2021
d3de0ef
doc: fix fs.openSync() signature
lpinca May 8, 2021
3bb12db
build: remove dependency on `distutils.spawn`
richardlau May 5, 2021
e876118
fs: fix error when writing buffers > INT32_MAX
zbjornson May 5, 2021
4c49027
module: add support for `URL` to `import.meta.resolve`
aduh95 May 7, 2021
b0df28d
build: add workaround for V8 builds
richardlau May 11, 2021
be4b3a4
path: inline conditions
VoltrexKeyva May 9, 2021
5c71f49
deps: upgrade npm to 7.12.1
ruyadorno May 10, 2021
c182198
process: add `'worker'` event
jasnell May 12, 2021
ec8ab22
tools: add `Worker` to type-parser
jasnell May 12, 2021
3d8b8e1
http: refactor to remove redundant argument of _deferToConnect
pd4d10 May 8, 2021
3d0fad3
test: improve coverage of lib/os.js
pd4d10 May 12, 2021
4296591
build,src,test,doc: enable FIPS for OpenSSL 3.0
danbev Apr 26, 2021
36bb724
debugger: refactor `inspect_repl` to use primordials
aduh95 Apr 27, 2021
5a0b521
test: improve coverage of lib/_http_client.js
pd4d10 May 8, 2021
6620a31
doc: add ESM code examples in url.md
aduh95 May 12, 2021
c4b161c
doc: change color of doctag on night mode
Ayase-252 May 12, 2021
1765e32
doc: update contact info
gabrielschulhof May 14, 2021
608d0e1
deps: upgrade npm to 7.13.0
ruyadorno May 13, 2021
e2b8454
repl: fix Ctrl+C on top level await
aduh95 May 12, 2021
6b409cf
src: remove extra semi after member fn
codebytere May 14, 2021
a028805
tools: update ESLint to 7.26.0
cjihrig May 8, 2021
36bb8da
crypto: forbid NODE-ED25519 and NODE-ED448 "raw" key export
panva May 13, 2021
fbf02e3
util: add util.types.isKeyObject and util.types.isCryptoKey
panva May 10, 2021
524a9d6
src: update cares_wrap OpenBSD defines
addaleax May 13, 2021
c0deeea
lib: support setting process.env.TZ on windows
jasnell May 11, 2021
5c38a55
doc: clarify synchronous blocking of Worker stdio
jasnell May 12, 2021
3a5856c
fs: fix async iterator partial writes
Linkgoron May 9, 2021
347b9f2
errors: remove input from ERR_INVALID_URL message
moander May 9, 2021
0100a3b
doc: add documentation for fs.WriteStream.close()
ihiteshsharma May 9, 2021
5b25fbe
test: set common.bits to 64 for riscv64
andreas-schwab May 9, 2021
8590c15
doc: update abort signal in fs promise api example
MoritzKn May 13, 2021
5b40e2f
events: use nullish coalencing operator
VoltrexKeyva Apr 21, 2021
8eea317
test: stream.finished detects a destroyed IncomingMessage
Linkgoron May 12, 2021
ff1b432
test: refactor `test-readline-interface` to be shorter
juanarbol May 14, 2021
a0dc194
doc: document buffer.kStringMaxLength
tniessen May 14, 2021
718ad10
src: fix fatal errors when a current isolate not exist
legendecas May 10, 2021
267a84f
tools: remove redundant v8 config
gengjiawen May 6, 2021
6e69f84
2021-05-19, Version 16.2.0 (Current)
targos May 18, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 4 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Expand Up @@ -115,3 +115,7 @@
/lib/internal/bootstrap/* @nodejs/startup
/tools/code_cache/* @nodejs/startup
/tools/snapshot/* @nodejs/startup

# V8
/deps/v8/* @nodejs/v8-update
/tools/v8_gypfiles/* @nodejs/v8-update
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
@@ -1,9 +1,9 @@
<!--
Before submitting a pull request, please read
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md.
https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.

Commit message formatting guidelines:
https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build-tarball.yml
Expand Up @@ -5,6 +5,7 @@ on:
push:
branches:
- master
- main
- v[0-9]+.x-staging
- v[0-9]+.x

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build-windows.yml
Expand Up @@ -5,6 +5,7 @@ on:
push:
branches:
- master
- main
- canary
- v[0-9]+.x-staging
- v[0-9]+.x
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/commit-queue.yml
Expand Up @@ -28,7 +28,7 @@ jobs:
# See https://github.com/nodejs/node-core-utils/pull/486
fetch-depth: 0
# A personal token is required because pushing with GITHUB_TOKEN will
# prevent commits from running CI after they land on master. It needs
# prevent commits from running CI after they land. It needs
# to be set here because `checkout` configures GitHub authentication
# for push as well.
token: ${{ secrets.GH_USER_TOKEN }}
Expand Down Expand Up @@ -63,15 +63,13 @@ jobs:
owner: ${{ env.OWNER }}
repo: ${{ env.REPOSITORY }}
# Commit queue is only enabled for the default branch on the repository
# TODO(mmarchini): get the default branch programmatically instead of
# assuming `master`
base_ref: "master"
base_ref: ${{ github.repository.default_branch }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Configure node-core-utils
run: |
ncu-config set branch master
ncu-config set branch ${{ github.repository.default_branch }}
ncu-config set upstream origin
ncu-config set username "${{ secrets.GH_USER_NAME }}"
ncu-config set token "${{ secrets.GH_USER_TOKEN }}"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/coverage-linux.yml
Expand Up @@ -10,6 +10,7 @@ on:
push:
branches:
- master
- main
paths-ignore:
- 'doc/**'
- 'deps/**'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/coverage-windows.yml
Expand Up @@ -10,6 +10,7 @@ on:
push:
branches:
- master
- main
paths-ignore:
- 'doc/**'
- 'deps/**'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/linters.yml
Expand Up @@ -5,6 +5,7 @@ on:
push:
branches:
- master
- main
- v[0-9]+.x-staging
- v[0-9]+.x

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/misc.yml
Expand Up @@ -5,6 +5,7 @@ on:
push:
branches:
- master
- main
- v[0-9]+.x-staging
- v[0-9]+.x

Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/notify-force-push.yml
Expand Up @@ -2,6 +2,7 @@ on:
push:
branches:
- master
- main

name: Notify on Force Push
jobs:
Expand All @@ -17,7 +18,7 @@ jobs:
SLACK_ICON: https://github.com/nodejs.png?size=48
SLACK_TITLE: '${{ github.actor }} force-pushed to ${{ github.ref }}'
SLACK_MESSAGE: |
A commit was force-pushed to <https://github.com/${{ github.repository }}/tree/master|${{ github.repository }}@master> by <https://github.com/${{ github.actor }}|${{ github.actor }}>
A commit was force-pushed to <https://github.com/${{ github.repository }}/tree/${{ github.repository.default_branch }}|${{ github.repository }}@${{ github.repository.default_branch }}> by <https://github.com/${{ github.actor }}|${{ github.actor }}>
Before: <https://github.com/${{ github.repository }}/commit/${{ github.event.before }}|${{ github.event.before }}>
After: <https://github.com/${{ github.repository }}/commit/${{ github.event.after }}|${{ github.event.after }}>
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-asan.yml
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- master
- main
- canary
- v[0-9]+.x-staging
- v[0-9]+.x
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-linux.yml
Expand Up @@ -5,6 +5,7 @@ on:
push:
branches:
- master
- main
- canary
- v[0-9]+.x-staging
- v[0-9]+.x
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-macos.yml
Expand Up @@ -7,6 +7,7 @@ on:
push:
branches:
- master
- main
- canary
- v[0-9]+.x-staging
- v[0-9]+.x
Expand Down
143 changes: 132 additions & 11 deletions BUILDING.md
Expand Up @@ -246,8 +246,6 @@ Installation via Linux package manager can be achieved with:

FreeBSD and OpenBSD users may also need to install `libexecinfo`.

Python 3 users may also need to install `python3-distutils`.

#### macOS prerequisites

* Xcode Command Line Tools >= 11 for macOS
Expand All @@ -271,11 +269,6 @@ $ ./configure
$ make -j4
```

If you run into a `No module named 'distutils.spawn'` error when executing
`./configure`, please try `python3 -m pip install --upgrade setuptools` or
`sudo apt install python3-distutils -y`.
For more information, see <https://github.com/nodejs/node/issues/30189>.

The `-j4` option will cause `make` to run 4 simultaneous compilation jobs which
may reduce build time. For more information, see the
[GNU Make Documentation](https://www.gnu.org/software/make/manual/html_node/Parallel.html).
Expand Down Expand Up @@ -563,7 +556,7 @@ to run it again before invoking `make -j4`.
* [Python 3.9](https://www.microsoft.com/en-us/p/python-39/9p7qfqmjrfp7)
* The "Desktop development with C++" workload from
[Visual Studio 2019](https://visualstudio.microsoft.com/downloads/) or
the "Visual C++ build tools" workload from the
the "C++ build tools" workload from the
[Build Tools](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019),
with the default optional components
* Basic Unix tools required for some tests,
Expand Down Expand Up @@ -660,7 +653,7 @@ $ make

## `Intl` (ECMA-402) support

[Intl](https://github.com/nodejs/node/blob/master/doc/api/intl.md) support is
[Intl](https://github.com/nodejs/node/blob/HEAD/doc/api/intl.md) support is
enabled by default.

### Build with full ICU support (all locales supported by ICU)
Expand Down Expand Up @@ -766,7 +759,135 @@ as `deps/icu` (You'll have: `deps/icu/source/...`)

## Building Node.js with FIPS-compliant OpenSSL

The current version of Node.js does not support FIPS.
The current version of Node.js does not support FIPS when statically linking
(the default) with OpenSSL 1.1.1 but for dynamically linking it is possible
to enable FIPS using the configuration flag `--openssl-is-fips`.

### Configuring and building quictls/openssl for FIPS

For quictls/openssl 3.0 it is possible to enable FIPS when dynamically linking.
Node.js currently uses openssl-3.0.0+quic which can be configured as
follows:
```console
$ git clone git@github.com:quictls/openssl.git
$ cd openssl
$ ./config --prefix=/path/to/install/dir/ shared enable-fips linux-x86_64
```
This can be compiled and installed using the following commands:
```console
$ make -j8
$ make install_ssldirs
$ make install_fips
```

After the FIPS module and configuration file have been installed by the above
instructions we also need to update `/path/to/install/dir/ssl/openssl.cnf` to
use the generated FIPS configuration file (`fipsmodule.cnf`):
```text
.include fipsmodule.cnf

# List of providers to load
[provider_sect]
default = default_sect
# The fips section name should match the section name inside the
# included /path/to/install/dir/ssl/fipsmodule.cnf.
fips = fips_sect

[default_sect]
activate = 1
```

In the above case OpenSSL is not installed in the default location so two
environment variables need to be set, `OPENSSL_CONF`, and `OPENSSL_MODULES`
which should point to the OpenSSL configuration file and the directory where
OpenSSL modules are located:
```console
$ export OPENSSL_CONF=/path/to/install/dir/ssl/openssl.cnf
$ export OPENSSL_MODULES=/path/to/install/dir/lib/ossl-modules
```

Node.js can then be configured to enable FIPS:
```console
$ ./configure --shared-openssl --shared-openssl-libpath=/path/to/install/dir/lib --shared-openssl-includes=/path/to/install/dir/include --shared-openssl-libname=crypto,ssl --openssl-is-fips
$ export LD_LIBRARY_PATH=/path/to/install/dir/lib
$ make -j8
```

Verify the produced executable:
```console
$ ldd ./node
linux-vdso.so.1 (0x00007ffd7917b000)
libcrypto.so.81.3 => /path/to/install/dir/lib/libcrypto.so.81.3 (0x00007fd911321000)
libssl.so.81.3 => /path/to/install/dir/lib/libssl.so.81.3 (0x00007fd91125e000)
libdl.so.2 => /usr/lib64/libdl.so.2 (0x00007fd911232000)
libstdc++.so.6 => /usr/lib64/libstdc++.so.6 (0x00007fd911039000)
libm.so.6 => /usr/lib64/libm.so.6 (0x00007fd910ef3000)
libgcc_s.so.1 => /usr/lib64/libgcc_s.so.1 (0x00007fd910ed9000)
libpthread.so.0 => /usr/lib64/libpthread.so.0 (0x00007fd910eb5000)
libc.so.6 => /usr/lib64/libc.so.6 (0x00007fd910cec000)
/lib64/ld-linux-x86-64.so.2 (0x00007fd9117f2000)
```
If the `ldd` command says that `libcrypto` cannot be found one needs to set
`LD_LIBRARY_PATH` to point to the directory used above for
`--shared-openssl-libpath` (see previous step).

Verify the OpenSSL version:
```console
$ ./node -p process.versions.openssl
3.0.0-alpha16+quic
```

Verify that FIPS is available:
```console
$ ./node -p 'process.config.variables.openssl_is_fips'
true
$ ./node --enable-fips -p 'crypto.getFips()'
1
```

FIPS support can then be enable via the OpenSSL configuration file or
using `--enable-fips` or `--force-fips` command line options to the Node.js
executable. See sections
[Enabling FIPS using Node.js options](#enabling-fips-using-node.js-options) and
[Enabling FIPS using OpenSSL config](#enabling-fips-using-openssl-config) below.

### Enabling FIPS using Node.js options
This is done using one of the Node.js options `--enable-fips` or
`--force-fips`, for example:
```console
$ node --enable-fips -p 'crypto.getFips()'
```

### Enabling FIPS using OpenSSL config
This example show that using OpenSSL's configuration file, FIPS can be enabled
without specifying the `--enable-fips` or `--force-fips` options by setting
`default_properties = fips=yes` in the FIPS configuration file. See
[link](https://github.com/openssl/openssl/blob/master/README-FIPS.md#loading-the-fips-module-at-the-same-time-as-other-providers)
for details.

For this to work the OpenSSL configuration file (default openssl.cnf) needs to
be updated. The following shows an example:
```console
openssl_conf = openssl_init

.include /path/to/install/dir/ssl/fipsmodule.cnf

[openssl_init]
providers = prov
alg_section = algorithm_sect

[prov]
fips = fips_sect
default = default_sect

[default_sect]
activate = 1

[algorithm_sect]
default_properties = fips=yes
```
After this change Node.js can be run without the `--enable-fips` or `--force-fips`
options.

## Building Node.js with external core modules

Expand Down Expand Up @@ -804,4 +925,4 @@ When Node.js is built (with an intention to distribute) with an ABI
incompatible with the official Node.js builds (e.g. using a ABI incompatible
version of a dependency), please reserve and use a custom `NODE_MODULE_VERSION`
by opening a pull request against the registry available at
<https://github.com/nodejs/node/blob/master/doc/abi_version_registry.json>.
<https://github.com/nodejs/node/blob/HEAD/doc/abi_version_registry.json>.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Expand Up @@ -33,7 +33,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V16.md#16.1.0">16.1.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V16.md#16.2.0">16.2.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V16.md#16.1.0">16.1.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V16.md#16.0.0">16.0.0</a><br/>
</td>
<td valign="top">
Expand Down
2 changes: 1 addition & 1 deletion GOVERNANCE.md
Expand Up @@ -173,5 +173,5 @@ The TSC follows a [Consensus Seeking][] decision-making model per the

[Collaborators discussion page]: https://github.com/orgs/nodejs/teams/collaborators/discussions
[Consensus Seeking]: https://en.wikipedia.org/wiki/Consensus-seeking_decision-making
[TSC Charter]: https://github.com/nodejs/TSC/blob/master/TSC-Charter.md
[TSC Charter]: https://github.com/nodejs/TSC/blob/HEAD/TSC-Charter.md
[nodejs/node]: https://github.com/nodejs/node
12 changes: 6 additions & 6 deletions README.md
Expand Up @@ -176,7 +176,7 @@ For information about the governance of the Node.js project, see
* [fhinkel](https://github.com/fhinkel) -
**Franziska Hinkelmann** &lt;franziska.hinkelmann@gmail.com&gt; (she/her)
* [gabrielschulhof](https://github.com/gabrielschulhof) -
**Gabriel Schulhof** &lt;gabriel.schulhof@intel.com&gt;
**Gabriel Schulhof** &lt;gabrielschulhof@gmail.com&gt;
* [gireeshpunathil](https://github.com/gireeshpunathil) -
**Gireesh Punathil** &lt;gpunathi@in.ibm.com&gt; (he/him)
* [jasnell](https://github.com/jasnell) -
Expand Down Expand Up @@ -314,7 +314,7 @@ For information about the governance of the Node.js project, see
* [Flarna](https://github.com/Flarna) -
**Gerhard Stöbich** &lt;deb2001-github@yahoo.de&gt; (he/they)
* [gabrielschulhof](https://github.com/gabrielschulhof) -
**Gabriel Schulhof** &lt;gabriel.schulhof@intel.com&gt;
**Gabriel Schulhof** &lt;gabrielschulhof@gmail.com&gt;
* [gdams](https://github.com/gdams) -
**George Adams** &lt;george.adams@uk.ibm.com&gt; (he/him)
* [geek](https://github.com/geek) -
Expand Down Expand Up @@ -681,13 +681,13 @@ Other keys used to sign some previous releases:
Node.js is available under the
[MIT license](https://opensource.org/licenses/MIT). Node.js also includes
external libraries that are available under a variety of licenses. See
[LICENSE](https://github.com/nodejs/node/blob/master/LICENSE) for the full
[LICENSE](https://github.com/nodejs/node/blob/HEAD/LICENSE) for the full
license text.

[Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
[Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
[Contributing to the project]: CONTRIBUTING.md
[Node.js Website]: https://nodejs.org/
[OpenJS Foundation]: https://openjsf.org/
[Strategic Initiatives]: https://github.com/nodejs/TSC/blob/master/Strategic-Initiatives.md
[Strategic Initiatives]: https://github.com/nodejs/TSC/blob/HEAD/Strategic-Initiatives.md
[Technical values and prioritization]: doc/guides/technical-values.md
[Working Groups]: https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md
[Working Groups]: https://github.com/nodejs/TSC/blob/HEAD/WORKING_GROUPS.md
2 changes: 1 addition & 1 deletion SECURITY.md
Expand Up @@ -26,7 +26,7 @@ maintainers and should also be coordinated through the Node.js Ecosystem
Security Team via [HackerOne](https://hackerone.com/nodejs-ecosystem).

Details regarding this process can be found in the
[Security Working Group repository](https://github.com/nodejs/security-wg/blob/master/processes/third_party_vuln_process.md).
[Security Working Group repository](https://github.com/nodejs/security-wg/blob/HEAD/processes/third_party_vuln_process.md).

Thank you for improving the security of Node.js and its ecosystem. Your efforts
and responsible disclosure are greatly appreciated and will be acknowledged.
Expand Down
2 changes: 1 addition & 1 deletion benchmark/_http-benchmarkers.js
Expand Up @@ -5,7 +5,7 @@ const path = require('path');
const fs = require('fs');

const requirementsURL =
'https://github.com/nodejs/node/blob/master/benchmark/writing-and-running-benchmarks.md#http-benchmark-requirements';
'https://github.com/nodejs/node/blob/HEAD/benchmark/writing-and-running-benchmarks.md#http-benchmark-requirements';

// The port used by servers and wrk
exports.PORT = Number(process.env.PORT) || 12346;
Expand Down