bootstrap: include perf_hooks in the builtin snapshot #38971

joyeecheung · 2021-06-08T16:39:19Z

perf_hooks: refactor perf_hooks for snapshot building

Move Performance and InternalPerformance to a new
lib/internal/perf/performance.js
Move now() getMilestoneTimestamp() into
lib/internal/perf/utils.js
Rename lib/internal/perf/perf.js to
lib/internal/perf/performance_entry.js
Refresh time origin at startup (this means the
time origins could differ between snapshot building
time and snapshot creation time)

bootstrap: support perf hooks in snapshot

bootstrap: load perf_hooks eagerly during bootstrap

Refs: #35711

nodejs-github-bot · 2021-06-08T16:41:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38538/

nodejs-github-bot · 2021-06-10T06:30:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38555/

joyeecheung · 2021-06-10T06:31:51Z

Hmm, not sure why the windows build couldn't find the js2c output with this change, it only changed a few JS files in node.gyp (also the file name out\\Reease\\bj/global_intermediate/node_javascript.cc looks off)

 Traceback (most recent call last):
    File "D:\a\node\node\tools\js2c.py", line 222, in <module>
      main()
    File "D:\a\node\node\tools\js2c.py", line 218, in main
      JS2C(source_files, options.target)
    File "D:\a\node\node\tools\js2c.py", line 153, in JS2C
      write_if_chaged(out, target)
    File "D:\a\node\node\tools\js2c.py", line 187, in write_if_chaged
      with open(target, "wt") as output:
  FileNotFoundError: [Errno 2] No such file or directory: 'out\\Reease\\bj/global_intermediate/node_javascript.cc'
  js-heap-broker.cc
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'tools\js2c.py;src\inspector\node_protocol.pdl;src\inspector\node_protocol_config.json;deps\v8\include\js_protocol.pdl;out\Release\\obj\global_intermediate\concatenated_protocol.json;deps\openssl\openssl\util\libcrypto.num' exited with code 1. [D:\a\node\node\libnode.vcxproj]

nodejs-github-bot · 2021-06-16T15:56:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38653/

joyeecheung · 2021-06-17T19:36:57Z

I can reproduce the windows bug locally and upon checking the generated VS build files I noticed that the Command field in the generated js2c CustomBuild in libnode.vxproj includes all the library file names and it is extremely long, so I think my patch probably hit a bug by exceeding some length limit or something?

joyeecheung · 2021-06-17T19:59:55Z

When I tentatively remove one file from node.gyp (to shorten the length a bit) the action works again. I checked the length of the command and turns out it does exceed the Windows command length limit..I think we can work around it by stop passing the file names directly through command line. Will work on that later.

nodejs-github-bot · 2021-06-17T22:32:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38673/

joyeecheung · 2021-06-17T22:43:30Z

#39069 fixes the Windows bug for me locally

On Windows there is a limit to the length of commands, so there will be an error once the lengths of the JS file names combined exceed that limit. This patch modifies js2c.py so that it now takes a --directory argument to glob for .js and .mjs files in addition to the list of files passed directly. We still pass the additional files we include from deps/ directly through the command line, as we only includes some of them so we cannot simply glob, but those are limited so listing them out should be fine. Refs: https://docs.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation PR-URL: #39069 Refs: #38971 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

- Move Performance and InternalPerformance to a new lib/internal/perf/performance.js - Move now() getMilestoneTimestamp() into lib/internal/perf/utils.js - Rename lib/internal/perf/perf.js to lib/internal/perf/performance_entry.js - Refresh time origin at startup (this means the time origins could differ between snapshot building time and snapshot creation time)

nodejs-github-bot · 2021-06-25T13:09:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38762/

nodejs-github-bot · 2021-06-26T16:00:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38772/

- Move Performance and InternalPerformance to a new lib/internal/perf/performance.js - Move now() getMilestoneTimestamp() into lib/internal/perf/utils.js - Rename lib/internal/perf/perf.js to lib/internal/perf/performance_entry.js - Refresh time origin at startup (this means the time origins could differ between snapshot building time and snapshot creation time) PR-URL: #38971 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #38971 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung · 2021-06-28T08:28:53Z

Landed in 2de139b...58cfca8

On Windows there is a limit to the length of commands, so there will be an error once the lengths of the JS file names combined exceed that limit. This patch modifies js2c.py so that it now takes a --directory argument to glob for .js and .mjs files in addition to the list of files passed directly. We still pass the additional files we include from deps/ directly through the command line, as we only includes some of them so we cannot simply glob, but those are limited so listing them out should be fine. Refs: https://docs.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation PR-URL: #39069 Refs: #38971 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

- Move Performance and InternalPerformance to a new lib/internal/perf/performance.js - Move now() getMilestoneTimestamp() into lib/internal/perf/utils.js - Rename lib/internal/perf/perf.js to lib/internal/perf/performance_entry.js - Refresh time origin at startup (this means the time origins could differ between snapshot building time and snapshot creation time) PR-URL: #38971 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #38971 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com>

On Windows there is a limit to the length of commands, so there will be an error once the lengths of the JS file names combined exceed that limit. This patch modifies js2c.py so that it now takes a --directory argument to glob for .js and .mjs files in addition to the list of files passed directly. We still pass the additional files we include from deps/ directly through the command line, as we only includes some of them so we cannot simply glob, but those are limited so listing them out should be fine. Refs: https://docs.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation PR-URL: #39069 Refs: #38971 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

github-actions bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 8, 2021

joyeecheung requested a review from jasnell June 8, 2021 16:40

jasnell approved these changes Jun 8, 2021

View reviewed changes

bl-ue mentioned this pull request Jun 12, 2021

Add 100 typo variants codespell-project/codespell#1947

Closed

joyeecheung force-pushed the load-perf-hooks branch from c59009e to 5e1272e Compare June 17, 2021 22:32

joyeecheung mentioned this pull request Jun 17, 2021

build: pass directory instead of list of files to js2c.py #39069

Closed

richardlau mentioned this pull request Jun 24, 2021

stream: implement WHATWG streams #39062

Closed

25 tasks

joyeecheung added 3 commits June 25, 2021 16:46

bootstrap: support perf hooks in snapshot

faa9bad

bootstrap: load perf_hooks eagerly during bootstrap

5e2eadb

joyeecheung force-pushed the load-perf-hooks branch from 5e1272e to 5e2eadb Compare June 25, 2021 13:06

joyeecheung added a commit that referenced this pull request Jun 28, 2021

bootstrap: support perf hooks in snapshot

50cfbf9

PR-URL: #38971 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung added a commit that referenced this pull request Jun 28, 2021

bootstrap: load perf_hooks eagerly during bootstrap

58cfca8

PR-URL: #38971 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung closed this Jun 28, 2021

targos pushed a commit that referenced this pull request Jul 11, 2021

bootstrap: support perf hooks in snapshot

6e46eb1

PR-URL: #38971 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request Jul 11, 2021

bootstrap: load perf_hooks eagerly during bootstrap

aafa08d

PR-URL: #38971 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com>

targos mentioned this pull request Jul 13, 2021

v16.5.0 release proposal #39373

Merged

targos added the dont-land-on-v14.x label Sep 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bootstrap: include perf_hooks in the builtin snapshot #38971

bootstrap: include perf_hooks in the builtin snapshot #38971

joyeecheung commented Jun 8, 2021 •

edited

nodejs-github-bot commented Jun 8, 2021

nodejs-github-bot commented Jun 10, 2021

joyeecheung commented Jun 10, 2021 •

edited

nodejs-github-bot commented Jun 16, 2021

joyeecheung commented Jun 17, 2021

joyeecheung commented Jun 17, 2021 •

edited

nodejs-github-bot commented Jun 17, 2021

joyeecheung commented Jun 17, 2021

nodejs-github-bot commented Jun 25, 2021

nodejs-github-bot commented Jun 26, 2021

joyeecheung commented Jun 28, 2021

bootstrap: include perf_hooks in the builtin snapshot #38971

bootstrap: include perf_hooks in the builtin snapshot #38971

Conversation

joyeecheung commented Jun 8, 2021 • edited

perf_hooks: refactor perf_hooks for snapshot building

bootstrap: support perf hooks in snapshot

bootstrap: load perf_hooks eagerly during bootstrap

nodejs-github-bot commented Jun 8, 2021

nodejs-github-bot commented Jun 10, 2021

joyeecheung commented Jun 10, 2021 • edited

nodejs-github-bot commented Jun 16, 2021

joyeecheung commented Jun 17, 2021

joyeecheung commented Jun 17, 2021 • edited

nodejs-github-bot commented Jun 17, 2021

joyeecheung commented Jun 17, 2021

nodejs-github-bot commented Jun 25, 2021

nodejs-github-bot commented Jun 26, 2021

joyeecheung commented Jun 28, 2021

joyeecheung commented Jun 8, 2021 •

edited

joyeecheung commented Jun 10, 2021 •

edited

joyeecheung commented Jun 17, 2021 •

edited