v16.5.0 release proposal

.eslintrc.js

@@ -98,6 +98,14 @@ module.exports = {
           name: 'require',
           message: 'Use import instead',
         },
+        {
+          name: 'Buffer',
+          message: 'Import Buffer instead of using the global'
+        },
+        {
+          name: 'process',
+          message: 'Import process instead of using the global'
+        },
       ] },
     },
   ],

.github/CODEOWNERS

@@ -22,7 +22,6 @@
 /doc/guides/contributing/pull-requests.md @nodejs/tsc
 /doc/guides/collaborator-guide.md @nodejs/tsc
 /doc/guides/offboarding.md @nodejs/tsc
-/doc/guides/onboarding-extras.md @nodejs/tsc
 
 # streams
 
@@ -55,7 +54,7 @@
 # tls/crypto
 
 /lib/internal/crypto/* @nodejs/crypto
-/lib/internal/tls.js @nodejs/crypto @nodejs/net
+/lib/internal/tls/* @nodejs/crypto @nodejs/net
 /lib/crypto.js @nodejs/crypto
 /lib/tls.js @nodejs/crypto @nodejs/net
 /src/node_crypto* @nodejs/crypto
@@ -119,3 +118,8 @@
 # V8
 /deps/v8/* @nodejs/v8-update
 /tools/v8_gypfiles/* @nodejs/v8-update
+
+# Actions
+
+/.github/workflows/* @nodejs/actions
+/tools/actions/* @nodejs/actions

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -0,0 +1,45 @@
+name: "\U0001F41B Bug report"
+description: Create a report to help us improve
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you for reporting an issue.
+
+        This issue tracker is for bugs and issues found within Node.js core.
+        If you require more general support please file an issue on our help repo. https://github.com/nodejs/help
+
+        Please fill in as much of the form below as you're able.
+  - type: input
+    attributes:
+      label: Version
+      description: Output of `node -v`
+  - type: input
+    attributes:
+      label: Platform
+      description: |
+        UNIX: output of `uname -a`
+        Windows: output of `"$([Environment]::OSVersion | ForEach-Object VersionString) $(if ([Environment]::Is64BitOperatingSystem) { "x64" } else { "x86" })"` in PowerShell console
+  - type: input
+    attributes:
+      label: Subsystem
+      description: If known, please specify affected core module name
+  - type: textarea
+    attributes:
+      label: What steps will reproduce the bug?
+      description: Enter details about your bug, preferably a simple code snippet that can be run using `node` directly without installing third-party dependencies.
+  - type: textarea
+    attributes:
+      label: How often does it reproduce? Is there a required condition?
+  - type: textarea
+    attributes:
+      label: What is the expected behavior?
+      description: If possible please provide textual output instead of screenshots.
+  - type: textarea
+    attributes:
+      label: What do you see instead?
+      description: If possible please provide textual output instead of screenshots.
+  - type: textarea
+    attributes:
+      label: Additional information
+      description: Tell us anything else you think we should know.

.github/workflows/build-tarball.yml

@@ -58,8 +58,8 @@ jobs:
           name: tarballs
       - name: Extract tarball
         run: |
-          tar xzf tarballs/*.tar.gz
-          echo "TAR_DIR=`basename tarballs/*.tar.gz .tar.gz`" >> $GITHUB_ENV
+          tar xzf tarballs/*.tar.gz -C $RUNNER_TEMP
+          echo "TAR_DIR=$RUNNER_TEMP/`basename tarballs/*.tar.gz .tar.gz`" >> $GITHUB_ENV
       - name: Copy directories needed for testing
         run: |
           cp -r tools/node_modules $TAR_DIR/tools

.github/workflows/commit-lint-problem-matcher.json

@@ -0,0 +1,13 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "core-validate-commit",
+      "pattern": [
+        {
+          "regexp": "^not ok \\d+ (.*)$",
+          "message": 1
+        }
+      ]
+    }
+  ]
+}

.github/workflows/commit-lint.yml

@@ -0,0 +1,20 @@
+name: "Commit messages adheres to guidelines at https://goo.gl/p2fr5Q"
+
+on: [pull_request]
+
+jobs:
+  lint-commit-message:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          # Last 100 commits should be enough for a PR
+          fetch-depth: 100
+      - name: Use Node.js 12
+        uses: actions/setup-node@v1
+        with:
+          node-version: 12.x
+      - name: Validate commit messages
+        run: |
+          echo "::add-matcher::.github/workflows/commit-lint-problem-matcher.json"
+          git log --oneline ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} | grep -v -e fixup -e squash | awk '{ print $1 }' |  xargs npx -q core-validate-commit --no-validate-metadata --tap

.github/workflows/find-inactive-collaborators.yml

@@ -0,0 +1,17 @@
+name: Find inactive collaborators
+
+on:
+  schedule:
+    # Run on the 15th day of the month at 4:05 AM UTC.
+    - cron: '5 4 15 * *'
+
+  workflow_dispatch:
+
+jobs:
+  find:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - run: tools/find-inactive-collaborators.mjs '1 year ago'

.github/workflows/label-pr.yml

@@ -11,4 +11,5 @@ jobs:
     steps:
       - uses: nodejs/node-pr-labeler@v1
         with:
+          repo-token: ${{ secrets.GH_USER_TOKEN }}
           configuration-path: .github/label-pr-config.yml

.gitignore

@@ -133,7 +133,7 @@ tools/*/*.i.tmp
 /deps/uv/.github/
 /deps/uv/docs/code/
 /deps/uv/docs/src/guide/
-# Ignore dependencies fetched by deps/v8/tools/node/fetch_deps.py
+# Ignore dependencies fetched by tools/v8/fetch_deps.py
 /deps/.cipd
 
 # === Rules for Windows vcbuild.bat ===

.mailmap

@@ -63,6 +63,7 @@ Beth Griggs <bgriggs@redhat.com> Bethany Griggs <Bethany.Griggs@uk.ibm.com>
 Beth Griggs <bgriggs@redhat.com> Bethany N Griggs <Bethany.Griggs@uk.ibm.com>
 Beth Griggs <bgriggs@redhat.com> BethGriggs <Bethany.Griggs@uk.ibm.com>
 Bidisha Pyne <pyne.bidisha2017@gmail.com> <bidipyne@in.ibm.com>
+bl-ue <bl-ue@users.noreply.github.com> bl-ue <54780737+bl-ue@users.noreply.github.com>
 Brad Decker <bhdecker84@gmail.com> brad-decker <bhdecker84@gmail.com>
 Brad Larson <brad@waterfallmedia.net> BradLarson <brad@waterfallmedia.net>
 Bradley Meck <bradley.meck@gmail.com> Bradley Farias <bradley.meck@gmail.com>
@@ -103,8 +104,10 @@ Daniel Paulino <d_paulino@outlook.com> dpaulino <d_paulino@outlook.com>
 Daniel Pihlström <sciolist.se@gmail.com>
 Daniel Wang <wangyang0123@gmail.com> firedfox <wangyang02@baidu.com>
 Daniel Wang <wangyang0123@gmail.com> firedfox <wangyang0123@gmail.com>
+Danielle Adams <adamzdanielle@gmail.com> Danielle Adams <danielle.adams@heroku.com>
 Danny Nemer <hi@dannynemer.com> <DannyNemer@users.noreply.github.com>
 Danny Nemer <hi@dannynemer.com> <hi@DannyNemer.com>
+Darshan Sen <raisinten@gmail.com>
 Dave Pacheco <dap@joyent.com> <dap@cs.brown.edu>
 David Cai <davidcai1993@yahoo.com> DavidCai <davidcai1993@yahoo.com>
 David Mark Clements <david.clements@nearform.com>
@@ -207,6 +210,7 @@ Josh Erickson <josh@snoj.us>
 Josh Hunter <jopann@gmail.com> jopann <jopann@gmail.com>
 Joshua S. Weinstein <josher19@users.sf.net>
 Joyee Cheung <joyeec9h3@gmail.com> joyeecheung <joyeec9h3@gmail.com>
+Joyee Cheung <joyeec9h3@gmail.com> Joyee Cheung <joyee@igalia.com>
 Juan Soto <juan@juansoto.me>
 Julien Klepatch <julien@julienklepatch.com> jklepatch <julien@julienklepatch.com>
 Julien Waechter <julien.waechter@gmail.com> julien.waechter <julien.waechter@gmail.com>
@@ -294,6 +298,7 @@ Nicholas Kinsey <pyrotechnick@feistystudios.com>
 Nick Soggin <nicksoggin@gmail.com> <iSkore@users.noreply.github.com>
 Nikolai Vavilov <vvnicholas@gmail.com>
 Nils Kuhnhenn <lain@volafile.io>
+Nitzan Uziely <linkgoron@gmail.com> Nitzan Uziely <nitzan@testim.io>
 Noah Rose Ledesma <noahroseledesma@seattleacademy.org> Noah Rose <noahroseledesma@seattleacademy.org>
 Noah Rose Ledesma <noahroseledesma@seattleacademy.org> <NoahRoseLedesma@seattleacademy.org>
 Oluwaseun Omoyajowo <omoyajowo2015@gmail.com>
@@ -356,6 +361,7 @@ Segu Riluvan <rilwan22@hotmail.com> <riluvan@gmail.com>
 Sergey Kryzhanovsky <skryzhanovsky@gmail.com> <another@dhcp199-223-red.yandex.net>
 Shannen Saez <shannenlaptop@gmail.com>
 Shaopeng Zhang <szhang351@bloomberg.net> szhang351 <szhang351@bloomberg.net>
+Shelley Vohr <shelley.vohr@gmail.com> Shelley Vohr <codebytere@gmail.com>
 Shigeki Ohtsu <ohtsu@ohtsu.org> <ohtsu@iij.ad.jp>
 Shigeki Ohtsu <ohtsu@ohtsu.org> <ohtsu@d.jp>
 Shivang Saxena <shivangs44@gmail.com>
@@ -371,6 +377,7 @@ Sreepurna Jasti <sreepurna.jasti@gmail.com> sreepurnajasti <sreepurna.jasti@gmai
 Stanislav Opichal <opichals@gmail.com>
 Stefan Budeanu <stefan@budeanu.com> <stefanbu@ca.ibm.com>
 Stefan Bühler <stbuehler@web.de>
+Stephen Belanger <admin@stephenbelanger.com> <stephen.belanger@datadoghq.com>
 Stephen Belanger <admin@stephenbelanger.com> <stephen.belanger@elastic.co>
 Steve Mao <maochenyan@gmail.com> <maochenyan@msn.com>
 Steven R. Loomis <srloomis@us.ibm.com> <srl@icu-project.org>
@@ -426,6 +433,7 @@ Ujjwal Sharma <usharma1998@gmail.com> <ryzokuken@disroot.org>
 Viktor Karpov <viktor.s.karpov@gmail.com> vitkarpov <viktor.s.karpov@gmail.com>
 Vincent Voyer <v@fasterize.com>
 Vladimir de Turckheim <vlad2t@hotmail.com>
+Voltrex <mohammadkeyvanzade94@gmail.com> Voltrex <62040526+VoltrexMaster@users.noreply.github.com>
 vsemozhetbyt <vsemozhetbyt@gmail.com> Vse Mozhet Byt <vsemozhetbyt@gmail.com>
 Wang Xinyong <wang.xy.chn@gmail.com> <wangxy.chn@gmail.com>
 Weijia Wang <381152119@qq.com>