crypto: add rsa-pss keygen parameters

[panva]

This PR deprecates (documentation-only deprecation with --pending-deprecation) undocumented API for RSA-PSS key generation parameters that specify the RSASSA-PSS-params sequence and replaces them with options aligned with asymmetricKeyDetails property names.

The update is so that the option names and their values match the ones exposed via asymmetricKeyDetails from #39851. See #39851 (comment) and #39851 (comment)

It is semver-major because despite it being undocumented before it might be in use in by users.

Edit: We will runtime deprecate the undocumented ones via a followup PR, this is now a semver-minor as it is not breaking potential existing use of the undocumented API.

[panva]

cc @nodejs/crypto

[tniessen]

I think it makes sense to do this in two steps: add the new options in a semver-minor PR and runtime-deprecate the old options in a semver-major PR. It's more work, but if we don't do that, we can't use these options in any Node.js version < 17.

[panva]

I think it makes sense to do this in two steps: add the new options in a semver-minor PR and runtime-deprecate the old options in a semver-major PR. It's more work, but if we don't do that, we can't use these options in any Node.js version < 17.

Sounds good.

Do you recommend to apply the undocumented to be deprecated properties like so?

let { hash, hashAlgorithm } = options
if (hash) deprecationNotice()
hashAlgorithm ??= hash

// proceed with hashAlgorithm

[tniessen]

@panva I am not sure. It generally looks good to me but I have a slight preference for throwing if both are set and not equal.

[panva]

Sounds good, I'll prepare the PR(s) to supersede this one.

[tniessen]

@panva I think you can keep this one for either part and open one more for the other part :) Thank you!

[panva]

@tniessen never did a deprecation before, can you please check?

[tniessen]

Runtime deprecations must be semver-major:

add the new options in a semver-minor PR and runtime-deprecate the old options in a semver-major PR

We can do a documentation-only deprecation as semver-minor (or a documentation-only deprecation with --pending-deprecation), but not a runtime deprecation. Sorry, I should have been more specific before.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39737/ 💚

[tniessen]

I'd love to see a test that ensures that asymmetricKeyDetails → generateKeyPair → asymmetricKeyDetails is deepStrictEqual.

[panva]

I'd love to see a test that ensures that asymmetricKeyDetails → generateKeyPair → asymmetricKeyDetails is deepStrictEqual.

Can't do that because publicExponent in generate is a number but in key details is bigint. But other than publicExponent we already have tests that expect as much wrt. the RSASSA-PSS-params sequence params

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39776/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39781/

[panva]

Landed in c6b0ae8