Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix environment variable settings for ccache #40550

Merged
merged 2 commits into from Oct 24, 2021
Merged

doc: fix environment variable settings for ccache #40550

merged 2 commits into from Oct 24, 2021
+14 −6

Commits on Oct 24, 2021

  1. doc: fix macOS environment variables for ccache 

    macOS requires `cc` and `c++` rather than `gcc` and `g++`.

Closes: nodejs#40542

PR-URL: nodejs#40550
Fixes: nodejs#40542
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Oct 24, 2021
    Copy the full SHA
    edd716b View commit details
    Browse the repository at this point in the history

  2. doc: simplify ccache instructions 

    `ccache` has reasonable defaults for `max_size` and `cache_dir` so
remove instructions to set those things explicitly.

Change fenced code from `console` to `bash` for easier copy/paste.

PR-URL: nodejs#40550
Fixes: nodejs#40542
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Oct 24, 2021
    Copy the full SHA
    31d7d6c View commit details
    Browse the repository at this point in the history