big fix for CI #40684
big fix for CI #40684
Conversation
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
|
I think someone from build should still investigate why that windows host suddenly became slow |
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
It's an Azure host so maybe someone at Microsoft can help? Hate to ping because I know they all have other things going on, but uh... @joaocgreis @bnb @bzoz This would be the |
This comment has been minimized.
This comment has been minimized.
A good example to look at might be https://ci.nodejs.org/job/node-test-binary-windows-native-suites/10883.
|
|
Argh, the test-policy-integrity pummel test is likewise timing out on a win10-COMPILED_BY-vs2019 machine. I'll bump up the pummel timeouts to 6x (from 4x). |
This comment has been minimized.
This comment has been minimized.
|
@Trott did you mean to push before rerunning CI? |
🤦 It's late here.... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Well, now the job is killed by Jenkins because it takes more than 10 minutes: |
I've increased the timeout for node-test-binary-windows-js-suites on Jenkins to 15 minutes (900 seconds up from 600 seconds). @nodejs/build Is there somewhere I should document this? (I'll open an issue in the build repo at least.) |
This comment has been minimized.
This comment has been minimized.
|
@tniessen (or another Collaborator): This could use a second 👍 on the fast track request comment at #40684 (comment). |
|
@Trott 👍 |
Of course, if the problem is that there's a race condition and pummel/test-policy-integrity will never finish, then that won't help.... If that's the case, I'll insert some skip-if-on-Windows code into the test and open an issue for it. I hate to do that, but it is an experimental feature at least. |
|
test-policy-integrity still failed on the Windows 10/VS2019 host after 12 minutes so I'm marking it flaky, which is unfortunate because it seems to fail approximately 100% of the time. But it's an experimental feature and we need to be able to land working code. |
This comment has been minimized.
This comment has been minimized.
|
|
|
I wonder if someone did something to fix the slow-running issue. test-policy-integrity timed out (more than 12 minutes) in https://ci.nodejs.org/job/node-test-pull-request/40619/ but took less than a minute to run on https://ci.nodejs.org/job/node-test-pull-request/40620/. |
(Regardless, let's land this, and we can revert or undo the greater time allowances if the fix is across everything and robust. It's not harming anything.) |
Add standard timezone name for Dublin without daylight saving PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
test-benchmark-buffer is consistently timing out on a single Windows host in CI. Rather than try to figure out if we need to scale the timeout up for a certain memory limit or chip speed or something else, let's increase the timeout for benchmark tests in general. PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on certain tests in pummel and (previously) benchmark. Increase timeout from 4x to 6x. PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
|
Landed in 86099a3...b2aff85 |
Mesteery
added
the
author ready
Add standard timezone name for Dublin without daylight saving PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
test-benchmark-buffer is consistently timing out on a single Windows host in CI. Rather than try to figure out if we need to scale the timeout up for a certain memory limit or chip speed or something else, let's increase the timeout for benchmark tests in general. PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on certain tests in pummel and (previously) benchmark. Increase timeout from 4x to 6x. PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Add standard timezone name for Dublin without daylight saving PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
test-benchmark-buffer is consistently timing out on a single Windows host in CI. Rather than try to figure out if we need to scale the timeout up for a certain memory limit or chip speed or something else, let's increase the timeout for benchmark tests in general. PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on certain tests in pummel and (previously) benchmark. Increase timeout from 4x to 6x. PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
This incorporates #40670 to fix the datetime test issue that is blocking CI along with a fix/workaround for test-benchmark-buffer which is blocking that PR from landing. Putting them together in one PR to get them both landed and hopefully get CI unstuck.