Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify moderation in onboarding #41930

Merged
merged 4 commits into from Oct 28, 2022
Merged

Conversation

benjamingr
Copy link
Member

This change gives more attention to moderation requirements collaborators can perform as part of the onboarding process.

cc @nodejs/moderation @nodejs/tsc

This change gives more attention to moderation requirements collaborators can perform as part of the onboarding process.

cc @nodejs/moderation @nodejs/tsc
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 11, 2022
onboarding.md Outdated Show resolved Hide resolved
@@ -108,8 +108,15 @@ The project has a venue for real-time discussion:
* This is a repository to which all members of the `nodejs` GitHub
organization (not just collaborators on Node.js core) have access. Its
contents should not be shared externally.
* Node.js has a moderation team which you should contact when unsure
Copy link
Member

@Trott Trott Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good place to mention the existence of the @nodejs/moderation team.

Co-authored-by: Rich Trott <rtrott@gmail.com>
about taking action in the Node.js org.
* You can moderate non-collaborator posts yourself. When done please
report the moderation action taken in accordance to the moderation
policy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good place to insert a link to the moderation policy. Additionally (and purely optionally), this is also a good place to mention that collaborators can volunteer for the moderation team and how to do that. (We may also want to try using language like "volunteer" rather than "self-nominate". I think people are more likely to volunteer for something than to nominate themselves for something. Plus volunteer correctly implies that it's a service position whereas nominate might suggest recognition, etc.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make sense to invert the order of things here maybe? Start with a title indicating this section is about moderation in general (rather than heated debates) and add things like volunteering under it here.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without my comments addressed.

onboarding.md Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
onboarding.md Outdated Show resolved Hide resolved
Co-authored-by: Darshan Sen <darshan.sen@postman.com>
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with/without the suggested additional additions made by reviewers

@aduh95
Copy link
Contributor

aduh95 commented Feb 18, 2022

@benjamingr is this ready to land?

@benjamingr
Copy link
Member Author

@benjamingr is this ready to land?

Sure this can land it's already an improvement but I also want to do a followup based on the suggestions

@aduh95 aduh95 merged commit 0a3d0e0 into main Oct 28, 2022
@aduh95 aduh95 deleted the moderation-team-onboarding-update branch October 28, 2022 12:31
@aduh95
Copy link
Contributor

aduh95 commented Oct 28, 2022

Landed in 0a3d0e0

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
This change gives more attention to moderation requirements
collaborators can perform as part of the onboarding process.

PR-URL: #41930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
This change gives more attention to moderation requirements
collaborators can perform as part of the onboarding process.

PR-URL: #41930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
This change gives more attention to moderation requirements
collaborators can perform as part of the onboarding process.

PR-URL: #41930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
This change gives more attention to moderation requirements
collaborators can perform as part of the onboarding process.

PR-URL: #41930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
This change gives more attention to moderation requirements
collaborators can perform as part of the onboarding process.

PR-URL: #41930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants