Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v17.6.0 release proposal #42072

Merged
merged 106 commits into from Feb 22, 2022
Merged

v17.6.0 release proposal #42072

merged 106 commits into from Feb 22, 2022

Conversation

bengl
Copy link
Member

@bengl bengl commented Feb 21, 2022

2022-02-22, Version 17.6.0 (Current), @BethGriggs prepared by @bengl

Notable Changes

  • [6b88595142] - doc: deprecate notice for process methods (Yash Ladha) #41587
  • [77462b6083] - stream: revert map spec compliance (Benjamin Gruenbaum) #41931
  • [b968d89fc9] - build: remove broken x32 arch support (Ben Noordhuis) #41905
  • [ba639d052b] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
  • [214d17650b] - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
  • [ec0d623bd7] - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
  • [3243701997] - (SEMVER-MINOR) readline: bind keystroke ctrl+6 to redo (Ray) #41662
  • [5796c3a7ea] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
    • Documentation-only.

Dependency Updates

New Collaborators

Commits

  • [a93462a719] - build: cancel running CI jobs when a PR is updated (Michaël Zasso) #42017
  • [0cc1a27636] - build: increase operations and test tag (Michael Dawson) #42038
  • [f49fe215c4] - build: allow manual run of feature request action (Michael Dawson) #42037
  • [b57b3056ff] - build: add action to close stale feature requests (Michael Dawson) #41981
  • [fc649fa289] - build: prevent concurrent CI and CQ workflow runs (Michaël Zasso) #42016
  • [e2d1eb8e49] - build: use zoslib_include_dir provided by node-gyp (alexcfyung) #41713
  • [2b329dab2c] - build: move tool updates workflow runtime a day later (Rich Trott) #41982
  • [b2fc45078e] - build: extend yamllint configuration (Mestery) #41756
  • [b968d89fc9] - build: remove broken x32 arch support (Ben Noordhuis) #41905
  • [2b1dabfb16] - build: revert fast-track changes (Filip Skokan) #41892
  • [182e6b9ee9] - build: improve consistency between workflows (Mestery) #41791
  • [8af4d31e0f] - build,tools: change the quotes in YAML (Mestery) #41756
  • [1c404bdb8f] - child_process: kHideConsoleWindows for spawnSync (Raymond Zhao) #41412
  • [c41e402c06] - cluster: respect listen backlog set by workers (Elad Nava) #41623
  • [f47a0699a2] - crypto: check result of BIO_new in X509ToObject (Tobias Nießen) #41979
  • [ce99600782] - crypto: rename X509_NAME_FLAGS (Tobias Nießen) #42001
  • [88cbceb3ca] - (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) #41938
  • [0fff4d2314] - crypto: do not advertise unsupported algorithms (Brian White) #41864
  • [e4f0d95ec0] - debugger: add debugger alias for exec(expr) (Xuguang Mei) #41907
  • [b5fd25b1f6] - debugger: remove duplicate setPauseOnException call (Balakrishna Avulapati) #41838
  • [811f04bd34] - deps: upgrade npm to 8.5.1 (npm-robot) #42039
  • [605271ba8c] - deps: update undici to 3e267ece5f (Michaël Zasso) #41955
  • [0a6f0b416f] - deps: upgrade npm to 8.5.0 (npm-robot) #41925
  • [0ae2b0e6b0] - doc: fix typo in http2 endAfterHeaders description (Alexandru Comanescu) #42060
  • [9ab2e217e3] - doc: make minor fixes to contributing guides (T-O-R-U-S) #41966
  • [7c55d64bb5] - doc: use openpgp.org for keyserver examples (Nick Schonning) #39227
  • [e2ae5d4d8b] - doc: adjust a/an word usage (Derek Wolpert) #41915
  • [28cd39edf9] - doc: remove extra <td> (Ray) #42006
  • [df359a0665] - doc: capitalize valgrind (T•Ø•R•Ü•S) #41986
  • [87a7b4248f] - doc: fix deprecation number (Antoine du Hamel) #41990
  • [7c19c7496e] - doc: add marsonya to collaborators (Akhil Marsonya) #41991
  • [326f54576a] - doc: deprecate notice for process methods (Yash Ladha) #41587
  • [4c0ad1c630] - doc: fix bug in readable.unshift code example (Xuguang Mei) #41944
  • [02548adac8] - doc: add missing buffer in the stream/consumers import example (Mestery) #41961
  • [1b7359d03c] - doc: fix typo in readableStream.locked description (Tobias Nießen) #41923
  • [529686e540] - doc: fix wrong indent in stream documentation (Xuguang Mei) #41943
  • [5ec1a20895] - doc: emphasize security warning in vm module doc (Rich Trott) #41916
  • [4883904ccb] - doc: clarify tls.Server 'connection' event documentation (Austin Cheney) #41917
  • [63cc999b9c] - doc: improve scrollbar appearance in dark mode (Aaron Xie) #41890
  • [aa684a78fe] - doc: replace text with paths in toggle SVGs (Brian White) #41885
  • [fc9d4e96c1] - doc: edit process.config deprecation text (Rich Trott) #41889
  • [0de611f53a] - doc: add joesepi to collaborators (Joe Sepi) #41914
  • [ba5cb89134] - doc: remove unneeded ellipsis in header (Rich Trott) #41888
  • [291fe631dd] - doc: fix webstream close reject state state doc (Benjamin Gruenbaum) #41860
  • [72cb44b386] - esm: improve fetch_module test coverage and remove hack (Antoine du Hamel) #41947
  • [010dd4c1bd] - esm: remove erroneous context.parentURL property passed to load hook (Jacob Smith) #41975
  • [eb2f821030] - esm: fix typo in fetch_module (Michael Scovetta) #41924
  • [ba639d052b] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
  • [f6c6d7d0a8] - events: set default handler value (Benjamin Gruenbaum) #41970
  • [10ca3bb922] - fs: fix default length parameter for fs.read (wbt) #40349
  • [1e862b3816] - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
  • [5fa4455880] - fs: fix cb/sync writev empty array behavior (Benjamin Gruenbaum) #41932
  • [7b01a371e1] - fs: fix writev empty array error behavior (Benjamin Gruenbaum) #41919
  • [7fca10ffab] - fs: refactor to use ES2020 syntax (小菜) #41903
  • [4fbe064ce0] - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
  • [53e2e8c835] - lib: stop installing webcrypto if no_browser_globals is true (Mestery) #41971
  • [ec5b594231] - lib: allow respondWithNewView on byob auto allocated streams (Sean Quinlan) #41887
  • [8c912ab154] - lib: stop installing fetch if no_browser_globals is true (Darshan Sen) #41969
  • [7fc68f9a42] - lib: restrict usage of fetch related globals in core internals (Antoine du Hamel) #41957
  • [5ede4588ec] - lib: move kEnumerableProperty to internal/util (Mestery) #41877
  • [fa3a9135ad] - lib: add internal genericNodeError() function (Rich Trott) #41879
  • [3a03e2720e] - meta: update AUTHORS (Node.js GitHub Bot) #42058
  • [224745c78b] - meta: use plain emojis instead of escape sequences (Mestery) #41989
  • [25f52c3496] - meta: update AUTHORS and .mailmap (Rich Trott) #41953
  • [fb750d6402] - perf_hooks: use arrays to store EntryBuffers (Xuguang Mei) #42032
  • [5796c3a7ea] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  • [3243701997] - (SEMVER-MINOR) readline: bind keystroke ctrl+6 to redo (Ray) #41662
  • [c766159e68] - repl: REPL gives wrong autocomplete on literals #41690 REPL gives wrong autocomplete on literals (Xuguang Mei) #41883
  • [f5f790be1e] - src: merge ToJsSet into ToV8Value (Anna Henningsen) #41757
  • [eeb3a68a50] - src: remove separate definitions for static constexpr members (Anna Henningsen) #41755
  • [7395de0078] - src: use const reference instead of pointer in URL::SerializeURL (Anna Henningsen) #41759
  • [470f870dd0] - src: reserve string allocation space early in URL::SerializeURL (Anna Henningsen) #41759
  • [554cd2c27b] - src: fix query/fragment serialization in URL::SerializeURL (Anna Henningsen) #41759
  • [6076291168] - src: don't print interface if sin6_scope_id is 0 (Santiago Gimeno) #41547
  • [047d4de08b] - src,buffer: evaluate THROW_AND_RETURN_IF_OOB() expression only once (Darshan Sen) #41945
  • [50a0a22835] - stream: add more forEach tests (Benjamin Gruenbaum) #41937
  • [6c9a36c7fb] - stream: add more filter tests (Benjamin Gruenbaum) #41936
  • [abd6967153] - stream: revert map spec compliance (Benjamin Gruenbaum) #41931
  • [e57267b67d] - stream: avoid usage of deprecated APIs (Mohammed Keyvanzadeh) #41871
  • [308d31d173] - stream: refactor to use more validators (Mohammed Keyvanzadeh) #41871
  • [7f69973208] - stream: use standard for loop instead of for..of (Mohammed Keyvanzadeh) #41871
  • [e412b23800] - test: remove test-stdout-close-catch flaky designation (Rich Trott) #42045
  • [ce23738279] - test: check that fetch globals are disabled by default (Michaël Zasso) #42015
  • [0461729120] - test: improve vm test coverage (Yoshiki Kurihara) #41847
  • [c59dd984a3] - test: run webmessaging/broadcastchannel WPT (Ben Noordhuis) #41962
  • [dfed49879a] - test: fix names of tests marked flaky on IBM i (Richard Lau) #41984
  • [f1009ae9f9] - test: fix typographical error (Rich Trott) #41983
  • [8cf918125c] - test: fix intl tests on small-icu builds (Antoine du Hamel) #41939
  • [f4304ea941] - test: improve code coverage for streams/duplexify (Erick Wendel) #41862
  • [dc14bd85ee] - test: remove lint rule for setTimeout() arguments (Rich Trott) #41901
  • [76f0f1c06d] - test: move test-crypto-engine to addon (Michael Dawson) #41830
  • [c498a72cff] - tls: avoid throw in onerror for bad TLSSocket obj (Valters Jansons) #41523
  • [48fa1e5671] - tools: enable es2022 env in ESLint config (Michaël Zasso) #42043
  • [0f4f2ddfc2] - tools: add console to the list of restricted globals (Antoine du Hamel) #42012
  • [dcb51b0a48] - tools: lint deprecation codes (Antoine du Hamel) #41992
  • [98167e884b] - tools: fix bugs in prefer-primordials linter rule (Antoine du Hamel) #42010
  • [01618c621e] - tools: add timers functions to the list of restricted globals (Antoine du Hamel) #42013
  • [297d217efc] - tools: reduce list of globals in ESLint config (Rich Trott) #41996
  • [916cda4afc] - tools: update remark-preset-lint-node to 3.3.1 (Rich Trott) #41999
  • [7a72aa776a] - tools: update ESLint to 8.9.0 (Luigi Pinca) #41973
  • [0c4977cf29] - tools: update lint-md-dependencies to rollup@2.67.2 (Node.js GitHub Bot) #41941
  • [f30b5e3a6d] - tools: fix typo in prefer-primordials.js (Ikko Ashimine) #41891
  • [a87fa5b1c7] - tools,lib: remove global and Intl from the list of globals (Antoine du Hamel) #42014
  • [a4420d379e] - worker: fix typo in debug statement (Antoine du Hamel) #42011

npm-robot and others added 20 commits February 11, 2022 23:27
PR-URL: #41925
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
1. Any keystroke emits `0x1E` will do redo action.
2. Fix bug of undo/redo.
3. More detailed document.
4. Unit tests.

PR-URL: #41662
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #41791
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fixes: #41633
Fixes: #40958

- move test-crypto-engine so that dummy engine
  is only built if tests are run

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41830
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Fixes: #41857

PR-URL: #41864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Deprecate the process multipleResolves event to detect when a promise is
resolved more than once because it never really worked.

Fixes: #41554

PR-URL: #41872
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #41892
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
The `closed` promise may reject. Document the states where it rejects
based on the spec.

Fixes: #41858

PR-URL: #41860
Co-Authored-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
replacable -> replaceable

PR-URL: #41891
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
The ellipsis in `All together` is not needed. I've had it on my list of
"small things to take care of when you get a chance" for a while. The
Microsoft Style Guide says to not use ellipses except in certain cases,
and that reminded me to do it. The day has arrived!

PR-URL: #41888
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
There are a few places in lib where `new Error()` is called and then
additional properties are attached in various ways. This creates a
utility function to generate the errors.

PR-URL: #41879
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Fixes: #41671

PR-URL: #41914
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Fixes: #41690

PR-URL: #41883
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: James Sumners <james@sumners.email>
PR-URL: #36328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: #41889
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fixes: #41878

PR-URL: #41885
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #41623
Co-authored-by: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
With the introduction of the promises API for setTimeout(), the
requirement that it have two parameters may not be sensible anymore in
tests.

PR-URL: #41901
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
I added support for x32 back in 2014 but it's been in a state of
disrepair ever since, not in the least because it was never a fully
supported architecture in upstream V8.

V8 dropped x32 support entirely in or around 2018 so the removal from
Node's build system is long overdue.

Refs: #40576

PR-URL: #41905
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
An interface with index 0 doesn't make sense and makes
`if_indextoname()` to return `ENXIO` which crashes the process.

Fixes: #41500

PR-URL: #41547
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v17.x labels Feb 21, 2022
bengl added a commit that referenced this pull request Feb 21, 2022
Notable changes:

* [bdbe655] - doc: add marsonya to collaborators (Akhil Marsonya) #41991
* [8fe8dee] - doc: deprecate notice for process methods (Yash Ladha) #41587
* [abd6967] - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
* [b968d89] - build: remove broken x32 arch support (Ben Noordhuis) #41905
* [ba639d0] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
* [0de611f] - doc: add joesepi to collaborators (Joe Sepi) #41914
* [5796c3a] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872

PR-URL: #42072
@@ -39,6 +40,129 @@
* [io.js](CHANGELOG_IOJS.md)
* [Archive](CHANGELOG_ARCHIVE.md)

<a id="17.6.0"></a>

## 2022-02-22, Version 17.6.0 (Current), @bengl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we've done a @releaser prepared by @potential-new-releaser format, e.g.:
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2020-10-07-version-14131-current-bethgriggs-prepared-by-danielleadams

Suggested change
## 2022-02-22, Version 17.6.0 (Current), @bengl
## 2022-02-22, Version 17.6.0 (Current), @BethGriggs prepared by @bengl

@targos
Copy link
Member

targos commented Feb 21, 2022

The commit message should not contain the releaser's handle.

bengl added a commit that referenced this pull request Feb 21, 2022
* 326f545 - doc: deprecate notice for process methods (Yash Ladha) #41587
* abd6967 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
* b968d89 - build: remove broken x32 arch support (Ben Noordhuis) [#41905](#41905)
* 88cbceb - (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](#41938)
* ba639d0 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) [#36328](#36328)
* 1e862b3 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](#41819)
* 4fbe064 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) [#41956](#41956)
* 3243701 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) [#41662](#41662)
* 5796c3a - process: deprecate multipleResolves (Benjamin Gruenbaum) [#41872](#41872)
  * Documentation-only.

* \[[`811f04bd34`](811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](#42039)
* \[[`605271ba8c`](605271ba8c)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](#41955)
* \[[`0a6f0b416f`](0a6f0b416f)] - **deps**: upgrade npm to 8.5.0 (npm-robot) [#41925](#41925)

* \[[`7c19c7496e`](7c19c7496e)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](#41991)
* \[[`0de611f53a`](0de611f53a)] - **doc**: add joesepi to collaborators (Joe Sepi) [#41914](#41914)

PR-URL: #42072
targos and others added 3 commits February 22, 2022 11:38
This adds more globals to the set known by ESLint.

PR-URL: #42043
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Also order entries by startTime when calling getEntriesByType.

Fix: #42004
Fix: #42024

PR-URL: #42032
Fixes: #42004
Fixes: #42024
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #42057
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau
Copy link
Member

Looks like these two tests are consistently crashing the debug builds 😞 : test.parallel/test-domain-error-types test.parallel/test-worker-heap-snapshot

From the #nodejs-release Slack thread it looks like these tests were introduced by #41818. Complicating things is that after nodejs/build#2837 (comment) we're no longer running x64 debug builds on master -- instead we're running debug builds on arm64. There was some allusion to flakiness in #41818 (review) which links through to #41204 which mentions that the crash went away in a V8 update which is not likely to land on v17.x. We probably want to hold off landing #41818 on v17.x-staging for now.

bengl added a commit that referenced this pull request Feb 22, 2022
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
@bengl
Copy link
Member Author

bengl commented Feb 22, 2022

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 22, 2022

@BethGriggs
Copy link
Member

BethGriggs commented Feb 22, 2022

* \[[`297d217efc`](https://github.com/nodejs/node/commit/297d217efc)] - **tools**: reduce list of globals in ESLint config (Rich Trott) [#41996](https://github.com/nodejs/node/pull/41996)
* \[[`916cda4afc`](https://github.com/nodejs/node/commit/916cda4afc)] - **tools**: update remark-preset-lint-node to 3.3.1 (Rich Trott) [#41999](https://github.com/nodejs/node/pull/41999)
* \[[`7a72aa776a`](https://github.com/nodejs/node/commit/7a72aa776a)] - **tools**: update ESLint to 8.9.0 (Luigi Pinca) [#41973](https://github.com/nodejs/node/pull/41973)
* \[[`0c4977cf29`](https://github.com/nodejs/node/commit/0c4977cf29)] - **tools**: update lint-md-dependencies to rollup\@2.67.2 (Node.js GitHub Bot) [#41941](https://github.com/nodejs/node/pull/41941)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked all of them, but it looks like there's a mismatch to the commit shas on the actual branch, most probably due to one of the rebases.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest push.

bengl added a commit that referenced this pull request Feb 22, 2022
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072

### Notable Changes

* \[[`326f54576a`](https://github.com/nodejs/node/commit/326f54576a)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* \[[`326f54576a`](https://github.com/nodejs/node/commit/326f54576a)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)
* \[[`6b88595142`](https://github.com/nodejs/node/commit/6b88595142)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)

### Notable Changes

* \[[`326f54576a`](https://github.com/nodejs/node/commit/326f54576a)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)
* \[[`abd6967153`](https://github.com/nodejs/node/commit/abd6967153)] - **stream**: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* \[[`abd6967153`](https://github.com/nodejs/node/commit/abd6967153)] - **stream**: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931)
* \[[`77462b6083`](https://github.com/nodejs/node/commit/77462b6083)] - **stream**: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931)

* \[[`326f54576a`](https://github.com/nodejs/node/commit/326f54576a)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)
* \[[`abd6967153`](https://github.com/nodejs/node/commit/abd6967153)] - **stream**: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931)
* \[[`b968d89fc9`](https://github.com/nodejs/node/commit/b968d89fc9)] - **build**: remove broken x32 arch support (Ben Noordhuis) [#41905](https://github.com/nodejs/node/pull/41905)
* \[[`88cbceb3ca`](https://github.com/nodejs/node/commit/88cbceb3ca)] - **(SEMVER-MINOR)** **crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* \[[`88cbceb3ca`](https://github.com/nodejs/node/commit/88cbceb3ca)] - **(SEMVER-MINOR)** **crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)
* \[[`60682917dd`](https://github.com/nodejs/node/commit/60682917dd)] - **(SEMVER-MINOR)** **crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)

* \[[`b968d89fc9`](https://github.com/nodejs/node/commit/b968d89fc9)] - **build**: remove broken x32 arch support (Ben Noordhuis) [#41905](https://github.com/nodejs/node/pull/41905)
* \[[`88cbceb3ca`](https://github.com/nodejs/node/commit/88cbceb3ca)] - **(SEMVER-MINOR)** **crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)
* \[[`ba639d052b`](https://github.com/nodejs/node/commit/ba639d052b)] - **(SEMVER-MINOR)** **esm**: support https remotely and http locally under flag (Bradley Farias) [#36328](https://github.com/nodejs/node/pull/36328)
* \[[`1e862b3816`](https://github.com/nodejs/node/commit/1e862b3816)] - **(SEMVER-MINOR)** **fs**: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* \[[`1e862b3816`](https://github.com/nodejs/node/commit/1e862b3816)] - **(SEMVER-MINOR)** **fs**: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819)
* \[[`214d17650b`](https://github.com/nodejs/node/commit/214d17650b)] - **(SEMVER-MINOR)** **fs**: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819)

* \[[`88cbceb3ca`](https://github.com/nodejs/node/commit/88cbceb3ca)] - **(SEMVER-MINOR)** **crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)
* \[[`ba639d052b`](https://github.com/nodejs/node/commit/ba639d052b)] - **(SEMVER-MINOR)** **esm**: support https remotely and http locally under flag (Bradley Farias) [#36328](https://github.com/nodejs/node/pull/36328)
* \[[`1e862b3816`](https://github.com/nodejs/node/commit/1e862b3816)] - **(SEMVER-MINOR)** **fs**: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819)
* \[[`4fbe064ce0`](https://github.com/nodejs/node/commit/4fbe064ce0)] - **(SEMVER-MINOR)** **lib**: add FormData global when fetch is enabled (Michaël Zasso) [#41956](https://github.com/nodejs/node/pull/41956)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* \[[`4fbe064ce0`](https://github.com/nodejs/node/commit/4fbe064ce0)] - **(SEMVER-MINOR)** **lib**: add FormData global when fetch is enabled (Michaël Zasso) [#41956](https://github.com/nodejs/node/pull/41956)
* \[[`ec0d623bd7`](https://github.com/nodejs/node/commit/ec0d623bd7)] - **(SEMVER-MINOR)** **lib**: add FormData global when fetch is enabled (Michaël Zasso) [#41956](https://github.com/nodejs/node/pull/41956)


### Dependency Updates

* \[[`811f04bd34`](https://github.com/nodejs/node/commit/811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* \[[`811f04bd34`](https://github.com/nodejs/node/commit/811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039)
* \[[`d1ef43f2aa`](https://github.com/nodejs/node/commit/d1ef43f2aa)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039)

### Dependency Updates

* \[[`811f04bd34`](https://github.com/nodejs/node/commit/811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039)
* \[[`605271ba8c`](https://github.com/nodejs/node/commit/605271ba8c)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](https://github.com/nodejs/node/pull/41955)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* \[[`605271ba8c`](https://github.com/nodejs/node/commit/605271ba8c)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](https://github.com/nodejs/node/pull/41955)
* \[[`09c17481f6`](https://github.com/nodejs/node/commit/09c17481f6)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](https://github.com/nodejs/node/pull/41955)


### New Collaborators

* \[[`7c19c7496e`](https://github.com/nodejs/node/commit/7c19c7496e)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](https://github.com/nodejs/node/pull/41991)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* \[[`7c19c7496e`](https://github.com/nodejs/node/commit/7c19c7496e)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](https://github.com/nodejs/node/pull/41991)
* \[[`90d90e3868`](https://github.com/nodejs/node/commit/90d90e3868)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](https://github.com/nodejs/node/pull/41991)

Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
@bengl
Copy link
Member Author

bengl commented Feb 22, 2022

@richardlau I'm pretty sure I've fixed all of those now, but my work should certainly be checked 😄 .

@BethGriggs BethGriggs merged commit 972dd0a into v17.x Feb 22, 2022
BethGriggs added a commit that referenced this pull request Feb 22, 2022
BethGriggs pushed a commit that referenced this pull request Feb 22, 2022
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
@aduh95 aduh95 deleted the v17.6.0-proposal branch February 22, 2022 23:56
bengl added a commit to bengl/nodejs.org that referenced this pull request Feb 23, 2022
BethGriggs pushed a commit to nodejs/nodejs.org that referenced this pull request Feb 23, 2022
Trott pushed a commit that referenced this pull request Feb 23, 2022
Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet