v17.6.0 release proposal

.eslintrc.js

@@ -35,6 +35,9 @@ Module._findPath = (request, paths, isMain) => {
 
 module.exports = {
   root: true,
+  env: {
+    es2022: true,
+  },
   extends: ['eslint:recommended', 'plugin:jsdoc/recommended'],
   plugins: ['jsdoc', 'markdown', 'node-core'],
   parser: '@babel/eslint-parser',
@@ -314,29 +317,11 @@ module.exports = {
     'node-core/no-duplicate-requires': 'error',
   },
   globals: {
-    AbortController: 'readable',
-    AbortSignal: 'readable',
-    Atomics: 'readable',
-    BigInt: 'readable',
-    BigInt64Array: 'readable',
-    BigUint64Array: 'readable',
-    DOMException: 'readable',
-    Event: 'readable',
-    EventTarget: 'readable',
-    MessageChannel: 'readable',
-    MessageEvent: 'readable',
-    MessagePort: 'readable',
-    TextEncoder: 'readable',
-    TextDecoder: 'readable',
-    queueMicrotask: 'readable',
-    globalThis: 'readable',
-    btoa: 'readable',
-    atob: 'readable',
-    performance: 'readable',
-    structuredClone: 'readable',
+    Crypto: 'readable',
+    CryptoKey: 'readable',
     fetch: 'readable',
-    Headers: 'readable',
-    Request: 'readable',
+    FormData: 'readable',
     Response: 'readable',
+    SubtleCrypto: 'readable',
   },
 };

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -1,4 +1,4 @@
-name: "\U0001F41B Bug report"
+name: 🐛 Bug report
 description: Create a report to help us improve
 body:
   - type: markdown

.github/ISSUE_TEMPLATE/2-feature-request.yml

@@ -1,6 +1,6 @@
-name: "\U0001F680 Feature request"
+name: 🚀 Feature request
 description: Suggest an idea for this project
-labels: ["feature request"]
+labels: [feature request]
 body:
   - type: markdown
     attributes:

.github/ISSUE_TEMPLATE/3-api-ref-docs-problem.yml

@@ -1,6 +1,6 @@
-name: "\U0001F4D7 Open an issue regarding the Node.js API reference docs"
+name: 📗 Open an issue regarding the Node.js API reference docs
 description: Let us know about any problematic API reference documents
-labels: ["doc"]
+labels: [doc]
 body:
   - type: markdown
     attributes:

.github/ISSUE_TEMPLATE/4-report-a-flaky-test.yml

@@ -1,6 +1,6 @@
 name: Report a flaky test
 description: Report a flaky test in our CI
-labels: ["flaky-test"]
+labels: [flaky-test]
 body:
   - type: markdown
     attributes:

.github/workflows/authors.yml

@@ -1,8 +1,8 @@
-name: "authors update"
+name: Authors update
 on:
   schedule:
     # Run once a week at 00:05 AM UTC on Sunday.
-    - cron: '5 0 * * 0'
+    - cron: 5 0 * * 0
 
   workflow_dispatch:
 
@@ -15,7 +15,7 @@ jobs:
         with:
           fetch-depth: '0'  # This is required to actually get all the authors
           persist-credentials: false
-      - run: "tools/update-authors.js"  # Run the AUTHORS tool
+      - run: tools/update-authors.js  # Run the AUTHORS tool
       - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
@@ -25,7 +25,7 @@ jobs:
             Here are some new additions to the AUTHORS file.
             This is an automatically generated PR by the
             `authors.yml` GitHub Action, which runs `tools/update-authors.js`.
-          branch: "actions/authors-update"  # Custom branch *just* for this Action.
-          commit-message: "meta: update AUTHORS"
+          branch: actions/authors-update  # Custom branch *just* for this Action.
+          commit-message: 'meta: update AUTHORS'
           labels: meta
-          title: "meta: update AUTHORS"
+          title: 'meta: update AUTHORS'

.github/workflows/auto-start-ci.yml

@@ -6,13 +6,15 @@ on:
     # optimistic, it can take longer to run.
     # To understand why `schedule` is used instead of other events, refer to
     # ./doc/contributing/commit-queue.md
-    - cron: "*/5 * * * *"
+    - cron: '*/5 * * * *'
+
+concurrency: ${{ github.workflow }}
 
 env:
   NODE_VERSION: lts/*
 
 jobs:
-  get_prs_for_ci:
+  get-prs-for-ci:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     outputs:
@@ -29,20 +31,20 @@ jobs:
                   --limit 100
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  startCI:
-    needs: get_prs_for_ci
-    if: needs.get_prs_for_ci.outputs.numbers != ''
+  start-ci:
+    needs: get-prs-for-ci
+    if: needs.get-prs-for-ci.outputs.numbers != ''
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
         with:
           persist-credentials: false
 
-      # Install dependencies
       - name: Install Node.js
         uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
+
       - name: Install node-core-utils
         run: npm install -g node-core-utils
 
@@ -55,6 +57,6 @@ jobs:
           ncu-config set repo "$(echo ${{ github.repository }} | cut -d/ -f2)"
 
       - name: Start the CI
-        run: ./tools/actions/start-ci.sh ${{ needs.get_prs_for_ci.outputs.numbers }}
+        run: ./tools/actions/start-ci.sh ${{ needs.get-prs-for-ci.outputs.numbers }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/build-tarball.yml

@@ -4,10 +4,10 @@ on:
   pull_request:
     types: [opened, synchronize, reopened, ready_for_review]
     paths-ignore:
-      - '.mailmap'
+      - .mailmap
       - '**.md'
-      - 'AUTHORS'
-      - 'doc/**'
+      - AUTHORS
+      - doc/**
       - .github/**
       - '!.github/workflows/build-tarball.yml'
   push:
@@ -17,21 +17,24 @@ on:
       - v[0-9]+.x-staging
       - v[0-9]+.x
     paths-ignore:
-      - '.mailmap'
+      - .mailmap
       - '**.md'
-      - 'AUTHORS'
-      - 'doc/**'
+      - AUTHORS
+      - doc/**
       - .github/**
       - '!.github/workflows/build-tarball.yml'
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
 env:
+  PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 
 jobs:
   build-tarball:
     if: github.event.pull_request.draft == false
-    env:
-      PYTHON_VERSION: '3.10'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -57,8 +60,6 @@ jobs:
           name: tarballs
           path: tarballs
   test-tarball-linux:
-    env:
-      PYTHON_VERSION: '3.10'
     needs: build-tarball
     runs-on: ubuntu-latest
     steps:

.github/workflows/build-windows.yml

@@ -1,9 +1,9 @@
-name: build-windows
+name: Build Windows
 
 on:
   pull_request:
     paths-ignore:
-      - "README.md"
+      - README.md
       - .github/**
       - '!.github/workflows/build-windows.yml'
     types: [opened, synchronize, reopened, ready_for_review]
@@ -15,10 +15,14 @@ on:
       - v[0-9]+.x-staging
       - v[0-9]+.x
     paths-ignore:
-      - "README.md"
+      - README.md
       - .github/**
       - '!.github/workflows/build-windows.yml'
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
 env:
   PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare

.github/workflows/close-stale-feature-requests.yml

@@ -0,0 +1,48 @@
+name: Close stale feature requests
+on:
+  workflow_dispatch:
+  schedule:
+    # Run every day at 1:00 AM UTC.
+    - cron: 0 1 * * *
+
+# yamllint disable rule:empty-lines
+env:
+  CLOSE_MESSAGE: >
+    There has been no activity on this feature request
+    and it is being closed. If you feel closing this issue is not the
+    right thing to do, please leave a comment.
+
+
+    For more information on how the project manages
+    feature requests, please consult the
+    [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md).
+
+  WARN_MESSAGE: >
+    There has been no activity on this feature request for
+    5 months and it is unlikely to be implemented.
+    It will be closed 6 months after the last non-automated comment.
+
+
+    For more information on how the project manages
+    feature requests, please consult the
+    [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md).
+# yamllint enable
+
+jobs:
+  stale:
+    if: github.repository == 'nodejs/node'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v4
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          days-before-stale: 150
+          days-before-close: 30
+          stale-issue-label: stalled
+          close-issue-message: ${{ env.CLOSE_MESSAGE }}
+          stale-issue-message: ${{ env.WARN_MESSAGE }}
+          only-labels: feature request,test-action
+          exempt-pr-labels: never-stale
+          # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits
+          operations-per-run: 30
+          remove-stale-when-updated: true

.github/workflows/close-stalled.yml

@@ -1,7 +1,7 @@
 name: Close stalled issues and PRs
 on:
   schedule:
-    - cron: "0 0 * * *"
+    - cron: 0 0 * * *
 
 env:
   CLOSE_MESSAGE: >

.github/workflows/comment-labeled.yml

@@ -1,4 +1,4 @@
-name: Comment on issues and PRs when labelled
+name: Comment on issues and PRs when labeled
 on:
   issues:
     types: [labeled]
@@ -12,7 +12,7 @@ env:
   FAST_TRACK_MESSAGE: Fast-track has been requested by @${{ github.actor }}. Please 👍 to approve.
 
 jobs:
-  staleComment:
+  stale-comment:
     if: github.repository == 'nodejs/node' && github.event.label.name == 'stalled'
     runs-on: ubuntu-latest
     steps:
@@ -22,7 +22,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: gh issue comment "$NUMBER" --repo ${{ github.repository }} --body "$STALE_MESSAGE"
 
-  fastTrack:
+  fast-track:
     if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'fast-track'
     runs-on: ubuntu-latest
     steps:

.github/workflows/commit-lint.yml

@@ -1,4 +1,4 @@
-name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q"
+name: First commit message adheres to guidelines at https://goo.gl/p2fr5Q
 
 on: [pull_request]
 

.github/workflows/commit-queue.yml

@@ -11,7 +11,9 @@ on:
   # be read-only, and the Action won't have access to any other repository
   # secrets, which it needs to access Jenkins API.
   schedule:
-    - cron: "*/5 * * * *"
+    - cron: '*/5 * * * *'
+
+concurrency: ${{ github.workflow }}
 
 env:
   NODE_VERSION: lts/*

.github/workflows/coverage-linux.yml

@@ -1,27 +1,29 @@
-name: coverage-linux
+name: Coverage Linux
 
 on:
   pull_request:
     types: [opened, synchronize, reopened, ready_for_review]
     paths-ignore:
       - '**.md'
-      - 'benchmark/**'
-      - 'deps/**'
-      - 'doc/**'
+      - benchmark/**
+      - deps/*
+      - doc/**
       - .github/**
       - '!.github/workflows/coverage-linux.yml'
   push:
-    branches:
-      - master
-      - main
+    branches: [master, main]
     paths-ignore:
       - '**.md'
-      - 'benchmark/**'
-      - 'deps/**'
-      - 'doc/**'
+      - benchmark/**
+      - deps/**
+      - doc/**
       - .github/**
       - '!.github/workflows/coverage-linux.yml'
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
 env:
   PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare