Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,inspector: fix empty MaybeLocal crash #42409

Merged
merged 8 commits into from Apr 9, 2022
Merged

src,inspector: fix empty MaybeLocal crash #42409

merged 8 commits into from Apr 9, 2022

Commits on Mar 20, 2022

  1. src,inspector: fix empty MaybeLocal crash 

    Return early when the Inspector StringView to V8 String conversion fails
and returns an empty MaybeLocal instead of running the invalid
ToLocalChecked() assertion.

Fixes: nodejs#42407
Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Mar 20, 2022
    Copy the full SHA
    135f144 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2022

  1. test: set a timeout value 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Mar 27, 2022
    Copy the full SHA
    a363b6e View commit details
    Browse the repository at this point in the history

  2. Revert "test: set a timeout value" 

    This reverts commit a363b6e.
    @RaisinTen
    RaisinTen committed Mar 27, 2022
    Copy the full SHA
    364c9ce View commit details
    Browse the repository at this point in the history

  3. test: mark the test as SLOW in test/root.status 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Mar 27, 2022
    Copy the full SHA
    0c4ab4e View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2022

  1. test: set a timeout value 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Apr 3, 2022
    Copy the full SHA
    b461e2d View commit details
    Browse the repository at this point in the history

  2. Revert "test: set a timeout value" 

    This reverts commit b461e2d.
    @RaisinTen
    RaisinTen committed Apr 3, 2022
    Copy the full SHA
    def11b0 View commit details
    Browse the repository at this point in the history

  3. test: move test to pummel 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Apr 3, 2022
    Copy the full SHA
    9c4fb7b View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. test: skip on armv7 bots 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Apr 8, 2022
    Copy the full SHA
    358c4bf View commit details
    Browse the repository at this point in the history