Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add WPT tests for dom/events #43151

Merged
merged 3 commits into from Jun 22, 2022
Merged

test: add WPT tests for dom/events #43151

merged 3 commits into from Jun 22, 2022

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented May 19, 2022 •
edited

Following the comment #40678 (comment), I added WPT tests for dom/events. The files except test/wpt/status/dom/events.json, test/wpt/test-events.js were generated by git-node wpt dom/events.

Currently, some tests are failed. Is it OK? or should I make some work for passing them? Many of them seem to fail due to lack of browser specific API like document is not undefined.

Refs: #40678

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 19, 2022
@nissy-dev nissy-dev marked this pull request as ready for review May 19, 2022 14:23
shisama
shisama approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@shisama shisama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding WPT test. I left some comments. But they are small things so it is ok not to fix them :)

test/wpt/status/dom/events.json Show resolved Hide resolved
test/wpt/status/dom/events.json Outdated Show resolved Hide resolved
test/wpt/status/dom/events.json Outdated Show resolved Hide resolved
@nissy-dev
Copy link
Contributor Author

@shisama Thank you for reviews! Other member react your suggestion, so I will incorporate your correction.

nissy-dev and others added 2 commits May 20, 2022 21:43
@nissy-dev @shisama
test: remove "unexpected" key in test/wpt/status/dom/events.json
7a7a589 
Co-authored-by: Masashi Hirano <shisama07@gmail.com>
@nissy-dev @shisama
test: remove "unexpected" key in test/wpt/status/dom/events.json
363f835 
Co-authored-by: Masashi Hirano <shisama07@gmail.com>
@nissy-dev
Copy link
Contributor Author

nissy-dev commented May 23, 2022 •
edited

@bnoordhuis
This PR is based on your comment. If you have a time, would you review it?

bnoordhuis
bnoordhuis approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shisama shisama added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2022
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44160/

This was referenced May 26, 2022
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44333/

@github-actions github-actions bot mentioned this pull request Jun 4, 2022
Open
21 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44372/

@shisama shisama added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44443/

@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44639/

@github-actions github-actions bot mentioned this pull request Jun 18, 2022
Open
34 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44671/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44709/

@github-actions github-actions bot mentioned this pull request Jun 19, 2022
Open
30 tasks
@F3n67u
Copy link
Member

F3n67u commented Jun 19, 2022 •
edited

We could remove the following test, given they are already implemented in js in the latest wpt repo:

  1. test/parallel/test-eventtarget-whatwg-passive.js
  2. test/parallel/test-eventtarget-whatwg-signal.js
  3. test/parallel/test-eventtarget-whatwg-once.js

We could do the cleanup either in a separate pr or in this pr. I will be fine with both approaches.

@github-actions github-actions bot mentioned this pull request Jun 20, 2022
Open
36 tasks
@nissy-dev
Copy link
Contributor Author

@F3n67u
Thank you for your comment! I will do the cleanup either in a separate pr because of flaky test in CI.

@F3n67u F3n67u mentioned this pull request Jun 21, 2022
Merged
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 22, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 22, 2022
@nodejs-github-bot nodejs-github-bot merged commit 8dce6ad into nodejs:main Jun 22, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 8dce6ad

@nissy-dev nissy-dev deleted the wpt-dom-events branch June 23, 2022 12:48
F3n67u pushed a commit to F3n67u/node that referenced this pull request Jun 24, 2022
@nissy-dev @F3n67u
test: add WPT tests for dom/events
95fa67f 
PR-URL: nodejs#43151
Refs: nodejs#40678
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@nissy-dev @targos
test: add WPT tests for dom/events
eece34c 
PR-URL: #43151
Refs: #40678
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
@F3n67u F3n67u mentioned this pull request Jul 17, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@nissy-dev @targos
test: add WPT tests for dom/events
7a5823f 
PR-URL: #43151
Refs: #40678
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@nissy-dev @targos
test: add WPT tests for dom/events
bf5adf3 
PR-URL: #43151
Refs: #40678
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@nissy-dev @guangwong
test: add WPT tests for dom/events
15ed34c 
PR-URL: nodejs/node#43151
Refs: nodejs/node#40678
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@shisama shisama shisama approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nissy-dev @nodejs-github-bot @F3n67u @bnoordhuis @jasnell @shisama @aduh95