Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: add null check for the signal of EventTarget #43153

Merged
merged 7 commits into from Oct 13, 2022
Merged

events: add null check for the signal of EventTarget #43153

merged 7 commits into from Oct 13, 2022

Commits on Oct 11, 2022

  1. events: add null check for the signal of EventTarget 

    This will improve the Web compatibility.
Passing null as the signal should throw an error.
WPT says "Passing null as the signal should throw".
Please see https://github.com/web-platform-tests/wpt/blob/master/dom/events/AddEventListenerOptions-signal.any.js
    @shisama
    shisama committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    21cb08f View commit details
    Browse the repository at this point in the history

  2. fix lint errors

    @shisama
    shisama committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    5c5f40a View commit details
    Browse the repository at this point in the history

  3. fix trailing comma 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @shisama @aduh95
    shisama and aduh95 committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    4d76ce3 View commit details
    Browse the repository at this point in the history

  4. fix error message in test 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @shisama @aduh95
    shisama and aduh95 committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    a10f689 View commit details
    Browse the repository at this point in the history

  5. fix touse validateAbortSignal to check signal

    @shisama
    shisama committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    8607445 View commit details
    Browse the repository at this point in the history

  6. Update test/parallel/test-eventtarget-whatwg-signal.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @shisama @aduh95
    shisama and aduh95 committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    2fae6f2 View commit details
    Browse the repository at this point in the history

  7. Update WPT events test

    @shisama
    shisama committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    8c29e22 View commit details
    Browse the repository at this point in the history