events: add null check for the signal of EventTarget #43153

shisama · 2022-05-19T17:16:29Z

To improve Web compatibility, passing null as the signal should throw an error.
WPT says "Passing null as the signal should throw".
Please see https://github.com/web-platform-tests/wpt/blob/master/dom/events/AddEventListenerOptions-signal.any.js

Node doesn't check it.
This may occur the breaking change so don't hesitate to tell me if this should not be fixed.

tniessen · 2022-05-19T21:59:40Z

There are linter errors:

/home/runner/work/node/node/test/parallel/test-eventtarget-whatwg-signal.js
Error:   163:3   error  `assert.throws()` must be invoked with at least two arguments  no-restricted-syntax
Error:   163:53  error  A space is required after '{'                                  object-curly-spacing
Error:   163:66  error  A space is required before '}'                                 object-curly-spacing

test/parallel/test-eventtarget-whatwg-signal.js

lib/internal/event_target.js

test/parallel/test-eventtarget-whatwg-signal.js

tniessen · 2022-05-21T16:16:53Z

Is semver-patch okay?

nodejs-github-bot · 2022-05-21T16:24:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44102/

aduh95 · 2022-05-21T16:32:07Z

Is semver-patch okay?

Technically no, the API is no longer experimental.

cjihrig · 2022-05-21T17:53:19Z

I think semver patch should be ok in this case because it's a bug in Node's spec compliance.

aduh95 · 2022-05-22T10:54:15Z

I think semver patch should be ok in this case because it's a bug in Node's spec compliance.

Note that most code written to follow the spec (and would work on browsers) would also work on the current Node.js implementation. Some code that work on the Node.js implementation would throw if run on a browser. I'm not sure it's worth adding a breaking change as a semver-patch on an API that migrated out of experimental a long time ago. To me, it seems that this change in particular is necessary, but not urgent.

The TSC could decide that all APIs that follow an external spec can land breaking changes as semver-minor, or decide to make a one-off exception.

nodejs-github-bot · 2022-10-11T20:22:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47192/

nodejs-github-bot · 2022-10-12T11:37:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47216/

shisama · 2022-10-12T13:10:12Z

It seems that the CI fails due to a flaky test. It is a test for the 'cluster' module on the same platform as well as this flaky test. If this can be ignored, can we merge this?

The following is the error message on https://github.com/nodejs/node/actions/runs/3227239115/jobs/5299062130.

BethGriggs · 2022-10-13T01:14:04Z

Test ASan finally passed without hitting the flake 🎉

nodejs-github-bot · 2022-10-13T02:46:17Z

Commit Queue failed

- Loading data for nodejs/node/pull/43153 ✔ Done loading data for nodejs/node/pull/43153 ----------------------------------- PR info ------------------------------------ Title events: add null check for the signal of EventTarget (#43153) Author Masashi Hirano (@shisama) Branch shisama:event-target-signal-null-check -> nodejs:main Labels semver-major, author ready, needs-ci Commits 7 - events: add null check for the signal of EventTarget - fix lint errors - fix trailing comma - fix error message in test - fix touse validateAbortSignal to check signal - Update test/parallel/test-eventtarget-whatwg-signal.js - Update WPT events test Committers 1 - shisama PR-URL: https://github.com/nodejs/node/pull/43153 Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43153 Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 19 May 2022 17:16:29 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43153#pullrequestreview-980623872 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43153#pullrequestreview-1139943156 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43153#pullrequestreview-980842176 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/43153#pullrequestreview-980865711 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/43153#pullrequestreview-1127626174 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-12T11:37:58Z: https://ci.nodejs.org/job/node-test-pull-request/47216/ - Querying data for job/node-test-pull-request/47216/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 43153 From https://github.com/nodejs/node * branch refs/pull/43153/merge -> FETCH_HEAD ✔ Fetched commits as 214354fc9f3e..8c29e224c00b -------------------------------------------------------------------------------- [main a771ac78a3] events: add null check for the signal of EventTarget Author: shisama Date: Fri May 20 02:09:59 2022 +0900 2 files changed, 9 insertions(+) [main 0663a7f4cb] fix lint errors Author: shisama Date: Fri May 20 23:42:26 2022 +0900 1 file changed, 3 insertions(+), 1 deletion(-) [main fb066c2e6f] fix trailing comma Author: Masashi Hirano Date: Fri May 20 23:43:39 2022 +0900 1 file changed, 1 insertion(+), 1 deletion(-) [main d311c55c88] fix error message in test Author: Masashi Hirano Date: Fri May 20 23:54:49 2022 +0900 1 file changed, 1 insertion(+), 1 deletion(-) [main e0cab4432e] fix touse validateAbortSignal to check signal Author: shisama Date: Sat May 21 22:58:19 2022 +0900 2 files changed, 6 insertions(+), 6 deletions(-) [main 119397cf28] Update test/parallel/test-eventtarget-whatwg-signal.js Author: Masashi Hirano Date: Sun May 22 00:42:35 2022 +0900 1 file changed, 1 insertion(+), 1 deletion(-) [main 72e2949db0] Update WPT events test Author: shisama Date: Sun Oct 2 15:34:56 2022 +0900 1 file changed, 1 deletion(-) ✔ Patches applied There are 7 commits in the PR. Attempting autorebase. Rebasing (2/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
events: add null check for the signal of EventTarget

This will improve the Web compatibility.
Passing null as the signal should throw an error.
WPT says "Passing null as the signal should throw".
Please see https://github.com/web-platform-tests/wpt/blob/master/dom/events/AddEventListenerOptions-signal.any.js

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 7505bf4bf7] events: add null check for the signal of EventTarget
Author: shisama shisama07@gmail.com
Date: Fri May 20 02:09:59 2022 +0900
2 files changed, 9 insertions(+)
Rebasing (3/14)
Rebasing (4/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix lint errors

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 7d3e2b2b6c] fix lint errors
Author: shisama shisama07@gmail.com
Date: Fri May 20 23:42:26 2022 +0900
1 file changed, 3 insertions(+), 1 deletion(-)
Rebasing (5/14)
Rebasing (6/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix trailing comma

Co-authored-by: Antoine du Hamel duhamelantoine1995@gmail.com
PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD eff0aed290] fix trailing comma
Author: Masashi Hirano shisama07@gmail.com
Date: Fri May 20 23:43:39 2022 +0900
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (7/14)
Rebasing (8/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix error message in test

Co-authored-by: Antoine du Hamel duhamelantoine1995@gmail.com
PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD fce4a353d5] fix error message in test
Author: Masashi Hirano shisama07@gmail.com
Date: Fri May 20 23:54:49 2022 +0900
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (9/14)
Rebasing (10/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix touse validateAbortSignal to check signal

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD afd44b1c4d] fix touse validateAbortSignal to check signal
Author: shisama shisama07@gmail.com
Date: Sat May 21 22:58:19 2022 +0900
2 files changed, 6 insertions(+), 6 deletions(-)
Rebasing (11/14)
Rebasing (12/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update test/parallel/test-eventtarget-whatwg-signal.js

Co-authored-by: Antoine du Hamel duhamelantoine1995@gmail.com
PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 82c3a0ef5b] Update test/parallel/test-eventtarget-whatwg-signal.js
Author: Masashi Hirano shisama07@gmail.com
Date: Sun May 22 00:42:35 2022 +0900
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (13/14)
Rebasing (14/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update WPT events test

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 99c5fad794] Update WPT events test
Author: shisama shisama07@gmail.com
Date: Sun Oct 2 15:34:56 2022 +0900
1 file changed, 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/3239314373

nodejs-github-bot · 2022-10-13T09:58:42Z

Landed in 03fb789

Notable Changes: doc: * graduate webcrypto to stable (Filip Skokan) #44897 esm: * remove specifier resolution flag (Geoffrey Booth) #44859 http: * (SEMVER-MAJOR) use Keep-Alive by default in global agents (Paolo Insogna) #43522 build: * (SEMVER-MAJOR) remove dtrace & etw support (Ben Noordhuis) #43652 * (SEMVER-MAJOR) remove systemtap support (Ben Noordhuis) #43651 Deprecation and Removals: * deprecate url.parse() (Rich Trott) #44919 * (SEMVER-MAJOR) runtime deprecate exports double slash maps (Guy Bedford) #44495 * (SEMVER-MAJOR) runtime deprecate coercion to integer in `process.exit()` (Daeyeon Jeong) #44711 Semver-Major Commits: * [53f73d1] - (SEMVER-MAJOR) build: enable V8's trap handler on Windows (Michaël Zasso) #44741 * [06aaf8a] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #44741 * [aa3a572] - (SEMVER-MAJOR) build: remove dtrace & etw support (Ben Noordhuis) #43652 * [38f1e27] - (SEMVER-MAJOR) build: remove systemtap support (Ben Noordhuis) #43651 * [2849283] - (SEMVER-MAJOR) crypto: remove non-standard `webcrypto.Crypto.prototype.CryptoKey` (Antoine du Hamel) #42083 * [a1653ac] - (SEMVER-MAJOR) crypto: do not allow to call setFips from the worker thread (Sergey Petushkov) #43624 * [fd36a8d] - (SEMVER-MAJOR) deps: update llhttp to 8.1.0 (Paolo Insogna) #44967 * [89ecddd] - (SEMVER-MAJOR) deps: bump minimum ICU version to 71 (Michaël Zasso) #44741 * [66fe446] - (SEMVER-MAJOR) deps: V8: cherry-pick 0cccb6f27d78 (Michaël Zasso) #44741 * [88ed027] - (SEMVER-MAJOR) deps: V8: cherry-pick 7ddb8399f9f1 (Michaël Zasso) #44741 * [26c651c] - (SEMVER-MAJOR) deps: V8: cherry-pick 1b3a4f0c34a1 (Michaël Zasso) #44741 * [c8ff2df] - (SEMVER-MAJOR) deps: V8: cherry-pick b161a0823165 (Michaël Zasso) #44741 * [7a8fa2d] - (SEMVER-MAJOR) deps: fix V8 build on Windows with MSVC (Michaël Zasso) #44741 * [83b0aaa] - (SEMVER-MAJOR) deps: fix V8 build on SmartOS (Michaël Zasso) #44741 * [7a952e8] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #44741 * [6bd756d] - (SEMVER-MAJOR) deps: update V8 to 10.7.193.13 (Michaël Zasso) #44741 * [03fb789] - (SEMVER-MAJOR) events: add null check for the signal of EventTarget (Masashi Hirano) #43153 * [a4fa526] - (SEMVER-MAJOR) fs: add directory autodetection to fsPromises.symlink() (Livia Medeiros) #42894 * [bb4891d] - (SEMVER-MAJOR) fs: add validateBuffer to improve error (Hirotaka Tagawa / wafuwafu13) #44769 * [950a441] - (SEMVER-MAJOR) fs: remove coercion to string in writing methods (Livia Medeiros) #42796 * [41a6d82] - (SEMVER-MAJOR) fs: harden fs.readSync(buffer, options) typecheck (LiviaMedeiros) #42772 * [2275faa] - (SEMVER-MAJOR) fs: harden fs.read(params, callback) typecheck (LiviaMedeiros) #42772 * [29953a0] - (SEMVER-MAJOR) fs: harden filehandle.read(params) typecheck (LiviaMedeiros) #42772 * [4267b92] - (SEMVER-MAJOR) http: use Keep-Alive by default in global agents (Paolo Insogna) #43522 * [0324529] - (SEMVER-MAJOR) inspector: introduce inspector/promises API (Erick Wendel) #44250 * [8027099] - (SEMVER-MAJOR) lib: enable global CustomEvent by default (Daeyeon Jeong) #44860 * [f529f73] - (SEMVER-MAJOR) lib: brand check event handler property receivers (Chengzhong Wu) #44483 * [6de2673] - (SEMVER-MAJOR) lib: enable global WebCrypto by default (Antoine du Hamel) #42083 * [73ba883] - (SEMVER-MAJOR) lib: use private field in AbortController (Joyee Cheung) #43820 * [7dd2f41] - (SEMVER-MAJOR) module: runtime deprecate exports double slash maps (Guy Bedford) #44495 * [22c39b1] - (SEMVER-MAJOR) path: the dot will be added(path.format) if it is not specified in `ext` (theanarkh) #44349 * [587367d] - (SEMVER-MAJOR) perf_hooks: expose webperf global scope interfaces (Chengzhong Wu) #44483 * [364c0e1] - (SEMVER-MAJOR) perf_hooks: fix webperf idlharness (Chengzhong Wu) #44483 * [ada2d05] - (SEMVER-MAJOR) process: runtime deprecate coercion to integer in `process.exit()` (Daeyeon Jeong) #44711 * [e0ab8dd] - (SEMVER-MAJOR) process: make process.config read only (Sergey Petushkov) #43627 * [481a959] - (SEMVER-MAJOR) readline: remove `question` method from `InterfaceConstructor` (Antoine du Hamel) #44606 * [c9602ce] - (SEMVER-MAJOR) src: use new v8::OOMErrorCallback API (Michaël Zasso) #44741 * [19a70c1] - (SEMVER-MAJOR) src: override CreateJob instead of PostJob (Clemens Backes) #44741 * [fd52c62] - (SEMVER-MAJOR) src: use V8_ENABLE_SANDBOX macro (Michaël Zasso) #44741 * [c10988d] - (SEMVER-MAJOR) src: use non-deprecated V8 inspector API (Michaël Zasso) #44741 * [3efe901] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 111 (Michaël Zasso) #44741 * [77e5856] - (SEMVER-MAJOR) src: turn embedder api overload into default argument (Alena Khineika) #43629 * [dabda03] - (SEMVER-MAJOR) src: per-environment time origin value (Chengzhong Wu) #43781 * [2e49b99] - (SEMVER-MAJOR) src,test: disable freezing V8 flags on initialization (Clemens Backes) #44741 * [2b32985] - (SEMVER-MAJOR) stream: use null for the error argument (Luigi Pinca) #44312 * [36805e8] - (SEMVER-MAJOR) test: adapt test-repl for V8 update (Michaël Zasso) #44741 * [96ef257] - (SEMVER-MAJOR) test: adapt test-repl-pretty-*stack to V8 changes (Michaël Zasso) #44741 * [71c193e] - (SEMVER-MAJOR) test: adapt to new JSON SyntaxError messages (Michaël Zasso) #44741 * [b5f1564] - (SEMVER-MAJOR) test: rename always-opt flag to always-turbofan (Michaël Zasso) #44741 * [1acf033] - (SEMVER-MAJOR) test: fix test-hash-seed for new V8 versions (Michaël Zasso) #44741 * [57ff476] - (SEMVER-MAJOR) test: remove duplicate test (Luigi Pinca) #44051 * [77def91] - (SEMVER-MAJOR) tls,http2: send fatal alert on ALPN mismatch (Tobias Nießen) #44031 * [4860ad9] - (SEMVER-MAJOR) tools: update V8 gypfiles for 10.7 (Michaël Zasso) #44741 PR-URL: #44626 Co-authored-by: Ruy Adorno <ruyadorno@google.com>

Notable Changes: doc: * graduate webcrypto to stable (Filip Skokan) #44897 esm: * remove specifier resolution flag (Geoffrey Booth) #44859 http: * (SEMVER-MAJOR) use Keep-Alive by default in global agents (Paolo Insogna) #43522 build: * (SEMVER-MAJOR) remove dtrace & etw support (Ben Noordhuis) #43652 * (SEMVER-MAJOR) remove systemtap support (Ben Noordhuis) #43651 deps: * (SEMVER-MAJOR) deps: update V8 to 10.7.193.13 (Michaël Zasso) #44741 Deprecation and Removals: * deprecate url.parse() (Rich Trott) #44919 * (SEMVER-MAJOR) runtime deprecate exports double slash maps (Guy Bedford) #44495 * (SEMVER-MAJOR) runtime deprecate coercion to integer in `process.exit()` (Daeyeon Jeong) #44711 Semver-Major Commits: * [53f73d1] - (SEMVER-MAJOR) build: enable V8's trap handler on Windows (Michaël Zasso) #44741 * [06aaf8a] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #44741 * [aa3a572] - (SEMVER-MAJOR) build: remove dtrace & etw support (Ben Noordhuis) #43652 * [38f1e27] - (SEMVER-MAJOR) build: remove systemtap support (Ben Noordhuis) #43651 * [2849283] - (SEMVER-MAJOR) crypto: remove non-standard `webcrypto.Crypto.prototype.CryptoKey` (Antoine du Hamel) #42083 * [a1653ac] - (SEMVER-MAJOR) crypto: do not allow to call setFips from the worker thread (Sergey Petushkov) #43624 * [fd36a8d] - (SEMVER-MAJOR) deps: update llhttp to 8.1.0 (Paolo Insogna) #44967 * [89ecddd] - (SEMVER-MAJOR) deps: bump minimum ICU version to 71 (Michaël Zasso) #44741 * [66fe446] - (SEMVER-MAJOR) deps: V8: cherry-pick 0cccb6f27d78 (Michaël Zasso) #44741 * [88ed027] - (SEMVER-MAJOR) deps: V8: cherry-pick 7ddb8399f9f1 (Michaël Zasso) #44741 * [26c651c] - (SEMVER-MAJOR) deps: V8: cherry-pick 1b3a4f0c34a1 (Michaël Zasso) #44741 * [c8ff2df] - (SEMVER-MAJOR) deps: V8: cherry-pick b161a0823165 (Michaël Zasso) #44741 * [7a8fa2d] - (SEMVER-MAJOR) deps: fix V8 build on Windows with MSVC (Michaël Zasso) #44741 * [83b0aaa] - (SEMVER-MAJOR) deps: fix V8 build on SmartOS (Michaël Zasso) #44741 * [7a952e8] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #44741 * [6bd756d] - (SEMVER-MAJOR) deps: update V8 to 10.7.193.13 (Michaël Zasso) #44741 * [03fb789] - (SEMVER-MAJOR) events: add null check for the signal of EventTarget (Masashi Hirano) #43153 * [a4fa526] - (SEMVER-MAJOR) fs: add directory autodetection to fsPromises.symlink() (Livia Medeiros) #42894 * [bb4891d] - (SEMVER-MAJOR) fs: add validateBuffer to improve error (Hirotaka Tagawa / wafuwafu13) #44769 * [950a441] - (SEMVER-MAJOR) fs: remove coercion to string in writing methods (Livia Medeiros) #42796 * [41a6d82] - (SEMVER-MAJOR) fs: harden fs.readSync(buffer, options) typecheck (LiviaMedeiros) #42772 * [2275faa] - (SEMVER-MAJOR) fs: harden fs.read(params, callback) typecheck (LiviaMedeiros) #42772 * [29953a0] - (SEMVER-MAJOR) fs: harden filehandle.read(params) typecheck (LiviaMedeiros) #42772 * [4267b92] - (SEMVER-MAJOR) http: use Keep-Alive by default in global agents (Paolo Insogna) #43522 * [0324529] - (SEMVER-MAJOR) inspector: introduce inspector/promises API (Erick Wendel) #44250 * [8027099] - (SEMVER-MAJOR) lib: enable global CustomEvent by default (Daeyeon Jeong) #44860 * [f529f73] - (SEMVER-MAJOR) lib: brand check event handler property receivers (Chengzhong Wu) #44483 * [6de2673] - (SEMVER-MAJOR) lib: enable global WebCrypto by default (Antoine du Hamel) #42083 * [73ba883] - (SEMVER-MAJOR) lib: use private field in AbortController (Joyee Cheung) #43820 * [7dd2f41] - (SEMVER-MAJOR) module: runtime deprecate exports double slash maps (Guy Bedford) #44495 * [22c39b1] - (SEMVER-MAJOR) path: the dot will be added(path.format) if it is not specified in `ext` (theanarkh) #44349 * [587367d] - (SEMVER-MAJOR) perf_hooks: expose webperf global scope interfaces (Chengzhong Wu) #44483 * [364c0e1] - (SEMVER-MAJOR) perf_hooks: fix webperf idlharness (Chengzhong Wu) #44483 * [ada2d05] - (SEMVER-MAJOR) process: runtime deprecate coercion to integer in `process.exit()` (Daeyeon Jeong) #44711 * [e0ab8dd] - (SEMVER-MAJOR) process: make process.config read only (Sergey Petushkov) #43627 * [481a959] - (SEMVER-MAJOR) readline: remove `question` method from `InterfaceConstructor` (Antoine du Hamel) #44606 * [c9602ce] - (SEMVER-MAJOR) src: use new v8::OOMErrorCallback API (Michaël Zasso) #44741 * [19a70c1] - (SEMVER-MAJOR) src: override CreateJob instead of PostJob (Clemens Backes) #44741 * [fd52c62] - (SEMVER-MAJOR) src: use V8_ENABLE_SANDBOX macro (Michaël Zasso) #44741 * [c10988d] - (SEMVER-MAJOR) src: use non-deprecated V8 inspector API (Michaël Zasso) #44741 * [3efe901] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 111 (Michaël Zasso) #44741 * [77e5856] - (SEMVER-MAJOR) src: turn embedder api overload into default argument (Alena Khineika) #43629 * [dabda03] - (SEMVER-MAJOR) src: per-environment time origin value (Chengzhong Wu) #43781 * [2e49b99] - (SEMVER-MAJOR) src,test: disable freezing V8 flags on initialization (Clemens Backes) #44741 * [2b32985] - (SEMVER-MAJOR) stream: use null for the error argument (Luigi Pinca) #44312 * [36805e8] - (SEMVER-MAJOR) test: adapt test-repl for V8 update (Michaël Zasso) #44741 * [96ef257] - (SEMVER-MAJOR) test: adapt test-repl-pretty-*stack to V8 changes (Michaël Zasso) #44741 * [71c193e] - (SEMVER-MAJOR) test: adapt to new JSON SyntaxError messages (Michaël Zasso) #44741 * [b5f1564] - (SEMVER-MAJOR) test: rename always-opt flag to always-turbofan (Michaël Zasso) #44741 * [1acf033] - (SEMVER-MAJOR) test: fix test-hash-seed for new V8 versions (Michaël Zasso) #44741 * [57ff476] - (SEMVER-MAJOR) test: remove duplicate test (Luigi Pinca) #44051 * [77def91] - (SEMVER-MAJOR) tls,http2: send fatal alert on ALPN mismatch (Tobias Nießen) #44031 * [4860ad9] - (SEMVER-MAJOR) tools: update V8 gypfiles for 10.7 (Michaël Zasso) #44741 PR-URL: #44626 Co-authored-by: Ruy Adorno <ruyadorno@google.com>

nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 19, 2022

shisama mentioned this pull request May 19, 2022

test: add WPT tests for dom/events #43151

Merged

shisama force-pushed the event-target-signal-null-check branch from cfc0a71 to 33427a4 Compare May 19, 2022 17:37

shisama changed the title ~~fix: EventTarget.addEventListener throws an error passin null as the signal~~ events: add null check for the signal of EventTarget.addEventListener May 19, 2022

shisama force-pushed the event-target-signal-null-check branch from 33427a4 to 68d5c2e Compare May 19, 2022 17:56

shisama changed the title ~~events: add null check for the signal of EventTarget.addEventListener~~ events: add null check for the signal of EventTarget May 19, 2022

shisama force-pushed the event-target-signal-null-check branch from 68d5c2e to 1eaaae1 Compare May 19, 2022 18:10

aduh95 reviewed May 20, 2022

View reviewed changes

test/parallel/test-eventtarget-whatwg-signal.js Outdated Show resolved Hide resolved

aduh95 reviewed May 20, 2022

View reviewed changes

test/parallel/test-eventtarget-whatwg-signal.js Outdated Show resolved Hide resolved

lpinca approved these changes May 20, 2022

View reviewed changes

aduh95 reviewed May 20, 2022

View reviewed changes

lib/internal/event_target.js Outdated Show resolved Hide resolved

aduh95 reviewed May 21, 2022

View reviewed changes

test/parallel/test-eventtarget-whatwg-signal.js Outdated Show resolved Hide resolved

aduh95 approved these changes May 21, 2022

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 21, 2022

tniessen approved these changes May 21, 2022

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2022

aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 21, 2022

cjihrig approved these changes May 21, 2022

View reviewed changes

github-actions bot mentioned this pull request May 22, 2022

CI Reliability 2022-05-22 nodejs/reliability#285

Open

25 tasks

This was referenced May 23, 2022

CI Reliability 2022-05-23 nodejs/reliability#286

Open

CI Reliability 2022-05-24 nodejs/reliability#287

Open

CI Reliability 2022-05-25 nodejs/reliability#288

Open

CI Reliability 2022-05-26 nodejs/reliability#289

Open

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2022

github-actions bot mentioned this pull request Oct 12, 2022

CI Reliability 2022-10-12 nodejs/reliability#402

Open

19 tasks

shisama added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2022

This comment was marked as outdated.

Sign in to view

aduh95 approved these changes Oct 13, 2022

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 13, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2022

nodejs-github-bot merged commit 03fb789 into nodejs:main Oct 13, 2022

deokjinkim mentioned this pull request Jan 30, 2023

events: check signal before listener #46054

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

events: add null check for the signal of EventTarget #43153

events: add null check for the signal of EventTarget #43153

shisama commented May 19, 2022 •

edited

tniessen commented May 19, 2022

tniessen commented May 21, 2022

nodejs-github-bot commented May 21, 2022

aduh95 commented May 21, 2022

cjihrig commented May 21, 2022

aduh95 commented May 22, 2022 •

edited

nodejs-github-bot commented Oct 11, 2022

This comment was marked as outdated.

nodejs-github-bot commented Oct 12, 2022

shisama commented Oct 12, 2022 •

edited

BethGriggs commented Oct 13, 2022

nodejs-github-bot commented Oct 13, 2022

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Oct 13, 2022

events: add null check for the signal of EventTarget #43153

events: add null check for the signal of EventTarget #43153

Conversation

shisama commented May 19, 2022 • edited

tniessen commented May 19, 2022

tniessen commented May 21, 2022

nodejs-github-bot commented May 21, 2022

aduh95 commented May 21, 2022

cjihrig commented May 21, 2022

aduh95 commented May 22, 2022 • edited

nodejs-github-bot commented Oct 11, 2022

This comment was marked as outdated.

nodejs-github-bot commented Oct 12, 2022

shisama commented Oct 12, 2022 • edited

BethGriggs commented Oct 13, 2022

nodejs-github-bot commented Oct 13, 2022

PR-URL: #43153 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com Reviewed-By: Tobias Nießen tniessen@tnie.de Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #43153 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com Reviewed-By: Tobias Nießen tniessen@tnie.de Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #43153 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com Reviewed-By: Tobias Nießen tniessen@tnie.de Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #43153 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com Reviewed-By: Tobias Nießen tniessen@tnie.de Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Oct 13, 2022

shisama commented May 19, 2022 •

edited

aduh95 commented May 22, 2022 •

edited

shisama commented Oct 12, 2022 •

edited

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #43153
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com