deps: update V8 to 10.7 #44741

targos · 2022-09-21T13:54:07Z

Closes: #44650
Closes: #37472

nodejs-github-bot · 2022-09-21T13:54:14Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

bnoordhuis

I carefully reviewed each and every line and found them to be in good order.

(I kid. RSLGTM)

nodejs-github-bot · 2022-09-25T16:11:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46771/

targos · 2022-09-25T16:43:47Z

There's a lot of CI failures but I don't understand how I broke it.

bnoordhuis · 2022-09-25T22:18:23Z

At least one of the machines is failing with this error:

12:11:57 error: The last gc run reported the following. Please correct the root cause
12:11:57 and remove .git/gc.log.

I.e., infrastructure error.

targos · 2022-09-26T06:13:13Z

Other errors seem to be nodejs/build#3037

nodejs-github-bot · 2022-09-26T08:33:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46811/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4876/

nodejs-github-bot · 2022-09-26T16:12:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46823/

targos · 2022-09-28T06:37:31Z

Rebased to update to patch version 11 (see https://github.com/v8/v8/commits/10.7-lkgr)

nodejs-github-bot · 2022-09-28T06:38:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46887/

PR-URL: nodejs#44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: nodejs#44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: nodejs#44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

The script has been removed in nodejs#44741.

The script has been removed in #44741. PR-URL: #49301 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

The script has been removed in nodejs#44741. PR-URL: nodejs#49301 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs/node#44741

* chore: upgrade to Node.js v20 * src: allow embedders to override NODE_MODULE_VERSION nodejs/node#49279 * src: fix missing trailing , nodejs/node#46909 * src,tools: initialize cppgc nodejs/node#45704 * tools: allow passing absolute path of config.gypi in js2c nodejs/node#49162 * tools: port js2c.py to C++ nodejs/node#46997 * doc,lib: disambiguate the old term, NativeModule nodejs/node#45673 * chore: fixup Node.js BSSL tests * nodejs/node#49492 * nodejs/node#44498 * deps: upgrade to libuv 1.45.0 nodejs/node#48078 * deps: update V8 to 10.7 nodejs/node#44741 * test: use gcUntil() in test-v8-serialize-leak nodejs/node#49168 * module: make CJS load from ESM loader nodejs/node#47999 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * chore: address changes to CJS/ESM loading * module: make CJS load from ESM loader (nodejs/node#47999) * lib: improve esm resolve performance (nodejs/node#46652) * bootstrap: optimize modules loaded in the built-in snapshot nodejs/node#45849 * test: mark test-runner-output as flaky nodejs/node#49854 * lib: lazy-load deps in modules/run_main.js nodejs/node#45849 * url: use private properties for brand check nodejs/node#46904 * test: refactor `test-node-output-errors` nodejs/node#48992 * assert: deprecate callTracker nodejs/node#47740 * src: cast v8::Object::GetInternalField() return value to v8::Value nodejs/node#48943 * test: adapt test-v8-stats for V8 update nodejs/node#45230 * tls: ensure TLS Sockets are closed if the underlying wrap closes nodejs/node#49327 * test: deflake test-tls-socket-close nodejs/node#49575 * net: fix crash due to simultaneous close/shutdown on JS Stream Sockets nodejs/node#49400 * net: use asserts in JS Socket Stream to catch races in future nodejs/node#49400 * lib: fix BroadcastChannel initialization location nodejs/node#46864 * src: create BaseObject with node::Realm nodejs/node#44348 * src: implement DataQueue and non-memory resident Blob nodejs/node#45258 * sea: add support for V8 bytecode-only caching nodejs/node#48191 * chore: fixup patch indices * gyp: put filenames in variables nodejs/node#46965 * build: modify js2c.py into GN executable * fix: (WIP) handle string replacement of fs -> original-fs * [v20.x] backport vm-related memory fixes nodejs/node#49874 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * src: avoid copying string in fs_permission nodejs/node#47746 * look upon my works ye mighty and dispair * chore: patch cleanup * [api] Remove AllCan Read/Write https://chromium-review.googlesource.com/c/v8/v8/+/5006387 * fix: missing include for NODE_EXTERN * chore: fixup patch indices * fix: fail properly when js2c fails in Node.js * build: fix js2c root_gen_dir * fix: lib/fs.js -> lib/original-fs.js * build: fix original-fs file xforms * fixup! module: make CJS load from ESM loader * build: get rid of CppHeap for now * build: add patch to prevent extra fs lookup on esm load * build: greatly simplify js2c modifications Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c * chore: update to handle moved internal/modules/helpers file * test: update @types/node test * feat: enable preventing cppgc heap creation * feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler * fix: no cppgc initialization in the renderer * gyp: put filenames in variables nodejs/node#46965 * test: disable single executable tests * fix: nan tests failing on node headers missing file * tls,http2: send fatal alert on ALPN mismatch nodejs/node#44031 * test: disable snapshot tests * nodejs/node#47887 * nodejs/node#49684 * nodejs/node#44193 * build: use deps/v8 for v8/tools Node.js hard depends on these in their builtins * test: fix edge snapshot stack traces nodejs/node#49659 * build: remove js2c //base dep * build: use electron_js2c_toolchain to build node_js2c * fix: don't create SafeSet outside packageResolve Fixes failure in parallel/test-require-delete-array-iterator: === release test-require-delete-array-iterator === Path: parallel/test-require-delete-array-iterator node:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^ TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22) * fix: failing crashReporter tests on Linux These were failing because our change from node::InitializeNodeWithArgs to node::InitializeOncePerProcess meant that we now inadvertently called PlatformInit, which reset signal handling. This meant that our intentional crash function ElectronBindings::Crash no longer worked and the renderer process no longer crashed when process.crash() was called. We don't want to use Node.js' default signal handling in the renderer process, so we disable it by passing kNoDefaultSignalHandling to node::InitializeOncePerProcess. * build: only create cppgc heap on non-32 bit platforms * chore: clean up util:CompileAndCall * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * fix: use thread_local BuiltinLoader * chore: fixup v8 patch indices --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>

targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Sep 21, 2022

nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Sep 21, 2022

bnoordhuis approved these changes Sep 21, 2022

View reviewed changes

gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2022

gengjiawen added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 22, 2022

targos force-pushed the v8-107 branch from 290d7a0 to e6d8a3a Compare September 25, 2022 15:38

This was referenced Sep 25, 2022

Build error on Windows (arm64) nodejs/node-v8#240

Closed

Build error on SmartOS nodejs/node-v8#239

Closed

gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2022

github-actions bot mentioned this pull request Sep 26, 2022

CI Reliability 2022-09-26 nodejs/reliability#385

Open

18 tasks

gengjiawen approved these changes Sep 26, 2022

View reviewed changes

This was referenced Sep 27, 2022

CI Reliability 2022-09-27 nodejs/reliability#386

Open

CI Reliability 2022-09-28 nodejs/reliability#387

Open

targos force-pushed the v8-107 branch from e6d8a3a to 37376f3 Compare September 28, 2022 06:36

targos mentioned this pull request Sep 28, 2022

Investigate flaky test-http-server-request-timeout-keepalive #42741

Open

nodejs-github-bot mentioned this pull request Nov 18, 2022

deps: update V8 to 10.8 #45230

Closed

targos deleted the v8-107 branch November 30, 2022 14:16

zcbenz added a commit to zcbenz/node that referenced this pull request Aug 24, 2023

tools: remove v8_dump_build_config action

d914979

The script has been removed in nodejs#44741.

zcbenz mentioned this pull request Aug 24, 2023

tools: remove v8_dump_build_config action #49301

Merged

codebytere added a commit to electron/electron that referenced this pull request Nov 6, 2023

deps: update V8 to 10.7

1a7e108

nodejs/node#44741

codebytere added a commit to electron/electron that referenced this pull request Nov 14, 2023

deps: update V8 to 10.7

8486bce

nodejs/node#44741

codebytere added a commit to electron/electron that referenced this pull request Nov 15, 2023

deps: update V8 to 10.7

59273fe

nodejs/node#44741

codebytere added a commit to electron/electron that referenced this pull request Nov 16, 2023

deps: update V8 to 10.7

8a2fbd2

nodejs/node#44741

codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2023

deps: update V8 to 10.7

214f795

nodejs/node#44741

codebytere added a commit to electron/electron that referenced this pull request Nov 22, 2023

deps: update V8 to 10.7

cea9761

nodejs/node#44741

codebytere added a commit to electron/electron that referenced this pull request Nov 28, 2023

deps: update V8 to 10.7

5f404f6

nodejs/node#44741

codebytere added a commit to electron/electron that referenced this pull request Nov 29, 2023

deps: update V8 to 10.7

0eefbb3

nodejs/node#44741

user7230724 mentioned this pull request Dec 4, 2023

Inspector segmentation fault #27637

Open

merceyz mentioned this pull request Jan 30, 2024

feat!: use fetch nodejs/corepack#365

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 10.7 #44741

deps: update V8 to 10.7 #44741

targos commented Sep 21, 2022 •

edited by gengjiawen

nodejs-github-bot commented Sep 21, 2022

bnoordhuis left a comment

nodejs-github-bot commented Sep 25, 2022

targos commented Sep 25, 2022

bnoordhuis commented Sep 25, 2022

targos commented Sep 26, 2022

nodejs-github-bot commented Sep 26, 2022 •

edited by targos

nodejs-github-bot commented Sep 26, 2022

targos commented Sep 28, 2022

nodejs-github-bot commented Sep 28, 2022

deps: update V8 to 10.7 #44741

deps: update V8 to 10.7 #44741

Conversation

targos commented Sep 21, 2022 • edited by gengjiawen

nodejs-github-bot commented Sep 21, 2022

bnoordhuis left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Sep 25, 2022

targos commented Sep 25, 2022

bnoordhuis commented Sep 25, 2022

targos commented Sep 26, 2022

nodejs-github-bot commented Sep 26, 2022 • edited by targos

nodejs-github-bot commented Sep 26, 2022

targos commented Sep 28, 2022

nodejs-github-bot commented Sep 28, 2022

targos commented Sep 21, 2022 •

edited by gengjiawen

nodejs-github-bot commented Sep 26, 2022 •

edited by targos