New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix operation not permitted #44783

Closed

thoqbk wants to merge 2 commits into nodejs:main from thoqbk:master

Contributor

thoqbk commented Sep 25, 2022 •

edited

issue:

copyDir() calls checkPathsSync(), which invokes lstat()
which causes error because of not checking the opts.filter

changes:

check opts.filter before calling checkPathsSync and copy logic
cleanup startCopy function


          fs.cp: fix operation not permitted

d5455c6

fix: nodejs#44720

issue:
- [copyDir](https://github.com/nodejs/node/blob/7e0097d8a33fa7adbc1f298cbf647f6d2fd403e8/lib/internal/fs/cp/cp-sync.js#L287-L289) calls checkPathsSync(), which invokes lstat() which causes error because not checking the opts.filter

changes:
- check opts.filter before calling `checkPathsSync` and invoking copy logic
- cleanup `startCopy` function

nodejs-github-bot added fs needs-ci labels

thoqbk changed the title ~~fs.cp: fix operation not permitted~~ fs: fix operation not permitted


          fs: fix wrong variables

15caecb

thoqbk force-pushed the master branch from 8f8cabe to 15caecb Compare

September 25, 2022 10:30

thoqbk closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment