Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix operation not permitted #44783

Closed
wants to merge 2 commits into from
Closed

fs: fix operation not permitted #44783

wants to merge 2 commits into from

Commits on Sep 25, 2022

  1. fs.cp: fix operation not permitted 

    fix: nodejs#44720

issue:
- [copyDir](https://github.com/nodejs/node/blob/7e0097d8a33fa7adbc1f298cbf647f6d2fd403e8/lib/internal/fs/cp/cp-sync.js#L287-L289) calls checkPathsSync(), which invokes lstat() which causes error because not checking the opts.filter

changes:
- check opts.filter before calling `checkPathsSync` and invoking copy logic
- cleanup `startCopy` function
    @thoqbk
    thoqbk committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    d5455c6 View commit details
    Browse the repository at this point in the history

  2. fs: fix wrong variables

    @thoqbk
    thoqbk committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    15caecb View commit details
    Browse the repository at this point in the history