Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: avoid swallowing of asynchronously thrown errors #45264

Merged
merged 1 commit into from Nov 7, 2022
Merged

test_runner: avoid swallowing of asynchronously thrown errors #45264

merged 1 commit into from Nov 7, 2022

Conversation

fossamagna
Copy link
Contributor

Fixes: #44612

MoLow
MoLow previously approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this seems to have affected test/es-module/test-esm-repl-imports.js

@MoLow MoLow dismissed their stale review November 1, 2022 18:29

test/es-module/test-esm-repl-imports.js

@fossamagna fossamagna requested review from VoltrexKeyva and MoLow and removed request for VoltrexKeyva and MoLow November 2, 2022 06:11
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47629/

@MoLow
Copy link
Member

MoLow commented Nov 2, 2022

CC @nodejs/test_runner an additional approval would be appreciated

@aduh95
Copy link
Contributor

aduh95 commented Nov 2, 2022 •
edited

⚠️The commit message should start with a verb – e.g. test_runner: avoid swallowing of asynchronously thrown errors.

@fossamagna fossamagna changed the title test_runner: extraneous async activity make a failure test_runner: avoid swallowing of asynchronously thrown errors Nov 3, 2022
@MoLow
Copy link
Member

MoLow commented Nov 7, 2022

@fossamagna can you please amend the commit message?

@fossamagna fossamagna force-pushed the test-runner-extraneous-async-fail branch from 79cc2f1 to 5f17453 Compare November 7, 2022 06:12
@fossamagna
Copy link
Contributor Author

fossamagna commented Nov 7, 2022 •
edited

@MoLow I squashed commits and amend commit message.

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2022
@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@fossamagna fossamagna deleted the test-runner-extraneous-async-fail branch November 7, 2022 13:50
This was referenced Nov 8, 2022
Open
Open
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
@fossamagna
test_runner: avoid swallowing of asynchronously thrown errors
3b8cdb9 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Open
20 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@fossamagna @RafaelGSS
test_runner: avoid swallowing of asynchronously thrown errors
920804d 
Fixes: #44612
PR-URL: #45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
Merged
@github-actions github-actions bot mentioned this pull request Nov 11, 2022
Open
19 tasks
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
d65bb85 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
74fb613 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow MoLow mentioned this pull request Nov 24, 2022
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
549b123 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams
Copy link
Member

@fossamagna this broke when landing in v18.x-staging. Do you mind opening a backport PR for this?

@fossamagna
Copy link
Contributor Author

@danielleadams Yes, I will open backport PR for this.

fossamagna added a commit to fossamagna/node that referenced this pull request Dec 29, 2022
@fossamagna
test_runner: avoid swallowing of asynchronously thrown errors
6bba8f9 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@fossamagna fossamagna mentioned this pull request Dec 29, 2022
Closed
@danielleadams danielleadams added the backport-open-v18.x Indicate that the PR has an open backport. label Dec 30, 2022
fossamagna added a commit to fossamagna/node that referenced this pull request Jan 23, 2023
@fossamagna
test_runner: avoid swallowing of asynchronously thrown errors
024450a 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
e62520f 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
155440e 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow MoLow mentioned this pull request Jan 26, 2023
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
53d8bf8 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
8eac8c3 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@fossamagna @MoLow
fix: avoid swallowing of asynchronously thrown errors
e409b25 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@fossamagna @MoLow
fix: avoid swallowing of asynchronously thrown errors
ce33670 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@fossamagna @MoLow
fix: avoid swallowing of asynchronously thrown errors
cff397a 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 25, 2023
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
9ec0a4e 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@fossamagna @juanarbol
test_runner: avoid swallowing of asynchronously thrown errors
c662025 
Fixes: #44612
PR-URL: #45264
Backport-PR-URL: #46839
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@fossamagna @juanarbol
test_runner: avoid swallowing of asynchronously thrown errors
5fdf374 
Fixes: #44612
PR-URL: #45264
Backport-PR-URL: #46839
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@benjamingr benjamingr benjamingr approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v18.x Indicate that the PR has an open backport. needs-ci PRs that need a full CI run. test_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test runner swallows uncaughtException
7 participants
@fossamagna @nodejs-github-bot @MoLow @aduh95 @danielleadams @benjamingr @VoltrexKeyva