[v18.x] deps: V8: cherry-pick 5fe919f78321 #45587

richardlau · 2022-11-22T17:41:18Z

Original commit message:

PPC: clear VXCVI before doing a conversion

This bit may not get cleared automatically and could show
results from older executed instructions.

Change-Id: I5976f9a6c5bf87b1a63ef0f35493b222729e20f6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812037
Reviewed-by: Junliang Yan <junyan@redhat.com>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#82237}

Refs: v8/v8@5fe919f

cc @nodejs/platform-aix @nodejs/platform-ppc

Noticed from the CITGM CI runs for nodejs/citgm#905 that PPC platforms (AIX and Linux) on Node.js 18 were failing (note that the PR marks ppc as flaky so Jenkins marks the run as passing but the yarn tests failed) with:
e.g. https://ci.nodejs.org/job/citgm-smoker-nobuild/1463/nodes=rhel8-ppc64le/console

07:09:17 verbose: @yarnpkg/cli npm-test:| RuntimeError: float unrepresentable in integer range                                                                                                                                                         
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[1041]:0xe1004                                                                                                                                                          
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[1442]:0x1406a3                                                                                                                                                         
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[751]:0xa66c9                                                                                                                                                           
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[751]:0xa6536                                                                                                                                                           
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[751]:0xa6536                                                                                                                                                           
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[751]:0xa6536                                                                                                                                                           
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[751]:0xa6536                                                                                                                                                           
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[1034]:0xe0ed4                                                                                                                                                          
07:09:17 verbose:                       | at wasm://wasm/02834d3a:wasm-function[1032]:0xe0ea7                                                                                                                                                          
07:09:17 verbose:                       | at globalThis.Go.run (/home/iojs/tmp/citgm_tmp/e9a10d7f-d071-4ac5-b4c2-80b8e64ba7dd/@yarnpkg/cli/.yarn/cache/esbuild-wasm-npm-0.15.5-bc4c954bca-149219c551.zip/node_modules/esbuild-wasm/wasm_exec.js:527:23)

with this backport Linux PPC is fixed 🎉 : https://ci.nodejs.org/job/citgm-smoker/3049/nodes=rhel8-ppc64le/
Although we now get a different issue on AIX which looks to be a crash of some sort: https://ci.nodejs.org/job/citgm-smoker/3049/nodes=aix72-ppc64/console

nodejs-github-bot · 2022-11-22T17:41:22Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

richardlau · 2022-11-22T17:49:02Z

This change is already on main/v19.x as part of a V8 update.

richardlau · 2022-11-24T17:59:20Z

Rebased to pick up workflow fixes on v18.x-staging.

richardlau · 2022-11-24T18:07:11Z

Although we now get a different issue on AIX which looks to be a crash of some sort

I spoke with @V-for-Vasili who has been looking into issues with yarn on ppc platforms -- these crashes are in the go runtime on AIX so outside of the scope of Node.js. Merging this will at least fix the Node.js part (and will allow the yarn:cli tests to pass Node.js 18 on Linux ppc64le).

nodejs-github-bot · 2022-11-24T18:09:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48165/

nodejs-github-bot · 2022-11-24T18:10:00Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5012/

nodejs-github-bot · 2022-11-24T18:11:52Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5012/

nodejs-github-bot · 2022-11-24T18:12:03Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5012/

nodejs-github-bot · 2022-11-24T22:01:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48175/

Original commit message: PPC: clear VXCVI before doing a conversion This bit may not get cleared automatically and could show results from older executed instructions. Change-Id: I5976f9a6c5bf87b1a63ef0f35493b222729e20f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812037 Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82237} Refs: v8/v8@5fe919f

richardlau · 2023-01-11T17:02:26Z

Looks like this missed the last v18.13.0. Rebased onto current v18.x-staging.

nodejs-github-bot · 2023-01-11T17:14:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48948/

nodejs-github-bot · 2023-01-11T17:14:40Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5119/

nodejs-github-bot · 2023-01-11T17:16:49Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5119/

nodejs-github-bot · 2023-01-11T17:17:36Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5119/

mhdawson

LGTM

Original commit message: PPC: clear VXCVI before doing a conversion This bit may not get cleared automatically and could show results from older executed instructions. Change-Id: I5976f9a6c5bf87b1a63ef0f35493b222729e20f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812037 Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82237} Refs: v8/v8@5fe919f PR-URL: #45587 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

richardlau · 2023-01-17T16:50:58Z

Landed in 8dce62c.

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2022

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Nov 22, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2022

This comment was marked as outdated.

Sign in to view

richardlau force-pushed the ppcbp branch from 470ffea to a6e5331 Compare November 24, 2022 17:59

richardlau force-pushed the ppcbp branch from a6e5331 to d999d67 Compare November 24, 2022 18:00

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2022

This was referenced Nov 25, 2022

CI Reliability 2022-11-25 nodejs/reliability#439

Open

CI Reliability 2022-11-26 nodejs/reliability#440

Open

CI Reliability 2022-11-27 nodejs/reliability#441

Open

This was referenced Nov 28, 2022

CI Reliability 2022-11-28 nodejs/reliability#442

Open

CI Reliability 2022-11-29 nodejs/reliability#443

Open

CI Reliability 2022-11-30 nodejs/reliability#444

Open

CI Reliability 2022-12-01 nodejs/reliability#445

Open

danielleadams force-pushed the v18.x-staging branch 2 times, most recently from 2098d7a to bac6b7d Compare January 4, 2023 17:10

richardlau force-pushed the ppcbp branch from d999d67 to a6e55d5 Compare January 11, 2023 16:59

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2023

mhdawson approved these changes Jan 12, 2023

View reviewed changes

gengjiawen approved these changes Jan 13, 2023

View reviewed changes

gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 13, 2023

richardlau closed this Jan 17, 2023

richardlau deleted the ppcbp branch January 17, 2023 16:51

juanarbol mentioned this pull request Jan 28, 2023

V18.14.0 proposal #46396

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v18.x] deps: V8: cherry-pick 5fe919f78321 #45587

[v18.x] deps: V8: cherry-pick 5fe919f78321 #45587

richardlau commented Nov 22, 2022 •

edited

nodejs-github-bot commented Nov 22, 2022

richardlau commented Nov 22, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

richardlau commented Nov 24, 2022

richardlau commented Nov 24, 2022

nodejs-github-bot commented Nov 24, 2022

nodejs-github-bot commented Nov 24, 2022

nodejs-github-bot commented Nov 24, 2022

nodejs-github-bot commented Nov 24, 2022

nodejs-github-bot commented Nov 24, 2022

richardlau commented Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

mhdawson left a comment

richardlau commented Jan 17, 2023

[v18.x] deps: V8: cherry-pick 5fe919f78321 #45587

[v18.x] deps: V8: cherry-pick 5fe919f78321 #45587

Conversation

richardlau commented Nov 22, 2022 • edited

nodejs-github-bot commented Nov 22, 2022

richardlau commented Nov 22, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

richardlau commented Nov 24, 2022

richardlau commented Nov 24, 2022

nodejs-github-bot commented Nov 24, 2022

nodejs-github-bot commented Nov 24, 2022

nodejs-github-bot commented Nov 24, 2022

nodejs-github-bot commented Nov 24, 2022

nodejs-github-bot commented Nov 24, 2022

richardlau commented Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

mhdawson left a comment

Choose a reason for hiding this comment

richardlau commented Jan 17, 2023

richardlau commented Nov 22, 2022 •

edited