Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix mock.method to support class instances #45608

Merged
merged 19 commits into from Dec 17, 2022
Merged

test_runner: fix mock.method to support class instances #45608

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c074724
test: fix mock.method to support class instances
ErickWendel Nov 24, 2022
495cebf
added suggestions
ErickWendel Nov 24, 2022
e80de49
test: remove unecessarly if
ErickWendel Nov 24, 2022
628142e
test: drop comments and rename tests
ErickWendel Nov 30, 2022
7fd649a
test_runner: ensure that mock.method works with class inheritance
ErickWendel Nov 30, 2022
1ff9a5f
test: ensure that the original object was reseted after execution
ErickWendel Nov 30, 2022
7ca9a2b
test_runner: added aduh95's suggestion to extend null
ErickWendel Dec 6, 2022
ef3188f
test_runner: remote proto.name validation on mock
ErickWendel Dec 6, 2022
8104c2a
test: fix lint
ErickWendel Dec 6, 2022
73ca820
test_runner: added cjihrig suggestions to turn fns private
ErickWendel Dec 6, 2022
fe66804
test_runner: validate properties in objects
ErickWendel Dec 6, 2022
e35911f
test_runner: add colin's suggestion to simplify algorithm on mock
ErickWendel Dec 6, 2022
92b68b4
test_runner: turn fn into inline if
ErickWendel Dec 7, 2022
9659cba
test_runner: when method doesnt exists it shows a message
ErickWendel Dec 7, 2022
a6cebb6
add aduh95 suggestion test/parallel/test-runner-mocking.js
ErickWendel Dec 12, 2022
c075f0e
test: assert by code instead of regex string
ErickWendel Dec 12, 2022
2edd34e
test_runner: rename object
ErickWendel Dec 12, 2022
f543e57
test_runner: add test case to check prototype chain
ErickWendel Dec 13, 2022
152539d
test: assert property descriptors
ErickWendel Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 16 additions & 6 deletions test/parallel/test-runner-mocking.js
View file
Open in desktop
Expand Up @@ -446,17 +446,27 @@ test('spy functions don\'t affect the prototype chain', (t) => {

const msg = 'ok';

const ABeforeMockIsUnchanged = Object.getOwnPropertyDescriptor(A, A.someTask.name);
const BBeforeMockIsUnchanged = Object.getOwnPropertyDescriptor(B, B.someTask.name);
const CBeforeMockShouldNotHaveDesc = Object.getOwnPropertyDescriptor(C, C.someTask.name);
ErickWendel marked this conversation as resolved.
Show resolved Hide resolved

t.mock.method(C, C.someTask.name);
C.someTask(msg);
const BAfterMockIsUnchanged = Object.getOwnPropertyDescriptor(B, B.someTask.name);

const AAfterMockIsUnchanged = Object.getOwnPropertyDescriptor(A, A.someTask.name);
const CAfterMockHasDescriptor = Object.getOwnPropertyDescriptor(C, C.someTask.name);

assert.strictEqual(CBeforeMockShouldNotHaveDesc, undefined);
assert.ok(CAfterMockHasDescriptor);

assert.strictEqual(B.someTask.mock, undefined);
assert.strictEqual(A.someTask.mock, undefined);
assert.deepStrictEqual(ABeforeMockIsUnchanged, AAfterMockIsUnchanged);
assert.strictEqual(BBeforeMockIsUnchanged, BAfterMockIsUnchanged);
assert.strictEqual(BBeforeMockIsUnchanged, undefined);

assert.strictEqual(C.someTask.mock.restore(), undefined);
C.someTask(msg);
assert.strictEqual(C.someTask.mock, undefined);
assert.strictEqual(B.someTask.mock, undefined);
assert.strictEqual(A.someTask.mock, undefined);
const CAfterRestoreKeepsDescriptor = Object.getOwnPropertyDescriptor(C, C.someTask.name);
assert.ok(CAfterRestoreKeepsDescriptor);
});

test('mocked functions report thrown errors', (t) => {
Expand Down