New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v19.x backport] src,lib: group properties used as constants from `util` binding #45674

Closed

daeyeon wants to merge 2 commits into nodejs:v19.x-staging from daeyeon:v19.x-staging.backport-45539

Member

daeyeon commented Nov 29, 2022 •

edited

Backports:

nodejs-github-bot added lib / src needs-ci v19.x labels

daeyeon added the request-ci label

Member

MoLow commented Nov 29, 2022

why is backporting needed to v19?

github-actions bot removed the request-ci label

This comment was marked as outdated.

Sign in to view

Member Author

daeyeon commented Nov 29, 2022

@MoLow #45539 (comment) It's requested. Guess it's useful for removing future conflicts upon the files changed on this patch.

Member

targos commented Nov 29, 2022

There's a chain of commits that depend on each other which started with #45125 (marked dont-land-on-v19.x).
It would probably be better to backport 066e77a first (can be done in the same PR).

joyeecheung and others added 2 commits

November 29, 2022 23:17


          util: use private symbols in JS land directly

18d9474

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: nodejs#45379
Backport-PR-URL: nodejs#45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>


          src,lib: group properties used as constants from util binding

f06e8e9

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: nodejs#45539
Backport-PR-URL: nodejs#45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

daeyeon force-pushed the v19.x-staging.backport-45539 branch from 0567596 to f06e8e9 Compare

November 29, 2022 14:19

Member Author

daeyeon commented Nov 29, 2022

@targos 066e77a is added also. PTAL

daeyeon added the request-ci label

github-actions bot removed the request-ci label

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

targos approved these changes

View reviewed changes

github-actions bot mentioned this pull request

CI Reliability 2022-12-07 nodejs/reliability#450

Open

10 tasks

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request

CI Reliability 2022-12-08 nodejs/reliability#451

Open

8 tasks

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request

CI Reliability 2022-12-09 nodejs/reliability#452

Open

5 tasks

Collaborator

nodejs-github-bot commented Dec 9, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48363/

This was referenced Dec 10, 2022

CI Reliability 2022-12-10 nodejs/reliability#453

Open

CI Reliability 2022-12-11 nodejs/reliability#454

Open

CI Reliability 2022-12-12 nodejs/reliability#455

Open

daeyeon added commit-queue commit-queue-squash labels

daeyeon added commit-queue-rebase and removed commit-queue-squash labels

targos pushed a commit that referenced this pull request


          util: use private symbols in JS land directly

8164a41

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

targos pushed a commit that referenced this pull request


          src,lib: group properties used as constants from util binding

b401800

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Member

targos commented Dec 12, 2022

Landed in e8406a8...b401800

targos closed this

github-actions bot mentioned this pull request

CI Reliability 2022-12-13 nodejs/reliability#456

Open

13 tasks

targos pushed a commit that referenced this pull request


          util: use private symbols in JS land directly

470384e

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

targos pushed a commit that referenced this pull request


          src,lib: group properties used as constants from util binding

2fbe2f9

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

danielleadams pushed a commit that referenced this pull request


          util: use private symbols in JS land directly

aef2af3

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

danielleadams pushed a commit that referenced this pull request


          src,lib: group properties used as constants from util binding

e770c80

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

danielleadams pushed a commit that referenced this pull request


          util: use private symbols in JS land directly

3d2bef5

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

danielleadams pushed a commit that referenced this pull request


          src,lib: group properties used as constants from util binding

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

danielleadams pushed a commit that referenced this pull request


          util: use private symbols in JS land directly

3f18a83

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

danielleadams pushed a commit that referenced this pull request


          src,lib: group properties used as constants from util binding

90e8418

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

danielleadams pushed a commit that referenced this pull request


          util: use private symbols in JS land directly

759e747

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

danielleadams pushed a commit that referenced this pull request


          src,lib: group properties used as constants from util binding

714ca6d

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

danielleadams pushed a commit that referenced this pull request


          util: use private symbols in JS land directly

2bd79a3

Instead of calling into C++ to use the private symbols, use an
ObjectTemplate to create an object that holds the symbols and
use them directly from JS land.

PR-URL: #45379
Backport-PR-URL: #45674
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

danielleadams pushed a commit that referenced this pull request


          src,lib: group properties used as constants from util binding

b02b3c8

Properties used as constants in `util` internal binding are
scattered. This suggests using an object holding all of them
for better maintenance.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #45539
Backport-PR-URL: #45674
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment