Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v19.x backport] src,lib: group properties used as constants from util binding #45674

Closed

Commits on Nov 29, 2022

  1. util: use private symbols in JS land directly

    Instead of calling into C++ to use the private symbols, use an
    ObjectTemplate to create an object that holds the symbols and
    use them directly from JS land.
    
    PR-URL: nodejs#45379
    Backport-PR-URL: nodejs#45674
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    
    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    joyeecheung authored and daeyeon committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    18d9474 View commit details
    Browse the repository at this point in the history
  2. src,lib: group properties used as constants from util binding

    Properties used as constants in `util` internal binding are
    scattered. This suggests using an object holding all of them
    for better maintenance.
    
    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: nodejs#45539
    Backport-PR-URL: nodejs#45674
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    daeyeon committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f06e8e9 View commit details
    Browse the repository at this point in the history