Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix tls certificate root store data race #45767

Merged
merged 1 commit into from Dec 19, 2022
Merged

src: fix tls certificate root store data race #45767

merged 1 commit into from Dec 19, 2022

Commits on Dec 8, 2022

  1. src: fix tls certificate root store data race 

    OpenSSL internally synchronizes access to the X509_STORE. Creation of
the global root store in Node was not properly synchronized, however,
introducing the possibility of data races when multiple threads try to
create it concurrently.

This commit coincidentally removes the last call to the thread-unsafe
ERR_error_string() function.

Fixes: nodejs#45743
    @bnoordhuis
    bnoordhuis committed Dec 8, 2022
    Copy the full SHA
    99e4a76 View commit details
    Browse the repository at this point in the history