v16.19.0 proposal #45791
Merged
v16.19.0 proposal #45791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream merge of e27e709d3c accidentally removed code related to systemtap and dtrace. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #44642 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This is important to allow to run v16 doc tests on more recent versions. PR-URL: #45255 Refs: https://github.com/nodejs/node/actions/runs/3356902660/jobs/5562322617 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
PR-URL: #44775 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #44929 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #44950 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Both paths for the condition being removed result in the same value being assigned to `openssl_product`. This condition was also problematic as it was testing a variable in the same scope which gyp/gyp-next currently does not support. Refs: https://gyp.gsrc.io/docs/InputFormatReference.md#user_defined-variables PR-URL: #45076 Refs: nodejs/node-gyp#2750 Refs: #38633 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This updates all sources in deps/openssl/openssl by:
$ git clone https://github.com/quictls/openssl
$ cd openssl
$ git checkout OpenSSL_1_1_1s+quic
$ cd ../node/deps/openssl
$ rm -rf openssl
$ cp -R ../openssl openssl
$ rm -rf openssl/.git* openssl/.travis*
$ git add --all openssl
$ git commit openssl
PR-URL: #45274
Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-November/000242.html
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: #45274 Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-November/000242.html Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Fixes for SC2312 added in shellcheck 0.8.0. PR-URL: #41258 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #45581 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #45236 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
The `Shift_JIS` encoding may not be available, e.g. when Node.js is configured with `--with-intl=small-icu`. PR-URL: #45225 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Original commit message:
[extensions] Fix dcheck failures in getV8Statistics
HeapObjectIterator creates a SafepointScope which requires the heap to
allow garbage collection. This collides with the outer
DisallowGarbageCollection scope. HeapObjectIterator already ensures
there is no allocation during its lifetime, so there is no need to
create an outer DisallowGarbageCollection scope.
Code::source_position_table requires their kind not equals to
CodeKind::BASELINE.
This also exposes the statistics extension through flag
--expose-statistics.
Bug: v8:12657
Change-Id: I1bf11cf499285a742dd99ec8c228ebc36152b597
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3496552
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Chengzhong Wu <legendecas@gmail.com>
Cr-Commit-Position: refs/heads/main@{#79425}
Refs: v8/v8@b953542
PR-URL: #44947
Refs: v8/v8@bbd800c
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Original commit message:
[heap] Fix incorrect from space committed size
NewSpace page operations like RemovePage, PrependPage, and
EnsureCurrentCapacity should account for committed page size.
This may happen when a page was promoted from the new space to
old space on mark-compact.
Also, add DCHECKs on Commit and Uncommit to ensure the final
committed page size is the same as the current state.
Bug: v8:12657
Change-Id: I7aebc1fd3f51f177ae2ef6420f757f0c573e126b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3504766
Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Chengzhong Wu <legendecas@gmail.com>
Cr-Commit-Position: refs/heads/main@{#79426}
Refs: v8/v8@bbd800c
PR-URL: #44947
Refs: v8/v8@b953542
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #45322 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: electron/electron#35801 Refs: nodejs/abi-stable-node#441 Electron recently dropped support for external buffers. Provide a way for addon authors to: - hide the methods to create external buffers so they can avoid using them if they want the broadest compatibility. - call the methods that create external buffers at runtime to check if external buffers are supported and either use them or not based on the return code. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #45181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
PR-URL: #45191 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #45191 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Users can set a default value for every expected input argument PR-URL: #44631 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
No, Node.js 16 is in maintenance and we're trying to keep the number of changes down. The emphasis for maintenance is on stability. See https://github.com/nodejs/Release#release-phases:
I would generally only consider a change for performance if an earlier release in the same release line regressed performance significantly. If you want performance improvements backported to an LTS release, Node.js 18 is in Active LTS and would typically get them when the release team deems them stable enough (usually a minimum of two weeks in a current release without known issues). |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
9 tasks
RafaelGSS
approved these changes
Dec 10, 2022
11 tasks
gengjiawen
approved these changes
Dec 11, 2022
This was referenced Dec 12, 2022
|
Release build on 2adea16: https://ci-release.nodejs.org/job/iojs+release/9006/ |
richardlau
added a commit
that referenced
this pull request
Dec 13, 2022
Notable changes: - OpenSSL 1.1.1s - Root certificates updated to NSS 3.85 - Time zone update to 2022f - add dgram send queue info - upgrade npm to 8.19.3 - add `--watch` - add default value option to parsearg PR-URL: #45791
richardlau
added a commit
to richardlau/nodejs.org
that referenced
this pull request
Dec 13, 2022
richardlau
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Dec 13, 2022
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Dec 13, 2022
12 tasks
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 21, 2022
Refs: #45791 PR-URL: #45846 Refs: nodejs/nodejs.org#4972 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau
added a commit
that referenced
this pull request
Dec 21, 2022
Refs: #45791 PR-URL: #45846 Refs: nodejs/nodejs.org#4972 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Notable changes: - OpenSSL 1.1.1s - Root certificates updated to NSS 3.85 - Time zone update to 2022f - add dgram send queue info - upgrade npm to 8.19.3 - add `--watch` - add default value option to parsearg PR-URL: nodejs/node#45791
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Notable changes: - OpenSSL 1.1.1s - Root certificates updated to NSS 3.85 - Time zone update to 2022f - add dgram send queue info - upgrade npm to 8.19.3 - add `--watch` - add default value option to parsearg PR-URL: nodejs/node#45791
oraluben
pushed a commit
to oraluben/node
that referenced
this pull request
Mar 14, 2023
oraluben
pushed a commit
to oraluben/node
that referenced
this pull request
Mar 14, 2023
Refs: nodejs/node#45791 PR-URL: nodejs/node#45846 Refs: nodejs/nodejs.org#4972 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
oraluben
pushed a commit
to oraluben/node
that referenced
this pull request
Mar 17, 2023
oraluben
pushed a commit
to oraluben/node
that referenced
this pull request
Mar 17, 2023
Refs: nodejs/node#45791 PR-URL: nodejs/node#45846 Refs: nodejs/nodejs.org#4972 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2022-12-13, Version 16.19.0 'Gallium' (LTS), @richardlau
Notable Changes
OpenSSL 1.1.1s
This update is a bugfix release and does not address any security
vulnerabilities.
Root certificates updated to NSS 3.85
Certificates added:
Certificates removed:
Time zone update to 2022f
Time zone data has been updated to 2022f. This includes changes to Daylight
Savings Time (DST) for Fiji and Mexico. For more information, see
https://mm.icann.org/pipermail/tz-announce/2022-October/000075.html.
Other Notable Changes
33707dcd03] - dgram: add dgram send queue info (theanarkh) #44149Dependency updates:
3b2b70d792] - deps: upgrade npm to 8.19.3 (npm team) #45322Experimental features:
1e0dcd1ee0] - cli: add--watch(Moshe Atlow) #443668c73279ebb] - util: add default value option to parsearg (Manuel Spigolon) #44631Commits
bbef3c42f6] - build: add version info to timezone update PR (Darshan Sen) #45021cc2c7648e0] - build: support Python 3.11 (Luigi Pinca) #45191ac24c80663] - build: remove redundant condition from common.gypi (Richard Lau) #4507603dcbe3030] - build: fix bad upstream merge (Stephen Gallagher) #446421e0dcd1ee0] - cli: add--watch(Moshe Atlow) #4436696d131665e] - cluster: use inspector utils (Moshe Atlow) #44592704836033a] - crypto: update root certificates (Luigi Pinca) #454905a776d4a69] - deps: update timezone to 2022f (Richard Lau) #456133b2b70d792] - deps: upgrade npm to 8.19.3 (npm team) #453229fbc8b21db] - deps: update corepack to 0.15.1 (Node.js GitHub Bot) #4533187e3d002ca] - deps: update corepack to 0.15.0 (Node.js GitHub Bot) #45235e972ff7b13] - deps: V8: backport bbd800c6e359 (Chengzhong Wu) #44947af9d8217c0] - deps: V8: cherry-pick b95354290941 (Chengzhong Wu) #4494738202d321b] - deps: update undici to 5.12.0 (Node.js GitHub Bot) #452367c0da6adf9] - deps: update archs files for OpenSSL-1.1.1s (RafaelGSS) #452741149ead6f7] - deps: upgrade openssl sources to OpenSSL_1_1_1s (RafaelGSS) #45274cd54bce4f5] - deps: update timezone (Node.js GitHub Bot) #449502901abe4f0] - deps: update undici to 5.11.0 (Node.js GitHub Bot) #44929c80cf97033] - deps: update corepack to 0.14.2 (Node.js GitHub Bot) #4477533707dcd03] - dgram: add dgram send queue info (theanarkh) #44149c708d9bb94] - doc: fix typo in parseArgs default value (Tobias Nießen) #450835a0efa05d2] - node-api: handle no support for external buffers (Michael Dawson) #45181db31de634e] - readline: refactor to avoid unsafe regex primordials (Antoine du Hamel) #43475fbc52e5729] - src: disambiguate terms used to refer to builtins and addons (Joyee Cheung) #44135953072d3db] - src: let http2 streams end after session close (Santiago Gimeno) #4515354608d8dc3] - src: split property helpers from node::Environment (Chengzhong Wu) #440566733556783] - test: add test to validate changelogs for releases (Richard Lau) #45325821d832cef] - test: mark test-watch-mode* as flaky on all platforms (Pierrick Bouvier) #4504902a18eac69] - test: fix test-runner-inspect (Moshe Atlow) #44620197df63f74] - test: add a test to ensure the correctness of timezone upgrades (Darshan Sen) #4529942e9d8016a] - test: fix textdecoder test for small-icu builds (Richard Lau) #452256d736a56d8] - test: fix watch mode test flake (Moshe Atlow) #44739543d3d2bf3] - test: deflake watch mode tests (Moshe Atlow) #4462197f6caf4eb] - test: split watch mode inspector tests to sequential (Moshe Atlow) #44551499750ff7a] - test: update list of known globals (Antoine du Hamel) #4525564d343af74] - test_runner: support using--inspectwith--test(Moshe Atlow) #4452099ee5e484d] - test_runner: fixduration_msto be milliseconds (Moshe Atlow) #4445037e909251c] - test_runner: support programmatically running--test(Moshe Atlow) #442410ae5694f88] - tools: update certdata.txt (Luigi Pinca) #45490891368cefd] - tools: remove faulty early termination logic from update-timezone.mjs (Darshan Sen) #44870543493c242] - tools: fix timezone update tool (Darshan Sen) #44870c77f660b75] - tools: fixcreate-or-update-pull-request-actionhash on GHA (Antoine du Hamel) #4516658c30dd049] - tools: update gr2m/create-or-update-pull-request-action (Luigi Pinca) #45022749a4b3e5e] - tools: use Python 3.11 in GitHub Actions workflows (Luigi Pinca) #451916f541d99a5] - tools: have test-asan use ubuntu-20.04 (Filip Skokan) #45581e7ed56f501] - tools: make license-builder.sh comply with shellcheck 0.8.0 (Rich Trott) #41258cc819b4bf8] - tools: fix typo inavoid-prototype-pollutionlint rule (Antoine du Hamel) #44446254358c81e] - tools: refactoravoid-prototype-pollutionlint rule (Antoine du Hamel) #434768c73279ebb] - util: add default value option to parsearg (Manuel Spigolon) #44631