Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.19.0 proposal #45791

Merged
merged 50 commits into from Dec 13, 2022
Merged

v16.19.0 proposal #45791

merged 50 commits into from Dec 13, 2022

Commits on Nov 4, 2022

  1. build: fix bad upstream merge

    The upstream merge of e27e709d3c
    accidentally removed code related to systemtap and dtrace.
    
    Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
    PR-URL: #44642
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    sgallagher authored and BethGriggs committed Nov 4, 2022
    Copy the full SHA
    03dcbe3 View commit details
    Browse the repository at this point in the history
  2. test: update list of known globals

    This is important to allow to run v16 doc tests on more recent versions.
    
    PR-URL: #45255
    Refs: https://github.com/nodejs/node/actions/runs/3356902660/jobs/5562322617
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    aduh95 authored and BethGriggs committed Nov 4, 2022
    Copy the full SHA
    499750f View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. deps: update corepack to 0.14.2

    PR-URL: #44775
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nodejs-github-bot authored and targos committed Nov 7, 2022
    Copy the full SHA
    c80cf97 View commit details
    Browse the repository at this point in the history
  2. deps: update undici to 5.11.0

    PR-URL: #44929
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and targos committed Nov 7, 2022
    Copy the full SHA
    2901abe View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. deps: update timezone

    PR-URL: #44950
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and richardlau committed Nov 21, 2022
    Copy the full SHA
    cd54bce View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. build: remove redundant condition from common.gypi

    Both paths for the condition being removed result in the same
    value being assigned to `openssl_product`. This condition was
    also problematic as it was testing a variable in the same scope
    which gyp/gyp-next currently does not support.
    
    Refs: https://gyp.gsrc.io/docs/InputFormatReference.md#user_defined-variables
    PR-URL: #45076
    Refs: nodejs/node-gyp#2750
    Refs: #38633
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    richardlau committed Nov 23, 2022
    Copy the full SHA
    ac24c80 View commit details
    Browse the repository at this point in the history
  2. deps: upgrade openssl sources to OpenSSL_1_1_1s

    This updates all sources in deps/openssl/openssl by:
        $ git clone https://github.com/quictls/openssl
        $ cd openssl
        $ git checkout OpenSSL_1_1_1s+quic
        $ cd ../node/deps/openssl
        $ rm -rf openssl
        $ cp -R ../openssl openssl
        $ rm -rf openssl/.git* openssl/.travis*
        $ git add --all openssl
        $ git commit openssl
    
    PR-URL: #45274
    Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-November/000242.html
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    RafaelGSS authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    1149ead View commit details
    Browse the repository at this point in the history
  3. deps: update archs files for OpenSSL-1.1.1s

    After an OpenSSL source update, all the config files need to be
    regenerated and committed by:
       $ make -C deps/openssl/config
       $ git add deps/openssl/config/archs
       $ git add deps/openssl/openssl/include/crypto/bn_conf.h
       $ git add deps/openssl/openssl/include/crypto/dso_conf.h
       $ git add deps/openssl/openssl/include/openssl/opensslconf.h
       $ git commit
    
    PR-URL: #45274
    Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-November/000242.html
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    RafaelGSS authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    7c0da6a View commit details
    Browse the repository at this point in the history
  4. readline: refactor to avoid unsafe regex primordials

    Refs: #43475
    Backport-PR-URL: #44926
    PR-URL: #43475
    aduh95 authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    db31de6 View commit details
    Browse the repository at this point in the history
  5. tools: refactor avoid-prototype-pollution lint rule

    The lint rule was not catching all occurences of unsafe primordials use,
    and was too strict on some methods.
    
    PR-URL: #43476
    Backport-PR-URL: #44926
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    aduh95 authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    254358c View commit details
    Browse the repository at this point in the history
  6. tools: fix typo in avoid-prototype-pollution lint rule

    PR-URL: #44446
    Backport-PR-URL: #44926
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    aduh95 authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    cc819b4 View commit details
    Browse the repository at this point in the history
  7. tools: make license-builder.sh comply with shellcheck 0.8.0

    Fixes for SC2312 added in shellcheck 0.8.0.
    
    PR-URL: #41258
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Trott authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    e7ed56f View commit details
    Browse the repository at this point in the history
  8. tools: have test-asan use ubuntu-20.04

    PR-URL: #45581
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    panva authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    6f541d9 View commit details
    Browse the repository at this point in the history
  9. cli: add --watch

    PR-URL: #44366
    Backport-PR-URL: #44976
    Fixes: #40429
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    1e0dcd1 View commit details
    Browse the repository at this point in the history
  10. test: split watch mode inspector tests to sequential

    PR-URL: #44551
    Backport-PR-URL: #44976
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    MoLow authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    97f6caf View commit details
    Browse the repository at this point in the history
  11. test: deflake watch mode tests

    PR-URL: #44621
    Backport-PR-URL: #44976
    Fixes: #44655
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    543d3d2 View commit details
    Browse the repository at this point in the history
  12. test: fix watch mode test flake

    PR-URL: #44739
    Backport-PR-URL: #44976
    Fixes: #44735
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and richardlau committed Nov 23, 2022
    Copy the full SHA
    6d736a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. deps: update undici to 5.12.0

    PR-URL: #45236
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    38202d3 View commit details
    Browse the repository at this point in the history
  2. test: fix textdecoder test for small-icu builds

    The `Shift_JIS` encoding may not be available, e.g. when Node.js is
    configured with `--with-intl=small-icu`.
    
    PR-URL: #45225
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    richardlau committed Nov 24, 2022
    Copy the full SHA
    42e9d80 View commit details
    Browse the repository at this point in the history
  3. deps: V8: cherry-pick b95354290941

    Original commit message:
    
        [extensions] Fix dcheck failures in getV8Statistics
    
        HeapObjectIterator creates a SafepointScope which requires the heap to
        allow garbage collection. This collides with the outer
        DisallowGarbageCollection scope. HeapObjectIterator already ensures
        there is no allocation during its lifetime, so there is no need to
        create an outer DisallowGarbageCollection scope.
    
        Code::source_position_table requires their kind not equals to
        CodeKind::BASELINE.
    
        This also exposes the statistics extension through flag
        --expose-statistics.
    
        Bug: v8:12657
        Change-Id: I1bf11cf499285a742dd99ec8c228ebc36152b597
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3496552
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Reviewed-by: Marja Hölttä <marja@chromium.org>
        Commit-Queue: Chengzhong Wu <legendecas@gmail.com>
        Cr-Commit-Position: refs/heads/main@{#79425}
    
    Refs: v8/v8@b953542
    PR-URL: #44947
    Refs: v8/v8@bbd800c
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    legendecas authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    af9d821 View commit details
    Browse the repository at this point in the history
  4. deps: V8: backport bbd800c6e359

    Original commit message:
    
        [heap] Fix incorrect from space committed size
    
        NewSpace page operations like RemovePage, PrependPage, and
        EnsureCurrentCapacity should account for committed page size.
    
        This may happen when a page was promoted from the new space to
        old space on mark-compact.
    
        Also, add DCHECKs on Commit and Uncommit to ensure the final
        committed page size is the same as the current state.
    
        Bug: v8:12657
        Change-Id: I7aebc1fd3f51f177ae2ef6420f757f0c573e126b
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3504766
        Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
        Commit-Queue: Chengzhong Wu <legendecas@gmail.com>
        Cr-Commit-Position: refs/heads/main@{#79426}
    
    Refs: v8/v8@bbd800c
    PR-URL: #44947
    Refs: v8/v8@b953542
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    legendecas authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    e972ff7 View commit details
    Browse the repository at this point in the history
  5. src: split property helpers from node::Environment

    PR-URL: #44056
    Backport-PR-URL: #44542
    Refs: #42528
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    legendecas authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    54608d8 View commit details
    Browse the repository at this point in the history
  6. deps: update corepack to 0.15.0

    PR-URL: #45235
    Backport-PR-URL: #45246
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    87e3d00 View commit details
    Browse the repository at this point in the history
  7. deps: update corepack to 0.15.1

    PR-URL: #45331
    Backport-PR-URL: #45246
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    9fbc8b2 View commit details
    Browse the repository at this point in the history
  8. deps: upgrade npm to 8.19.3

    PR-URL: #45322
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    npm-cli-bot authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    3b2b70d View commit details
    Browse the repository at this point in the history
  9. node-api: handle no support for external buffers

    Refs: electron/electron#35801
    Refs: nodejs/abi-stable-node#441
    
    Electron recently dropped support for external
    buffers. Provide a way for addon authors to:
    - hide the methods to create external buffers so they can
      avoid using them if they want the broadest compatibility.
    - call the methods that create external buffers at runtime
      to check if external buffers are supported and either
      use them or not based on the return code.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #45181
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    mhdawson authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    5a0efa0 View commit details
    Browse the repository at this point in the history
  10. build: support Python 3.11

    PR-URL: #45191
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    lpinca authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    cc2c764 View commit details
    Browse the repository at this point in the history
  11. tools: use Python 3.11 in GitHub Actions workflows

    PR-URL: #45191
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    lpinca authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    749a4b3 View commit details
    Browse the repository at this point in the history
  12. util: add default value option to parsearg

    Users can set a default
    value for every expected
    input argument
    
    PR-URL: #44631
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Eomm authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    8c73279 View commit details
    Browse the repository at this point in the history
  13. doc: fix typo in parseArgs default value

    Refs: #44631
    PR-URL: #45083
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    tniessen authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    c708d9b View commit details
    Browse the repository at this point in the history
  14. dgram: add dgram send queue info

    PR-URL: #44149
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    theanarkh authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    33707dc View commit details
    Browse the repository at this point in the history
  15. build: add version info to timezone update PR

    Refs: #44950 (comment)
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #45021
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RaisinTen authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    bbef3c4 View commit details
    Browse the repository at this point in the history
  16. tools: update gr2m/create-or-update-pull-request-action

    Update gr2m/create-or-update-pull-request-action to version 1.9.1.
    
    PR-URL: #45022
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lpinca authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    58c30dd View commit details
    Browse the repository at this point in the history
  17. tools: fix create-or-update-pull-request-action hash on GHA

    Refs: #45022 (comment)
    PR-URL: #45166
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    aduh95 authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    c77f660 View commit details
    Browse the repository at this point in the history
  18. test: add a test to ensure the correctness of timezone upgrades

    Currently, there's no way to know if a timezone upgrade PR is correct
    without building and testing the change locally. This change provides a
    solution for that.
    
    Tested in RaisinTen#4.
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #45299
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RaisinTen authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    197df63 View commit details
    Browse the repository at this point in the history
  19. tools: fix timezone update tool

    The spawnSync call was previously silently failing with this error:
    ```sh
    icupkg: unable to open input file "icudt*.dat"
    ```
    because spawnSync doesn't support globbing. This change replaces the
    spawnSync call with execSync because that supports globbing.
    
    I have tested this workflow with some minor modifications in my fork and
    I can confirm that it works as expected now. The bot opened this PR -
    RaisinTen#2 which updates
    deps/icu-small/source/data/in/icudt71l.dat.bz2.
    
    Fixes: #44865
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #44870
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RaisinTen authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    543493c View commit details
    Browse the repository at this point in the history
  20. tools: remove faulty early termination logic from update-timezone.mjs

    We do not build Node.js in the workflow so
    https://github.com/nodejs/node/blob/f4815fcd7691364d8139b44c1295dbc46f6ee4a8/tools/update-timezone.mjs#L18
    is actually the version of `tzdata` in the Node.js in the runner instead
    of what's in `main`.
    
    The script is pretty fast even when the versions differ and there is an
    update, so this optimization doesn't seem to be worth having given the
    problem.
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #44870
    Fixes: #44865
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RaisinTen authored and richardlau committed Nov 24, 2022
    Copy the full SHA
    891368c View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. deps: update timezone to 2022f

    PR-URL: #45613
    Refs: #45289
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    richardlau committed Dec 7, 2022
    Copy the full SHA
    5a776d4 View commit details
    Browse the repository at this point in the history
  2. test_runner: support programmatically running --test

    PR-URL: #44241
    Backport-PR-URL: #44873
    Fixes: #44023
    Fixes: #43675
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and richardlau committed Dec 7, 2022
    Copy the full SHA
    37e9092 View commit details
    Browse the repository at this point in the history
  3. test_runner: fix duration_ms to be milliseconds

    PR-URL: #44450
    Backport-PR-URL: #44873
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    MoLow authored and richardlau committed Dec 7, 2022
    Copy the full SHA
    99ee5e4 View commit details
    Browse the repository at this point in the history
  4. test_runner: support using --inspect with --test

    PR-URL: #44520
    Backport-PR-URL: #44873
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and richardlau committed Dec 7, 2022
    Copy the full SHA
    64d343a View commit details
    Browse the repository at this point in the history
  5. test: fix test-runner-inspect

    PR-URL: #44620
    Backport-PR-URL: #44873
    Fixes: #44600
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and richardlau committed Dec 7, 2022
    Copy the full SHA
    02a18ea View commit details
    Browse the repository at this point in the history
  6. cluster: use inspector utils

    PR-URL: #44592
    Backport-PR-URL: #44873
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and richardlau committed Dec 7, 2022
    Copy the full SHA
    96d1316 View commit details
    Browse the repository at this point in the history
  7. test: mark test-watch-mode* as flaky on all platforms

    This was confirmed flaky on those platforms:
    - Windows x64
    - Windows on Arm
    - Linux
    - Freebsd
    
    Tests randomly fail because of bad order in messages expected, which
    seems related to threads scheduling at execution.
    
    PR-URL: #45049
    Backport-PR-URL: #44873
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    pbo-linaro authored and richardlau committed Dec 7, 2022
    Copy the full SHA
    821d832 View commit details
    Browse the repository at this point in the history
  8. tools: update certdata.txt

    This is the certdata.txt[0] from NSS 3.85, released on 2022-11-10.
    
    This is the version of NSS that will ship in Firefox 108 on
    2022-12-13.
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_85_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: #45490
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    lpinca authored and richardlau committed Dec 7, 2022
    Copy the full SHA
    0ae5694 View commit details
    Browse the repository at this point in the history
  9. crypto: update root certificates

    Update the list of root certificates in src/node_root_certs.h with
    tools/mk-ca-bundle.pl.
    
    Certificates added:
    - Autoridad de Certificacion Firmaprofesional CIF A62634068
    - Certainly Root E1
    - Certainly Root R1
    - D-TRUST BR Root CA 1 2020
    - D-TRUST EV Root CA 1 2020
    - DigiCert TLS ECC P384 Root G5
    - DigiCert TLS RSA4096 Root G5
    - E-Tugra Global Root CA ECC v3
    - E-Tugra Global Root CA RSA v3
    - HiPKI Root CA - G1
    - ISRG Root X2
    - Security Communication ECC RootCA1
    - Security Communication RootCA3
    - Telia Root CA v2
    - vTrus ECC Root CA
    - vTrus Root CA
    
    Certificates removed:
    - Cybertrust Global Root
    - DST Root CA X3
    - GlobalSign Root CA - R2
    - Hellenic Academic and Research Institutions RootCA 2011
    
    PR-URL: #45490
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    lpinca authored and richardlau committed Dec 7, 2022
    Copy the full SHA
    7048360 View commit details
    Browse the repository at this point in the history
  10. test: add test to validate changelogs for releases

    Add a new test to check that the changelog files have been correctly
    updated for releases.
    
    PR-URL: #45325
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    richardlau committed Dec 7, 2022
    Copy the full SHA
    6733556 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. src: let http2 streams end after session close

    After the stream has been marked as closed by the nghttp2 stack, there
    might be still pending data to be sent: trailing headers is an example
    of this. In that case, avoid reentering the nghttp2 stack synchronously
    to allow the data to be written before actually closing the stream.
    
    Fixes: #42713
    PR-URL: #45153
    Backport-PR-URL: #45660
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    santigimeno authored and richardlau committed Dec 8, 2022
    Copy the full SHA
    953072d View commit details
    Browse the repository at this point in the history
  2. src: disambiguate terms used to refer to builtins and addons

    The term "native module" dates back to some of the oldest code
    in the code base. Within the context of Node.js core it usually
    refers to modules that are native to Node.js (e.g. fs, http),
    but it can cause confusion for people who don't work on this
    part of the code base, as "native module" can also refer to
    native addons - which is even the case in some of the API
    docs and error messages.
    
    This patch tries to make the usage of these terms more consistent.
    Now within the context of Node.js core:
    
    - JavaScript scripts that are built-in to Node.js are now referred
      to as "built-in(s)". If they are available as modules,
      they can also be referred to as "built-in module(s)".
    - Dynamically-linked shared objects that are loaded into
      the Node.js processes are referred to as "addons".
    
    We will try to avoid using the term "native modules" because it could
    be ambiguous.
    
    Changes in this patch:
    
    File names:
    - node_native_module.h -> node_builtins.h,
    - node_native_module.cc -> node_builtins.cc
    
    C++ binding names:
    - `native_module` -> `builtins`
    
    `node::Environment`:
    - `native_modules_without_cache` -> `builtins_without_cache`
    - `native_modules_with_cache` -> `builtins_with_cache`
    - `native_modules_in_snapshot` -> `builtins_in_cache`
    - `native_module_require` -> `builtin_module_require`
    
    `node::EnvSerializeInfo`:
    - `native_modules` -> `builtins
    
    `node::native_module::NativeModuleLoader`:
    - `native_module` namespace -> `builtins` namespace
    - `NativeModuleLoader` -> `BuiltinLoader`
    - `NativeModuleRecordMap` -> `BuiltinSourceMap`
    - `NativeModuleCacheMap` -> `BuiltinCodeCacheMap`
    - `ModuleIds` -> `BuiltinIds`
    - `ModuleCategories` -> `BuiltinCategories`
    - `LoadBuiltinModuleSource` -> `LoadBuiltinSource`
    
    `loader.js`:
    - `NativeModule` -> `BuiltinModule` (the `NativeModule` name used in
      `process.moduleLoadList` is kept for compatibility)
    
    And other clarifications in the documentation and comments.
    
    PR-URL: #44135
    Backport-PR-URL: #45663
    Fixes: #44036
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    joyeecheung authored and richardlau committed Dec 8, 2022
    Copy the full SHA
    fbc52e5 View commit details
    Browse the repository at this point in the history
  3. 2022-12-13, Version 16.19.0 'Gallium' (LTS)

    Notable changes:
    
    - OpenSSL 1.1.1s
    - Root certificates updated to NSS 3.85
    - Time zone update to 2022f
    - add dgram send queue info
    - upgrade npm to 8.19.3
    - add `--watch`
    - add default value option to parsearg
    
    PR-URL: #45791
    richardlau committed Dec 8, 2022
    Copy the full SHA
    2adea16 View commit details
    Browse the repository at this point in the history