Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: change status of event.returnvalue to legacy #46175

Merged
merged 3 commits into from Jan 19, 2023
Merged

events: change status of event.returnvalue to legacy #46175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c173711
events: change status of `event.returnvalue` to legacy
deokjinkim Jan 11, 2023
4add9b3
use cancelable to determine returnValue
deokjinkim Jan 17, 2023
e8262f6
revise description of `event.returnValue`
deokjinkim Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/api/events.md
View file
Open in desktop
Expand Up @@ -1846,8 +1846,11 @@ Sets the `defaultPrevented` property to `true` if `cancelable` is `true`.
added: v14.5.0
-->

> Stability: 3 - Legacy: Use [`event.defaultPrevented`][] instead.

* Type: {boolean} True if the event has not been canceled.

The value of `event.returnValue` is always the opposite of `event.defaultPrevented`.
This is not used in Node.js and is provided purely for completeness.

#### `event.srcElement`
Expand Down Expand Up @@ -2168,6 +2171,7 @@ to the `EventTarget`.
[`emitter.listenerCount()`]: #emitterlistenercounteventname
[`emitter.removeListener()`]: #emitterremovelistenereventname-listener
[`emitter.setMaxListeners(n)`]: #emittersetmaxlistenersn
[`event.defaultPrevented`]: #eventdefaultprevented
[`event.stopPropagation()`]: #eventstoppropagation
[`event.target`]: #eventtarget
[`events.defaultMaxListeners`]: #eventsdefaultmaxlisteners
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/event_target.js
View file
Open in desktop
Expand Up @@ -236,7 +236,7 @@ class Event {
get returnValue() {
if (!isEvent(this))
throw new ERR_INVALID_THIS('Event');
return !this.defaultPrevented;
return !this.#cancelable || !this.#defaultPrevented;
}

/**
Expand Down