Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fixed small typo error #46186

Closed
wants to merge 1 commit into from
Closed

doc: fixed small typo error #46186

wants to merge 1 commit into from

Conversation

0xflotus
Copy link
Contributor

I only fixed a small typo error. Did you mean operating system?

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 12, 2023
@0xflotus 0xflotus changed the title fix(docs): small typo error doc: fixed small typo error Jan 12, 2023
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 13, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@HarshithaKP HarshithaKP added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2023
@HarshithaKP HarshithaKP added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 16, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 16, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46186
✔  Done loading data for nodejs/node/pull/46186
----------------------------------- PR info ------------------------------------
Title      doc: fixed small typo error (#46186)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     0xflotus:patch-1 -> nodejs:main
Labels     c++, fast-track, author ready, needs-ci
Commits    1
 - fix(docs): small typo error
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/46186
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Harshitha K P 
Reviewed-By: Rich Trott 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46186
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Harshitha K P 
Reviewed-By: Rich Trott 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 12 Jan 2023 15:14:59 GMT
   ✔  Approvals: 10
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46186#pullrequestreview-1245804057
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/46186#pullrequestreview-1246014633
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46186#pullrequestreview-1246421112
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46186#pullrequestreview-1246791797
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46186#pullrequestreview-1247065309
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/46186#pullrequestreview-1247552101
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/46186#pullrequestreview-1248083475
   ✔  - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/46186#pullrequestreview-1248268643
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/46186#pullrequestreview-1248667048
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/46186#pullrequestreview-1249594547
   ℹ  This PR is being fast-tracked
   ✖  Last GitHub CI failed
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3927702123

lpinca pushed a commit that referenced this pull request Jan 22, 2023
@0xflotus @lpinca
doc: fix small typo error
a08a1fe 
PR-URL: #46186
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@lpinca
Copy link
Member

lpinca commented Jan 22, 2023

Landed in a08a1fe.

@lpinca lpinca closed this Jan 22, 2023
@0xflotus 0xflotus deleted the patch-1 branch January 23, 2023 19:51
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@0xflotus @ruyadorno
doc: fix small typo error
e2698c0 
PR-URL: #46186
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@0xflotus @juanarbol
doc: fix small typo error
1047ca2 
PR-URL: #46186
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@0xflotus @juanarbol
doc: fix small typo error
dbf082d 
PR-URL: #46186
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet