Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reduce fs-write-optional-params flakiness #46238

Merged

Conversation

LiviaMedeiros
Copy link
Contributor

Fixes: #46144

When position is null or undefined, reading starts with current file position. Closing and opening the file again between writes and reads resets current position, so the chunk is read from the start.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 17, 2023
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46238
✔  Done loading data for nodejs/node/pull/46238
----------------------------------- PR info ------------------------------------
Title      test: reduce `fs-write-optional-params` flakiness (#46238)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     LiviaMedeiros:test-fs-write-options-deflake -> nodejs:main
Labels     test, needs-ci
Commits    2
 - test: reduce `fs-write-optional-params` flakiness
 - squash: add `bytesRead === length` assertions
Committers 1
 - LiviaMedeiros 
PR-URL: https://github.com/nodejs/node/pull/46238
Fixes: https://github.com/nodejs/node/issues/46144
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46238
Fixes: https://github.com/nodejs/node/issues/46144
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 17 Jan 2023 17:50:14 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46238#pullrequestreview-1252441751
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46238#pullrequestreview-1253151886
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-01-18T12:46:47Z: https://ci.nodejs.org/job/node-test-pull-request/49039/
- Querying data for job/node-test-pull-request/49039/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 46238
From https://github.com/nodejs/node
 * branch                  refs/pull/46238/merge -> FETCH_HEAD
✔  Fetched commits as aac2dccf1ccb..e9c875dcaf53
--------------------------------------------------------------------------------
Auto-merging test/parallel/test-fs-write-optional-params.js
[main 8959026472] test: reduce `fs-write-optional-params` flakiness
 Author: LiviaMedeiros 
 Date: Wed Jan 18 01:33:55 2023 +0800
 3 files changed, 52 insertions(+), 36 deletions(-)
Auto-merging test/parallel/test-fs-write-optional-params.js
[main c6379980d8] squash: add `bytesRead === length` assertions
 Author: LiviaMedeiros 
 Date: Wed Jan 18 02:16:50 2023 +0800
 3 files changed, 3 insertions(+)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: reduce fs-write-optional-params flakiness

PR-URL: #46238
Fixes: #46144
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

[detached HEAD feba87f54c] test: reduce fs-write-optional-params flakiness
Author: LiviaMedeiros livia@cirno.name
Date: Wed Jan 18 01:33:55 2023 +0800
3 files changed, 52 insertions(+), 36 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
squash: add bytesRead === length assertions

PR-URL: #46238
Fixes: #46144
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

[detached HEAD 89d6b13a86] squash: add bytesRead === length assertions
Author: LiviaMedeiros livia@cirno.name
Date: Wed Jan 18 02:16:50 2023 +0800
3 files changed, 3 insertions(+)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/3961041112

PR-URL: nodejs#46238
Fixes: nodejs#46144
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@LiviaMedeiros LiviaMedeiros merged commit e7e1255 into nodejs:main Jan 19, 2023
@LiviaMedeiros
Copy link
Contributor Author

Landed in e7e1255

RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
PR-URL: #46238
Fixes: #46144
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
PR-URL: #46238
Fixes: #46144
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
PR-URL: #46238
Fixes: #46144
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test-fs-promises-write-optional-params does't check read bytes counts
4 participants