doc: make some parameters optional in webstreams #46269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some parameters are described as optional in spec, so update mismatched parameter. Refs: https://streams.spec.whatwg.org/
aduh95
changed the title
aduh95
approved these changes
Jan 19, 2023
aduh95
added
doc
lpinca
approved these changes
Jan 20, 2023
lpinca
added
the
commit-queue
14 tasks
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46269 ✔ Done loading data for nodejs/node/pull/46269 ----------------------------------- PR info ------------------------------------ Title doc: make some parameters optional in webstreams (#46269) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:230119_webstreams_make_optional -> nodejs:main Labels doc, author ready, web streams Commits 1 - doc,lib: make some parameters optional in webstreams Committers 1 - Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/46269 Refs: https://streams.spec.whatwg.org/ Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46269 Refs: https://streams.spec.whatwg.org/ Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 19 Jan 2023 10:42:41 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46269#pullrequestreview-1261604583 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46269#pullrequestreview-1263226587 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2023-01-20T09:40:59Z: https://ci.nodejs.org/job/node-test-pull-request/49102/ - Querying data for job/node-test-pull-request/49102/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3974461802 |
|
Landed in 05296d9 |
This was referenced Jan 22, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
Some parameters are described as optional in spec, so update mismatched parameter. Refs: https://streams.spec.whatwg.org/ PR-URL: #46269 Refs: https://streams.spec.whatwg.org/ Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
Some parameters are described as optional in spec, so update mismatched parameter. Refs: https://streams.spec.whatwg.org/ PR-URL: #46269 Refs: https://streams.spec.whatwg.org/ Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
Some parameters are described as optional in spec, so update mismatched parameter. Refs: https://streams.spec.whatwg.org/ PR-URL: #46269 Refs: https://streams.spec.whatwg.org/ Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
deokjinkim
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parameters are described as optional in spec, so update mismatched parameter.
Refs: https://streams.spec.whatwg.org/