test: avoid left behind child processes #46276
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified.
MoLow
approved these changes
Jan 19, 2023
This comment was marked as outdated.
This comment was marked as outdated.
BethGriggs
approved these changes
Jan 19, 2023
ruyadorno
approved these changes
Jan 19, 2023
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Jan 19, 2023
13 tasks
richardlau
added
the
author ready
lpinca
approved these changes
Jan 20, 2023
lpinca
added
the
commit-queue
targos
approved these changes
Jan 20, 2023
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46276 ✔ Done loading data for nodejs/node/pull/46276 ----------------------------------- PR info ------------------------------------ Title test: avoid left behind child processes (#46276) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch richardlau:cpexecac -> nodejs:main Labels test, fast-track, author ready, needs-ci, lts-watch-v14.x, lts-watch-v16.x Commits 1 - test: avoid left behind child processes Committers 1 - Richard Lau PR-URL: https://github.com/nodejs/node/pull/46276 Fixes: https://github.com/nodejs/build/issues/3154 Refs: https://github.com/nodejs/node/issues/37518 Reviewed-By: Moshe Atlow Reviewed-By: Beth Griggs Reviewed-By: Ruy Adorno Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46276 Fixes: https://github.com/nodejs/build/issues/3154 Refs: https://github.com/nodejs/node/issues/37518 Reviewed-By: Moshe Atlow Reviewed-By: Beth Griggs Reviewed-By: Ruy Adorno Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 19 Jan 2023 16:48:37 GMT ✔ Approvals: 7 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/46276#pullrequestreview-1262194862 ✔ - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/46276#pullrequestreview-1262204146 ✔ - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/46276#pullrequestreview-1262207413 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46276#pullrequestreview-1262429139 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46276#pullrequestreview-1263218104 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/46276#pullrequestreview-1263219222 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/46276#pullrequestreview-1264226655 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-01-19T23:07:22Z: https://ci.nodejs.org/job/node-test-pull-request/49094/ - Querying data for job/node-test-pull-request/49094/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3970755114 |
RafaelGSS
approved these changes
Jan 20, 2023
14 tasks
jasnell
approved these changes
Jan 21, 2023
13 tasks
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2df72fe |
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Jan 22, 2023
Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: nodejs#46276 Fixes: nodejs/build#3154 Refs: nodejs#37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau
added a commit
that referenced
this pull request
Jan 22, 2023
Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: #46276 Fixes: nodejs/build#3154 Refs: #37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 23, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: #46276 Fixes: nodejs/build#3154 Refs: #37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: #46276 Fixes: nodejs/build#3154 Refs: #37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: #46276 Fixes: nodejs/build#3154 Refs: #37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
oraluben
pushed a commit
to oraluben/node
that referenced
this pull request
Mar 14, 2023
Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: nodejs/node#46276 Fixes: nodejs/build#3154 Refs: nodejs/node#37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
oraluben
pushed a commit
to oraluben/node
that referenced
this pull request
Mar 17, 2023
Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: nodejs/node#46276 Fixes: nodejs/build#3154 Refs: nodejs/node#37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the Linux logic in test-child-process-exec-abortcontroller-promisified to all POSIX platforms.
Fixes: nodejs/build#3154
Refs: #37572 (comment)
Refs: #37518
This unblocks the SmartOS CI for Node.js 14 and 16 that has been failing since we migrated the smartos machines at the end of last year. I'm opening this on main (which hasn't been failing) so I can cherry pick the same fix to both v16.x-staging and v14.x-staging. My main aim here is to unblock the CI.
To clarify, the test itself passes but is leaving behind child processes, which cause the CI run to fail as it checks for left over
nodeprocesses at the end of the test run.cc @nodejs/releasers @bahamat