Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix logInTimeout is not function #46348

Merged
merged 1 commit into from Jan 28, 2023
Merged

test: fix logInTimeout is not function #46348

merged 1 commit into from Jan 28, 2023

Conversation

theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Jan 25, 2023 •
edited

fix logInTimeout is not function in test-child-process-exec-timeout-kill.js.
cc @joyeecheung
Refs: #44390

The error is as follows.

[stdout]
[stderr] /home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-child-process-exec-timeout-kill.js:17
  logInTimeout(kExpiringChildRunTime);
  ^

TypeError: logInTimeout is not a function
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-child-process-exec-timeout-kill.js:17:3)
    at Module._compile (node:internal/modules/cjs/loader:1246:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1300:10)
    at Module.load (node:internal/modules/cjs/loader:1103:32)
    at Module._load (node:internal/modules/cjs/loader:942:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 25, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2023
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49193/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49207/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49209/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49211/

@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4076418 into nodejs:main Jan 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4076418

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@theanarkh @ruyadorno
test: fix logInTimeout is not function
d5d837b 
PR-URL: #46348
Refs: #44390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@theanarkh @juanarbol
test: fix logInTimeout is not function
81465d6 
PR-URL: #46348
Refs: #44390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@theanarkh @juanarbol
test: fix logInTimeout is not function
31fdd93 
PR-URL: #46348
Refs: #44390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@theanarkh @juanarbol
test: fix logInTimeout is not function
ed3fb52 
PR-URL: #46348
Refs: #44390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@theanarkh @nodejs-github-bot @lpinca @anonrig @richardlau