doc: add tip for session.post function #46354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
theanarkh
force-pushed
the
add_tips_for_post_function_in_inspector
branch
from
64c8567
to
7f5d20d
Compare
bnoordhuis
reviewed
Jan 26, 2023
theanarkh
force-pushed
the
add_tips_for_post_function_in_inspector
branch
from
7f5d20d
to
82d992f
Compare
theanarkh
force-pushed
the
add_tips_for_post_function_in_inspector
branch
from
82d992f
to
5d90855
Compare
bnoordhuis
approved these changes
Jan 27, 2023
theanarkh
added
the
fast-track
|
Fast-track has been requested by @theanarkh. Please 👍 to approve. |
lpinca
approved these changes
Jan 27, 2023
theanarkh
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46354 ✔ Done loading data for nodejs/node/pull/46354 ----------------------------------- PR info ------------------------------------ Title doc: add tip for session.post function (#46354) Author theanarkh (@theanarkh) Branch theanarkh:add_tips_for_post_function_in_inspector -> nodejs:main Labels doc, inspector, fast-track Commits 1 - doc: add tip for session.post function Committers 1 - theanarkh PR-URL: https://github.com/nodejs/node/pull/46354 Refs: https://github.com/nodejs/node/issues/44634 Reviewed-By: Ben Noordhuis Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46354 Refs: https://github.com/nodejs/node/issues/44634 Reviewed-By: Ben Noordhuis Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 26 Jan 2023 02:36:59 GMT ✔ Approvals: 2 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/46354#pullrequestreview-1272345252 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46354#pullrequestreview-1273384786 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4029815905 |
theanarkh
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46354 ✔ Done loading data for nodejs/node/pull/46354 ----------------------------------- PR info ------------------------------------ Title doc: add tip for session.post function (#46354) Author theanarkh (@theanarkh) Branch theanarkh:add_tips_for_post_function_in_inspector -> nodejs:main Labels doc, inspector, fast-track Commits 1 - doc: add tip for session.post function Committers 1 - theanarkh PR-URL: https://github.com/nodejs/node/pull/46354 Refs: https://github.com/nodejs/node/issues/44634 Reviewed-By: Ben Noordhuis Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46354 Refs: https://github.com/nodejs/node/issues/44634 Reviewed-By: Ben Noordhuis Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 26 Jan 2023 02:36:59 GMT ✔ Approvals: 2 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/46354#pullrequestreview-1272345252 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46354#pullrequestreview-1273384786 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4034813395 |
theanarkh
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0a46107 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set
reportProgresstotruewhen postHeapProfiler.takeHeapSnapshotorHeapProfiler.stopTrackingHeapObjectscommand to V8.cc @bnoordhuis
Refs: #44634
make -j4 test(UNIX), orvcbuild test(Windows) passes