doc: pass string to textEncoder.encode as input
#46421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input of `textEncoder.encode` should be string, not array. Refs: https://nodejs.org/dist/latest-v19.x/docs/api/util.html#textencoderencodeinput
cjihrig
approved these changes
Jan 30, 2023
aduh95
approved these changes
Jan 30, 2023
aduh95
added
fast-track
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
lpinca
approved these changes
Jan 30, 2023
addaleax
approved these changes
Jan 30, 2023
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a5fd53f |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
Input of `textEncoder.encode` should be string, not array. Refs: https://nodejs.org/dist/latest-v19.x/docs/api/util.html#textencoderencodeinput PR-URL: #46421 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
Input of `textEncoder.encode` should be string, not array. Refs: https://nodejs.org/dist/latest-v19.x/docs/api/util.html#textencoderencodeinput PR-URL: #46421 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
Input of `textEncoder.encode` should be string, not array. Refs: https://nodejs.org/dist/latest-v19.x/docs/api/util.html#textencoderencodeinput PR-URL: #46421 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
Input of `textEncoder.encode` should be string, not array. Refs: https://nodejs.org/dist/latest-v19.x/docs/api/util.html#textencoderencodeinput PR-URL: #46421 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input of
textEncoder.encodeshould be string, not array.Refs: https://nodejs.org/dist/latest-v19.x/docs/api/util.html#textencoderencodeinput