Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: fix validation of "Link" header #46466

Merged
merged 6 commits into from
Feb 23, 2023
Merged

http: fix validation of "Link" header #46466

merged 6 commits into from
Feb 23, 2023

Commits on Feb 17, 2023

  1. http: fix validation of "Link" header 

    Updated regex for "Link" header validation to better match the
specification in RFC 8288 section 3. Does not check for valid URI
format but handles the rest of the header more permissively than
before. Alternative to another outstanding PR that disables validation
entirely.

Fixes: nodejs#46453
Refs: https://www.rfc-editor.org/rfc/rfc8288.html#section-3
Refs: nodejs#46464
    @SRHerzog
    SRHerzog committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    9947fd9 View commit details
    Browse the repository at this point in the history

  2. revert error message, improve regex, add test

    @SRHerzog
    SRHerzog committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    a0281cf View commit details
    Browse the repository at this point in the history

  3. minor test refactor

    @SRHerzog
    SRHerzog committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    88eaafd View commit details
    Browse the repository at this point in the history

  4. update tests and comments

    @SRHerzog
    SRHerzog committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    e24f2fd View commit details
    Browse the repository at this point in the history

  5. remove redundant test

    @SRHerzog
    SRHerzog committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    2327a58 View commit details
    Browse the repository at this point in the history

  6. fix overlong string

    @SRHerzog
    SRHerzog committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8c49924 View commit details
    Browse the repository at this point in the history