Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: better handle async bootstrap errors #46720

Merged
merged 2 commits into from
Feb 24, 2023
Merged

test_runner: better handle async bootstrap errors #46720

merged 2 commits into from
Feb 24, 2023

Commits on Feb 24, 2023

  1. test_runner: better handle async bootstrap errors 

    The test runner is bootstrapped synchronously, with the exception
of importing custom reporters. To better handle asynchronously
throw errors, this commit introduces an internal error type that
can be checked for from the test runner's uncaughtException
handler.

After nodejs#46707 and this change
land, the other throw statement in the uncaughtException handler
can be removed. This will allow the test runner to handle errors
thrown from outside of tests (which currently prevents the test
runner from reporting results).
    @cjihrig
    cjihrig committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    7f84bb0 View commit details
    Browse the repository at this point in the history

  2. fixup! test_runner: better handle async bootstrap errors

    @cjihrig
    cjihrig committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    59b149d View commit details
    Browse the repository at this point in the history