test_runner: better handle async bootstrap errors

[cjihrig]

The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's 'uncaughtException' handler.

After #46707 and this change land, the other throw statement in the 'uncaughtException' handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results).

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[aduh95]

nit: we should probably only catch async errors, and not errors that might happen in the for loop.

Suggested change

	try {
	const reportersMap = await getReportersMap(reporters, destinations);
	for (let i = 0; i < reportersMap.length; i++) {
	const { reporter, destination } = reportersMap[i];
	compose(testsStream, reporter).pipe(destination);
	}
	} catch (err) {
	throw new ERR_TEST_FAILURE(err, kAsyncBootstrapFailure);
	const reportersMap = await PromisePrototypeThen(
	getReportersMap(reporters, destinations), undefined,
	(err) => PromiseReject(new ERR_TEST_FAILURE(err, kAsyncBootstrapFailure)),
	);
	for (let i = 0; i < reportersMap.length; i++) {
	const { reporter, destination } = reportersMap[i];
	compose(testsStream, reporter).pipe(destination);

or

Suggested change

	try {
	const reportersMap = await getReportersMap(reporters, destinations);
	for (let i = 0; i < reportersMap.length; i++) {
	const { reporter, destination } = reportersMap[i];
	compose(testsStream, reporter).pipe(destination);
	}
	} catch (err) {
	throw new ERR_TEST_FAILURE(err, kAsyncBootstrapFailure);
	let reportersMap;
	try {
	reportersMap = await getReportersMap(reporters, destinations);
	} catch(err) {
	throw new ERR_TEST_FAILURE(err, kAsyncBootstrapFailure);
	}
	for (let i = 0; i < reportersMap.length; i++) {
	const { reporter, destination } = reportersMap[i];
	compose(testsStream, reporter).pipe(destination);

[cjihrig]

By the time this code is reached, getReportersMap() has made everything async from the test runner's point of view.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49804/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49965/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49966/ 🟡

[nodejs-github-bot]

Landed in 0c90be9