Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: create weakRef only if any signals provided #48448

Merged
merged 1 commit into from
Jun 15, 2023
Merged

lib: create weakRef only if any signals provided #48448

merged 1 commit into from
Jun 15, 2023

Conversation

atlowChemi
Copy link
Member

Fixes: #48419

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 13, 2023
@atlowChemi atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from b74da91 to f70772d Compare June 13, 2023 12:48
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52238/

@atlowChemi atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from f70772d to 26d8fbe Compare June 13, 2023 13:48
@atlowChemi atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from 26d8fbe to 6cb4ad9 Compare June 13, 2023 14:18
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52240/

@atlowChemi atlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52243/

@github-actions github-actions bot mentioned this pull request Jun 14, 2023
Open
20 tasks
@atlowChemi atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 14, 2023
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Open
22 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2023
@nodejs-github-bot nodejs-github-bot merged commit f3ee4e2 into nodejs:main Jun 15, 2023
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f3ee4e2

@atlowChemi atlowChemi deleted the lib--create-weakRef-only-if-any-signals-provided branch June 15, 2023 12:56
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
Open
29 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@atlowChemi @RafaelGSS
lib: create weakRef only if any signals provided
8c2c02d 
PR-URL: #48448
Fixes: #48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
@atlowChemi atlowChemi mentioned this pull request Jul 16, 2023
Closed
atlowChemi added a commit to atlowChemi/node that referenced this pull request Jul 17, 2023
@atlowChemi
lib: create weakRef only if any signals provided
a30ecab 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
@atlowChemi @danielleadams
lib: create weakRef only if any signals provided
156292d 
PR-URL: #48448
Backport-PR-URL: #48800
Fixes: #48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Jul 17, 2023
@danielleadams danielleadams mentioned this pull request Jul 18, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
lib: create weakRef only if any signals provided
4198d5c 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
lib: create weakRef only if any signals provided
30b380c 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linkgoron Linkgoron Linkgoron approved these changes

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AbortSignal.any() not destroyed when goes out of scope
7 participants
@atlowChemi @nodejs-github-bot @Linkgoron @lpinca @MoLow @aduh95 @danielleadams