Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: remove default encoding from Hash/Hmac #49167

Merged
merged 1 commit into from Aug 16, 2023
Merged

crypto: remove default encoding from Hash/Hmac #49167

merged 1 commit into from Aug 16, 2023

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Aug 14, 2023 •
edited

getDefaultEncoding() always returns 'buffer' in Node.js 20. It requires some careful justification but the default encoding can be eliminated from hash.js entirely. The reasoning is almost identical with that in #49145 so I won't repeat it here. The main thing to note here is that digest() conveniently defaults to BUFFER for falsy encodings.

This partially addresses:

node/lib/internal/crypto/util.js

Lines 77 to 80 in af9b48a

// TODO(tniessen): remove all call sites and this function
function getDefaultEncoding() {
return 'buffer';
}

Refs: #47182

@tniessen
crypto: remove default encoding from Hash/Hmac
c8d479a 
getDefaultEncoding() always returns 'buffer' in Node.js 20. It requires
some careful justification but the default encoding can be eliminated
from hash.js entirely. The reasoning is almost identical with that in
nodejs#49145 so I won't repeat it here.

Refs: nodejs#47182
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Aug 14, 2023
@tniessen tniessen added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Aug 14, 2023
tniessen added a commit to tniessen/node that referenced this pull request Aug 14, 2023
@tniessen
crypto: remove getDefaultEncoding()
d66373c 
Refs: nodejs#47182
Refs: nodejs#47869
Refs: nodejs#47943
Refs: nodejs#47998
Refs: nodejs#49140
Refs: nodejs#49145
Refs: nodejs#49167
Refs: nodejs#49169
@tniessen tniessen mentioned this pull request Aug 14, 2023
Closed
@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53329/

@github-actions github-actions bot mentioned this pull request Aug 15, 2023
Open
22 tasks
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2023
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Open
24 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 16, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8ed4397 into nodejs:main Aug 16, 2023
71 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8ed4397

tniessen added a commit to tniessen/node that referenced this pull request Aug 16, 2023
@tniessen
crypto: remove getDefaultEncoding()
d4a91a8 
Refs: nodejs#47182
Refs: nodejs#47869
Refs: nodejs#47943
Refs: nodejs#47998
Refs: nodejs#49140
Refs: nodejs#49145
Refs: nodejs#49167
Refs: nodejs#49169
This was referenced Aug 17, 2023
Open
Open
debadree25 pushed a commit that referenced this pull request Aug 19, 2023
@tniessen @debadree25
crypto: remove getDefaultEncoding()
78842cf 
Refs: #47182
Refs: #47869
Refs: #47943
Refs: #47998
Refs: #49140
Refs: #49145
Refs: #49167
Refs: #49169
PR-URL: #49170
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@tniessen @UlisesGascon
crypto: remove default encoding from Hash/Hmac
c795083 
getDefaultEncoding() always returns 'buffer' in Node.js 20. It requires
some careful justification but the default encoding can be eliminated
from hash.js entirely. The reasoning is almost identical with that in
#49145 so I won't repeat it here.

Refs: #47182
PR-URL: #49167
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@tniessen @UlisesGascon
crypto: remove getDefaultEncoding()
7eb10a3 
Refs: #47182
Refs: #47869
Refs: #47943
Refs: #47998
Refs: #49140
Refs: #49145
Refs: #49167
Refs: #49169
PR-URL: #49170
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tniessen @nodejs-github-bot @panva @anonrig