Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: unflag ES modules without file extension within module scope #49629

Closed
wants to merge 4 commits into from
Closed

module: unflag ES modules without file extension within module scope #49629

wants to merge 4 commits into from

Conversation

LiviaMedeiros
Copy link
Contributor

This is unflagged version of #49531.

This can be landed instead of #49531 if we don't want --experimental-extensionless-modules flag at all; or this can become semver-major PRs that contain breaking changes and should be released in the next major version. follow-up that unflags that; depending on the consensus made in #49531.

CI: https://ci.nodejs.org/job/node-test-pull-request/53831/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3220/
(both were triggered for 500ea04)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 12, 2023
@LiviaMedeiros LiviaMedeiros added semver-major PRs that contain breaking changes and should be released in the next major version. blocked PRs that are blocked by other issues or PRs. errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. and removed errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 12, 2023
@LiviaMedeiros LiviaMedeiros mentioned this pull request Sep 13, 2023
Closed
This was referenced Sep 13, 2023
Closed
Closed
This was referenced Sep 19, 2023
Closed
Closed
@GeoffreyBooth GeoffreyBooth mentioned this pull request Sep 26, 2023
Merged
@RafaelGSS RafaelGSS added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Sep 27, 2023
@RafaelGSS
Copy link
Member

As discussed in today's TSC meeting, I'm adding dont-land-on-v20 and dont-land-on-v18 labels.

@LiviaMedeiros LiviaMedeiros added semver-minor PRs that contain new features and should be released in the next minor version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Sep 28, 2023
@GeoffreyBooth GeoffreyBooth mentioned this pull request Sep 30, 2023
Closed
@GeoffreyBooth
Copy link
Member

Closing now that #49974 has landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LiviaMedeiros @nodejs-github-bot @RafaelGSS @GeoffreyBooth