esm: unflag extensionless ES module JavaScript and Wasm in module scope #49974

GeoffreyBooth · 2023-09-30T05:30:14Z

This includes work by @LiviaMedeiros in #49531, #49629, and #49540.

Following up from #49869, this PR allows extensionless ESM JavaScript and Wasm files within "type": "module" package scopes to run as entry points or be imported. This can be done as a semver-minor change because currently such files error when they are within a module scope. (Outside of such a scope, they are interpreted as CommonJS modules unless --experimental-default-type=module is passed.)

This was discussed in the most recent TSC meeting, nodejs/TSC#1442. At that meeting it was agreed that this change could go out in 21.0.0, but not immediately in 20.x or below. It doesn’t need to be restricted from 20.x indefinitely, but there was a request to hold off on backporting it to 20.x until it had been public in 21.x for a bit. I’ve added labels accordingly.

@nodejs/loaders @nodejs/wasi

nodejs-github-bot · 2023-09-30T05:30:19Z

Review requested:

@nodejs/loaders

LiviaMedeiros

RSLGTM

nodejs-github-bot · 2023-09-30T08:06:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54400/

shrujalshah28 · 2023-09-30T13:55:39Z

Maybe add baking-for-lts PRs that need to wait before landing in a LTS release. ?

nodejs-github-bot · 2023-09-30T14:21:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54409/

nodejs-github-bot · 2023-09-30T16:04:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54414/

GeoffreyBooth · 2023-09-30T23:54:32Z

Maybe add baking-for-lts PRs that need to wait before landing in a LTS release. ?

That’s a good idea, I assume I should use that without the dont-land ones?

GeoffreyBooth · 2023-10-02T02:46:31Z

@LiviaMedeiros or someone else, do you want to approve this? Then it can land.

guybedford

The lookup logic all looks correct to me.

lib/internal/errors.js

lib/internal/modules/esm/get_format.js

GeoffreyBooth · 2023-10-03T01:43:37Z

@LiviaMedeiros can you please approve if this looks good to you? I can’t land without a new approval after the most recent commits.

nodejs-github-bot · 2023-10-03T02:44:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54480/

PR-URL: #49974 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

LiviaMedeiros · 2023-10-03T04:33:38Z

Landed in 9c68320

PR-URL: nodejs#49974 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #49974 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: nodejs#49974 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #49974 Backport-PR-URL: #50669 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

nodejs/node#49974

* chore: bump node in DEPS to v20.10.0 * chore: update feat_initialize_asar_support.patch no code changes; patch just needed an update due to nearby upstream changes Xref: nodejs/node#49986 * chore: update pass_all_globals_through_require.patch no manual changes; patch applied with fuzz Xref: nodejs/node#49657 * chore: update refactor_allow_embedder_overriding_of_internal_fs_calls Xref: nodejs/node#49912 no code changes; patch just needed an update due to nearby upstream changes * chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch Xref: nodejs/node#49986 minor manual changes needed to sync with upstream change * update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#50096 Xref: nodejs/node#50314 in lib/internal/modules/esm/load.js, update the code that checks for `format === 'electron'`. I'd like 👀 on this Xref: nodejs/node#49657 add braces in lib/internal/modules/esm/translators.js to sync with upstream * fix: lazyload fs in esm loaders to apply asar patches * nodejs/node#50127 * nodejs/node#50096 * esm: jsdoc for modules code nodejs/node#49523 * test: set test-cli-node-options as flaky nodejs/node#50296 * deps: update c-ares to 1.20.1 nodejs/node#50082 * esm: bypass CommonJS loader under --default-type=module nodejs/node#49986 * deps: update uvwasi to 0.0.19 nodejs/node#49908 * lib,test: do not hardcode Buffer.kMaxLength nodejs/node#49876 * crypto: account for disabled SharedArrayBuffer nodejs/node#50034 * test: fix edge snapshot stack traces nodejs/node#49659 * src: generate snapshot with --predictable nodejs/node#48749 * chore: fixup patch indices * fs: throw errors from sync branches instead of separate implementations nodejs/node#49913 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * esm: detect ESM syntax in ambiguous JavaScrip nodejs/node#50096 * fixup! test: fix edge snapshot stack traces * esm: unflag extensionless ES module JavaScript and Wasm in module scope nodejs/node#49974 * [tagged-ptr] Arrowify objects https://chromium-review.googlesource.com/c/v8/v8/+/4705331 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

PR-URL: nodejs#49974 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: nodejs/node#49974 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

esm: unflag extensionless javascript and wasm in module scope

4cb52aa

GeoffreyBooth requested a review from LiviaMedeiros September 30, 2023 05:30

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Sep 30, 2023

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2023

LiviaMedeiros reviewed Sep 30, 2023

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2023

benjamingr approved these changes Sep 30, 2023

View reviewed changes

github-actions bot mentioned this pull request Oct 1, 2023

CI Reliability 2023-10-01 nodejs/reliability#680

Open

16 tasks

GeoffreyBooth mentioned this pull request Oct 1, 2023

import-in-the-middle failing on Node.js main branch nodejs/citgm#995

Open

github-actions bot mentioned this pull request Oct 2, 2023

CI Reliability 2023-10-02 nodejs/reliability#681

Open

12 tasks

guybedford approved these changes Oct 2, 2023

View reviewed changes

targos reviewed Oct 2, 2023

View reviewed changes

lib/internal/errors.js Outdated Show resolved Hide resolved

targos approved these changes Oct 2, 2023

View reviewed changes

LiviaMedeiros reviewed Oct 2, 2023

View reviewed changes

lib/internal/modules/esm/get_format.js Outdated Show resolved Hide resolved

Simplify error

f2ae2d7

GeoffreyBooth added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 3, 2023

LiviaMedeiros self-assigned this Oct 3, 2023

LiviaMedeiros closed this Oct 3, 2023

GeoffreyBooth deleted the extensionless-in-module-scope branch October 3, 2023 05:08

RafaelGSS mentioned this pull request Oct 9, 2023

2023-10-17, Version 21.0.0 (Current) #49870

Merged

Mouvedia mentioned this pull request Nov 7, 2023

Fix incorrect main field in package.json stylelint/stylelint#7308

Merged

targos mentioned this pull request Nov 11, 2023

[v18.x] Backport most ESM and customization hook changes #50669

Closed

targos mentioned this pull request Nov 12, 2023

v20.10.0 release proposal #50682

Merged

targos added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed baking-for-lts PRs that need to wait before landing in a LTS release. labels Nov 23, 2023

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

juanarbol mentioned this pull request Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

codebytere added a commit to electron/electron that referenced this pull request Dec 11, 2023

esm: unflag extensionless ES module JavaScript and Wasm in module scope

3bfa548

nodejs/node#49974

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

esm: unflag extensionless ES module JavaScript and Wasm in module scope #49974

esm: unflag extensionless ES module JavaScript and Wasm in module scope #49974

GeoffreyBooth commented Sep 30, 2023

nodejs-github-bot commented Sep 30, 2023

LiviaMedeiros left a comment

nodejs-github-bot commented Sep 30, 2023

shrujalshah28 commented Sep 30, 2023

nodejs-github-bot commented Sep 30, 2023

nodejs-github-bot commented Sep 30, 2023

GeoffreyBooth commented Sep 30, 2023

GeoffreyBooth commented Oct 2, 2023

guybedford left a comment

GeoffreyBooth commented Oct 3, 2023

nodejs-github-bot commented Oct 3, 2023

LiviaMedeiros commented Oct 3, 2023

esm: unflag extensionless ES module JavaScript and Wasm in module scope #49974

esm: unflag extensionless ES module JavaScript and Wasm in module scope #49974

Conversation

GeoffreyBooth commented Sep 30, 2023

nodejs-github-bot commented Sep 30, 2023

LiviaMedeiros left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Sep 30, 2023

shrujalshah28 commented Sep 30, 2023

nodejs-github-bot commented Sep 30, 2023

nodejs-github-bot commented Sep 30, 2023

GeoffreyBooth commented Sep 30, 2023

GeoffreyBooth commented Oct 2, 2023

guybedford left a comment

Choose a reason for hiding this comment

GeoffreyBooth commented Oct 3, 2023

nodejs-github-bot commented Oct 3, 2023

LiviaMedeiros commented Oct 3, 2023