test: report ERROR wpt test results #50429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
legendecas
force-pushed
the
wpt/report
branch
2 times, most recently
from
780117a
to
111c759
Compare
|
@panva It would be great if you could take a look at this when you get a chance since you originally created wpt.fyi report workflow. Thank you! |
|
I believe it should just be the harness that has an error and then no tests in it, like so https://wpt.fyi/results/streams/readable-byte-streams/construct-byob-request.any.html?run_id=5105883752693760&run_id=5146271209226240&run_id=5855453021470720&run_id=5148705381941248&run_id=6261279079006208 Same for timeout in our case. |
|
Right. I've removed the synthetic sub-tests from the report to wpt.fyi. Thanks for the suggestion. |
|
I'll re-run the upload tonight to check what it looks like now. |
|
The evaluation in WPTRunner.runJsTests() looks alright now, it's gone. But why is there a newly added for entry for all |
When a wpt test file is exited for uncaught error, its result should be recorded in the `wptreport.json` and uploaded to wpt.fyi. For instance, `html/webappapis/timers/evil-spec-example.any.js` is exited for uncaught error in Node.js but it shows as "MISSING" at https://wpt.fyi/results/html/webappapis/timers?label=master&label=experimental&product=chrome&product=node.js&aligned.
legendecas
force-pushed
the
wpt/report
branch
from
9e65978
to
e842497
Compare
|
Well, it seems a completion with error status was not recognized as a failed test and it was not reported to wpt.fyi. Fixed with e842497. |
panva
approved these changes
Oct 30, 2023
legendecas
added
commit-queue-rebase
github-actions
bot
removed
the
request-ci
panva
added
the
author ready
24 tasks
This was referenced Nov 2, 2023
legendecas
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50429 ✔ Done loading data for nodejs/node/pull/50429 ----------------------------------- PR info ------------------------------------ Title test: report ERROR wpt test results (#50429) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:wpt/report -> nodejs:main Labels test, author ready, needs-ci, commit-queue-rebase Commits 2 - test: report error wpt test results - test: recognize wpt completion error Committers 1 - legendecas PR-URL: https://github.com/nodejs/node/pull/50429 Reviewed-By: Filip Skokan ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50429 Reviewed-By: Filip Skokan -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 27 Oct 2023 15:23:01 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/50429#pullrequestreview-1704170475 ✘ This PR needs to wait 0 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-11-01T06:12:59Z: https://ci.nodejs.org/job/node-test-pull-request/55378/ - Querying data for job/node-test-pull-request/55378/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6746717439 |
legendecas
removed
the
commit-queue-failed
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in fd2368e...a00f0b1 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
When a wpt test file is exited for uncaught error, its result should be recorded in the `wptreport.json` and uploaded to wpt.fyi. For instance, `html/webappapis/timers/evil-spec-example.any.js` is exited for uncaught error in Node.js but it shows as "MISSING" at https://wpt.fyi/results/html/webappapis/timers?label=master&label=experimental&product=chrome&product=node.js&aligned. PR-URL: #50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
PR-URL: #50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
14 tasks
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Nov 9, 2023
When a wpt test file is exited for uncaught error, its result should be recorded in the `wptreport.json` and uploaded to wpt.fyi. For instance, `html/webappapis/timers/evil-spec-example.any.js` is exited for uncaught error in Node.js but it shows as "MISSING" at https://wpt.fyi/results/html/webappapis/timers?label=master&label=experimental&product=chrome&product=node.js&aligned. PR-URL: nodejs#50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Nov 9, 2023
PR-URL: nodejs#50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
When a wpt test file is exited for uncaught error, its result should be recorded in the `wptreport.json` and uploaded to wpt.fyi. For instance, `html/webappapis/timers/evil-spec-example.any.js` is exited for uncaught error in Node.js but it shows as "MISSING" at https://wpt.fyi/results/html/webappapis/timers?label=master&label=experimental&product=chrome&product=node.js&aligned. PR-URL: #50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
When a wpt test file is exited for uncaught error, its result should be recorded in the `wptreport.json` and uploaded to wpt.fyi. For instance, `html/webappapis/timers/evil-spec-example.any.js` is exited for uncaught error in Node.js but it shows as "MISSING" at https://wpt.fyi/results/html/webappapis/timers?label=master&label=experimental&product=chrome&product=node.js&aligned. PR-URL: #50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
PR-URL: #50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
When a wpt test file is exited for uncaught error, its result should be recorded in the `wptreport.json` and uploaded to wpt.fyi. For instance, `html/webappapis/timers/evil-spec-example.any.js` is exited for uncaught error in Node.js but it shows as "MISSING" at https://wpt.fyi/results/html/webappapis/timers?label=master&label=experimental&product=chrome&product=node.js&aligned. PR-URL: #50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a wpt test file is exited for uncaught error, its result should be
recorded in the
wptreport.jsonand uploaded to wpt.fyi.For instance,
html/webappapis/timers/evil-spec-example.any.jsisexited for uncaught error in Node.js but it shows as "MISSING" at
https://wpt.fyi/results/html/webappapis/timers?label=master&label=experimental&product=chrome&product=node.js&aligned.