Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't polyfill stream in webpack.browser.config.mjs #517

Closed
wants to merge 5 commits into from

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented May 13, 2023

This PR does 2 things:

@jeswr
Copy link
Contributor Author

jeswr commented May 13, 2023

Was expecting Webpacking to fail with this change. Will investigate by Monday at the latest.

@jeswr jeswr marked this pull request as draft May 14, 2023 15:53
@jeswr jeswr marked this pull request as ready for review May 14, 2023 16:15
@jeswr
Copy link
Contributor Author

jeswr commented May 14, 2023

Should be ready to go now @mcollina (I don't have permissions to mark you as a reviewer so pinging you instead).

The CI for Webpacking is failing (as expected), and should pass again once #516 is solved.

@mcollina
Copy link
Member

I thought it was a simple fix, but it's actually harder than the time I currently have available to fix it. @jeswr would you mind to identify a fix?

@ShogunPanda could you take a look as well?

@jeswr
Copy link
Contributor Author

jeswr commented May 15, 2023

Unfortunately I'm quite time poor myself at present @mcollina, so it is unlikely I will have a chance in the next 2 weeks to look into it.

If the issue hasn't been fixed after that - or if I find time beforehand - then I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants