Fix for ignoring explicit empty host header values #1258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
#1257
Rationale
Includes a failing test and a suggestion for how that test can be made to pass.
Changes
undefined
; and 3) it is an empty string.Features
N/A
Bug Fixes
Fixes #1257
Breaking Changes and Deprecations
Anyone relying on being able to explicitly set a header to an empty string and have that default to the target host will observe a change in behaviour.
Status
KEY: S = Skipped, x = complete