Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ignoring explicit empty host header values #1258

Merged
merged 2 commits into from Mar 2, 2022
Merged

Fix for ignoring explicit empty host header values #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a60cde
Add failing test for #1275
ggoodman Mar 1, 2022
3187649
Fix for explicit host header that is empty string
ggoodman Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/client.js
View file
Open in desktop
Expand Up @@ -1481,7 +1481,7 @@ function write (client, request) {

let header = `${method} ${path} HTTP/1.1\r\n`

if (host) {
if (typeof host === 'string') {
header += `host: ${host}\r\n`
} else {
header += client[kHostHeader]
Expand Down
28 changes: 28 additions & 0 deletions test/client-request.js
View file
Open in desktop
Expand Up @@ -281,6 +281,34 @@ test('request text', (t) => {
})
})

test('empty host header', (t) => {
t.plan(3)

const server = createServer((req, res) => {
res.end(req.headers.host)
})
t.teardown(server.close.bind(server))

server.listen(0, async () => {
const serverAddress = `localhost:${server.address().port}`;
const client = new Client(`http://${serverAddress}`)
t.teardown(client.destroy.bind(client))

const getWithHost = async (host, wanted) => {
const { body } = await client.request({
path: '/',
method: 'GET',
headers: { host }
})
t.strictSame(await body.text(), wanted)
}

await getWithHost('test', 'test')
await getWithHost(undefined, serverAddress)
await getWithHost('', '')
})
})

test('request long multibyte text', (t) => {
t.plan(1)

Expand Down