chore: add lint-staged for running the lint & test scripts
#1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
reviewed
Apr 20, 2022
ronag
reviewed
Apr 20, 2022
.husky/pre-push
Outdated
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| npx --no-install lint-staged |
There was a problem hiding this comment.
Why pre-push? Why isn't pre-commit sufficient?
There was a problem hiding this comment.
pre-push provides another layer of validation ?
There was a problem hiding this comment.
But there is nothing that pre-push can catch that pre-commit doesn't? Is there? You can't push something that's not commited. Or am I missing something?
There was a problem hiding this comment.
Agreed, pre-push does nothing special than pre-commit but I personally use it everywhere, so it was a opinionated opinion I guess 😉
- Fixed in f1a4d5e
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
Merged
mcollina
pushed a commit
that referenced
this pull request
May 3, 2022
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
…1349) * chore(husky): add `pre-push` hook * feat: add `lint-staged` for running scripts * style: fix lint issue * chore: remove lint-staged as devDep * fix: remove pre-push hook Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
…1349) * chore(husky): add `pre-push` hook * feat: add `lint-staged` for running scripts * style: fix lint issue * chore: remove lint-staged as devDep * fix: remove pre-push hook Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
…1349) * chore(husky): add `pre-push` hook * feat: add `lint-staged` for running scripts * style: fix lint issue * chore: remove lint-staged as devDep * fix: remove pre-push hook Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run lint& thenpm run testscripts run only when the.jsor.tsfiles are staged for pushingpre-pushgit hook to run lint-staged on the staged files