Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Trust the filesystem to move files #195

Merged
merged 2 commits into from May 1, 2023
Merged

fix: Trust the filesystem to move files #195

merged 2 commits into from May 1, 2023

Commits on May 1, 2023

  1. fix: Trust the filesystem to move files 

    The original lib/util/move-file.js has gone through many iterations over
the last several years.  It no longer represents anything close to the
original intent.

Most of the functionality it was originally trying to work around is now
something that `@npmcli/fs#moveFile` does, and better.  Trying to move a
file by creating a hard link and unlinking the old file is an
optimization best left to the operating system when you ask it to move a
file.  In fact the `@npmcli/fs#moveFile` method tries a *rename* first,
which is the best choice all around.  It also supports an "overwrite:
false" flag so we can still error out if the destination already exists.

This PR removes all of the old legacy code.
    @wraithgar
    wraithgar committed May 1, 2023
    Configuration menu
    Copy the full SHA
    9791b8d View commit details
    Browse the repository at this point in the history

  2. deps: remove promise-inflight

    @wraithgar
    wraithgar committed May 1, 2023
    Configuration menu
    Copy the full SHA
    9e08980 View commit details
    Browse the repository at this point in the history