fix: Trust the filesystem to move files #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlf
suggested changes
May 1, 2023
The original lib/util/move-file.js has gone through many iterations over the last several years. It no longer represents anything close to the original intent. Most of the functionality it was originally trying to work around is now something that `@npmcli/fs#moveFile` does, and better. Trying to move a file by creating a hard link and unlinking the old file is an optimization best left to the operating system when you ask it to move a file. In fact the `@npmcli/fs#moveFile` method tries a *rename* first, which is the best choice all around. It also supports an "overwrite: false" flag so we can still error out if the destination already exists. This PR removes all of the old legacy code.
wraithgar
force-pushed
the
gar/let-the-os-move
branch
from
a6ce86e
to
9e08980
Compare
nlf
approved these changes
May 1, 2023
Merged
thunder-coding
added a commit
to termux/termux-packages
that referenced
this pull request
May 27, 2023
cacache patch has been removed as it is no longer needed npm/cacache#195
thunder-coding
added a commit
to termux/termux-packages
that referenced
this pull request
Jun 1, 2023
cacache patch has been removed as it is no longer needed npm/cacache#195
thunder-coding
added a commit
to termux/termux-packages
that referenced
this pull request
Jun 3, 2023
cacache patch has been removed as it is no longer needed npm/cacache#195
thunder-coding
added a commit
to termux/termux-packages
that referenced
this pull request
Jun 8, 2023
cacache patch has been removed as it is no longer needed npm/cacache#195
termux-pacman-bot
added a commit
to termux-pacman/termux-packages
that referenced
this pull request
Jun 8, 2023
cacache patch has been removed as it is no longer needed npm/cacache#195
WTNLXTBL
added a commit
to WTNLXTBL/termux-packages
that referenced
this pull request
Jun 8, 2023
cacache patch has been removed as it is no longer needed npm/cacache#195
WTNLXTBL
added a commit
to WTNLXTBL/termux-packages-pacman
that referenced
this pull request
Jun 8, 2023
cacache patch has been removed as it is no longer needed npm/cacache#195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original lib/util/move-file.js has gone through many iterations over
the last several years. It no longer represents anything close to the
original intent.
Most of the functionality it was originally trying to work around is now
something that
@npmcli/fs#moveFiledoes, and better. Trying to move afile by creating a hard link and unlinking the old file is an
optimization best left to the operating system when you ask it to move a
file. In fact the
@npmcli/fs#moveFilemethod tries a rename first,which is the best choice all around. It also supports an "overwrite:
false" flag so we can still error out if the destination already exists.
This PR removes all of the old legacy code.
Closes #155