fix(tests): move more tests to use real npm #3463
Conversation
wraithgar
added
release: next
|
|
||
| exec (args, cb) { | ||
| super.exec(args, er => { | ||
| if (er && er.code === 'ELIFECYCLE') { |
There was a problem hiding this comment.
Nothing in any of the cli code or its dependencies sets this, and the exit handler suppresses the callback error during any command that shells out anyways.
There was a problem hiding this comment.
Yes, this is clearly dead code.
package.json
Outdated
| @@ -126,6 +126,7 @@ | |||
| "@npmcli/arborist", | |||
| "@npmcli/ci-detect", | |||
| "@npmcli/config", | |||
| "@npmcli/package-json", | |||
There was a problem hiding this comment.
Looks like the bundle and gitignore didn't get ran in the packge-json PR.
|
Tests are failing because As far as I can tell it should ALWAYS have been failing. ETA: it's failing in |
ruyadorno
removed
the
release: next
wraithgar
force-pushed
the
gar/more-real-tests
branch
from
b062c4a
to
ec52585
Compare
|
Looks like we crossed back over the coverage threshold in the meantime so we can just go forward w/ this w/o having to do the much larger "fix all the coverage" task |
wraithgar
force-pushed
the
gar/more-real-tests
branch
from
ec52585
to
5d1c8d2
Compare
This moves a handful of the smaller tests to using the new npm mock that uses the real actual npm object. It also extends the testing surface area of a few tests back down into the actual `process.spawn` that results, instead of anything internal to the code. Some dead code in `lib/test.js` was found during this, as well as an instance of a module throwing a string instead of an error object. PR-URL: #3463 Credit: @wraithgar Close: #3463 Reviewed-by: @nlf
wraithgar
force-pushed
the
gar/more-real-tests
branch
from
5d1c8d2
to
6a8086e
Compare
This moves a handful of the smaller tests to using the new npm mock that
uses the real actual npm object. It also extends the testing surface
area of a few tests back down into the actual
process.spawnthatresults, instead of anything internal to the code.
Some dead code in
lib/test.jswas found during this, as well as aninstance of a module throwing a string instead of an error object.