Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-gyp@5.0.2 #208

Closed
wants to merge 4 commits into from
Closed

node-gyp@5.0.2 #208

wants to merge 4 commits into from

Conversation

irega
Copy link

@irega irega commented Jul 9, 2019 •
edited

Bumps node-gyp from ^3.8.0 to ^5.0.2. We need this update due to adding Visual Studio 2019 support as I said here

Thank you!

@irega irega requested a review from a team as a code owner July 9, 2019 12:44
@irega irega mentioned this pull request Jul 9, 2019
Closed
@irega
Copy link
Author

irega commented Jul 9, 2019

waiting for approval of npm-lifecycle pull request to sync node-gyp versions and fix the error of the current pull request.

isaacs pushed a commit to npm/npm-lifecycle that referenced this pull request Jul 10, 2019
node-gyp@5.0.2
3c5aae6 
BREAKING CHANGE: requires modifying the version of node-gyp in npm cli.

Required for npm/cli#208
Fix: #37
Close: #38
PR-URL: #38
Credit: @irega
Reviewed-by: @isaacs
@isaacs
Copy link
Contributor

isaacs commented Jul 10, 2019

This will be included in the next release. It took a bit of running around to update it in all the right places :)

Thanks!

@irega
Copy link
Author

irega commented Jul 11, 2019

This will be included in the next release. It took a bit of running around to update it in all the right places :)

Thanks!

Thank you @isaacs tests are failing due to some missing packages. If I execute "npm update" to fix it, tests about "npm search" fail due to some packages update like "call-limit", can you review it?

@isaacs isaacs closed this in ef4445a Jul 11, 2019
This was referenced Aug 13, 2019
Open
Merged
This was referenced Aug 30, 2019
Open
Open
Merged
@renovate renovate bot mentioned this pull request May 29, 2021
Open
1 task
@gutwrinch gutwrinch mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irega @isaacs