#37 node-gyp@5.0.2

[irega]

Bumps node-gyp from ^4.0.0 to ^5.0.2. We need this update due to adding Visual Studio 2019 support and to syncs the version with the included in npm:
npm/cli#208

Thank you!

[irega]

@isaacs tests are failing due to the tap version changed in this commit. It seems with the last tap versions they break the compatibility with nodejs v6. Let me know if I should change something more in the PR. Thank you!

[isaacs]

Can you pull the latest branch and try this again? I rolled back the tap updates. Indeed, "they" break compatibility with node 6, so it'll have to wait for this module's next semver-major bump.

The joke is that I'm the node-tap team. ;P

[irega]

Now it passed tests successfully, thank you @isaacs ! Should I register a new issue in the "node-tap" GitHub repository to fix the nodejs 6 compatibility or you can merge this PR (and publish the new package version)?

[isaacs]

I have a feeling the node-tap team would close that issue as "wontfix". Node 6 is past its LTS expiration date. npm v7 won't support it either.

I'll most likely get this in for npm 6.10.1 or 6.10.2.

[ljharb]

Wouldn't that mean that npm 6 would stop working on node 6 in a non-major release?

[isaacs]

Oh, does node-gyp v5 drop support for Node v6? If so, yes, we'd have to put this off until npm 7.

[isaacs]

@ljharb It looks like node-gyp 5 is passing tests on Node v6, so this should probably be fine.

I was saying that I won't be updating tap to v14 (here or in npm/cli) until npm v7, because it drops node v6 support. So, it'll be in a semver major bump.

[ljharb]

Awesome, that was just my confusion then - thanks for clarifying.

[irega]

I have a feeling the node-tap team would close that issue as "wontfix". Node 6 is past its LTS expiration date. npm v7 won't support it either.

I'll most likely get this in for npm 6.10.1 or 6.10.2.

Your feelings are correct 😆 I totally agree. Waiting for the new "npm-lifecycle" version to continue with the npm PR, then. Thank you!