New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug in "npm show" #5011
Fixed bug in "npm show" #5011
Conversation
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Tests are now running properly |
One space too many Co-authored-by: Jordan Harband <ljharb@gmail.com>
It looks like some debug logs accidentally got added? |
Forgot to use single quotes. @wraithgar what do you mean exactly? |
@@ -0,0 +1,30 @@ | |||
0 timing npm:load:whichnode Completed in 1ms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukaskuhn-lku these debug files
@@ -0,0 +1,30 @@ | |||
0 timing npm:load:whichnode Completed in 1ms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukaskuhn-lku these debug files
@wraithgar thanks, removed those files |
Added test for the bug fix so coverage should be back at 100% |
Closing in favor of #5035, which is this PR with one commit added to fix tests. Thanks for making this PR! |
This fixes an error in
npm show
. When callingnpm show
with a specific version of a package that does not exist, it does not show anything and gives a zero exit code. This has been changed: now it gives a 404 Error similar to if the package does not exist. Can be tested withnpm show express@5.0.0
(local:node bin/npm-cli.js info express@5.0.0
)References
Fixes #4964